From: Uros Bizjak <ubizjak@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, i386]: Fix PR 65871, bzhi builtin/intrinsic wrongly assumes bzhi instruction doesn't set the ZF flag
Date: Wed, 29 Apr 2015 20:26:00 -0000 [thread overview]
Message-ID: <CAFULd4ax7fmSZuHr_ntSyg3MOG1ixSdrJEHuhrBg8uMXSG2PEA@mail.gmail.com> (raw)
In-Reply-To: <20150429192325.GK1751@tucnak.redhat.com>
On Wed, Apr 29, 2015 at 9:23 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Apr 29, 2015 at 09:02:16PM +0200, Uros Bizjak wrote:
>> Hello!
>>
>> Attached patch implements a CCZ-only setting pattern for a couple of
>> BMI[,2] intrinsics.
>
> What about the case when the result is used, but also tested for zero or
> non-zero? Like e.g.
> int bar (void);
> int foo (unsigned int x, unsigned int y)
> {
> int v = __builtin_ia32_bextr_u32 (x, y);
> if (v)
> return v;
> return bar ();
> }
Yes, I have considered this usage, but it would require *another*
pattern. I don't think it is worth just to have one test insn less...
Uros.
next prev parent reply other threads:[~2015-04-29 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 19:11 Uros Bizjak
2015-04-29 19:33 ` Jakub Jelinek
2015-04-29 20:26 ` Uros Bizjak [this message]
2015-04-29 21:22 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4ax7fmSZuHr_ntSyg3MOG1ixSdrJEHuhrBg8uMXSG2PEA@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).