From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110532 invoked by alias); 22 Jun 2017 07:13:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 110469 invoked by uid 89); 22 Jun 2017 07:13:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1604, Consequently X-HELO: mail-ua0-f195.google.com Received: from mail-ua0-f195.google.com (HELO mail-ua0-f195.google.com) (209.85.217.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 07:13:53 +0000 Received: by mail-ua0-f195.google.com with SMTP id g40so1094930uaa.3 for ; Thu, 22 Jun 2017 00:13:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FxOJVEBDEM6Cue99ZVd1etATa9AXO+iN7MomsI/ggsk=; b=fCYikNqTDnycxkJ0bSuJAySnN/e5PRq6au96j10vvrqugMOHoO/f8hxMJMFZFXiDC0 /X42b77Cfz4pTvRljnJZZwHeVi06ovCY62vNkwhx+eag6jGtZA0vSugmVVQHJ+Ox76Rn nVCejVnGArPkW95QR2QOu9pBg04NBetEpx1w3J6Q/ywtcT1egF/lDWJtVsD61US9EJck MhDF/9+cAsG4eI4D1zOSw8A9Xr6XsR7THxUkrNyYJZ+40UU7bVg17YMEk/74W2aeb4vG Yf6EEYYqm2MvKmJAzMhO1NrHd23TNm2Y5dVK07eyDFrDhiDtUDDUcPUfLftk2+xcUGVl 8bcQ== X-Gm-Message-State: AKS2vOzM4Vp/2lEFOiYLgBQEorXyHuXvxjuLrt083JtiFVhIBNDi1z/1 wqh2kXoEML8Rz6DOJ5VveOcWtcOPyw== X-Received: by 10.176.9.72 with SMTP id c8mr872703uah.145.1498115631745; Thu, 22 Jun 2017 00:13:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.69.9 with HTTP; Thu, 22 Jun 2017 00:13:51 -0700 (PDT) In-Reply-To: References: From: Uros Bizjak Date: Thu, 22 Jun 2017 07:13:00 -0000 Message-ID: Subject: Re: [PATCH, alpha, go]: Introduce applyRelocationsALPHA To: Ian Lance Taylor Cc: "gcc-patches@gcc.gnu.org" , "gofrontend-dev@googlegroups.com" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-06/txt/msg01621.txt.bz2 On Thu, Jun 22, 2017 at 12:39 AM, Ian Lance Taylor wrote: > On Tue, Jun 20, 2017 at 12:46 PM, Uros Bizjak wrote: >> This patch inroduces applyRelocationsALPHA to solve: >> >> FAIL: TestCgoConsistentResults >> FAIL: TestCgoPkgConfig >> FAIL: TestCgoHandlesWlORIGIN >> >> gotools errors. >> >> Bootstrapped and regression tested on alphaev68-linux-gnu. > > Thanks! Committed to mainline. Thanks! However, there is one another issue with zdefaultcc.go generation. On my system, the default gccgo, gcc and g++ are installed in: $ which gccgo /usr/bin/gccgo $ which gcc /usr/bin/gcc but gotools Makefile uses $(bindir) to derive absolute path to the binaries: echo 'package main' > zdefaultcc.go.tmp echo 'const defaultGCCGO = "$(bindir)/$(GCCGO_INSTALL_NAME)"' >> zdefaultcc.go.tmp echo 'const defaultCC = "$(bindir)/$(GCC_INSTALL_NAME)"' >> zdefaultcc.go.tmp echo 'const defaultCXX = "$(bindir)/$(GXX_INSTALL_NAME)"' >> zdefaultcc.go.tmp echo 'const defaultPkgConfig = "pkg-config"' >> zdefaultcc.go.tmp However, since $prefix (by default) points to /usr/local, $bindir points to /usr/local/bin. Consequently, zdefaultcc.go reads: package main const defaultGCCGO = "/usr/local/bin/gccgo" const defaultCC = "/usr/local/bin/gcc" const defaultCXX = "/usr/local/bin/g++" const defaultPkgConfig = "pkg-config" The absolute path is wrong, since - as mentioned above - the system compiler is installed in /usr/bin. Probably we just need to remove $bindir and assume that these binaries exist in $PATH. Uros.