From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by sourceware.org (Postfix) with ESMTPS id B36893832364 for ; Wed, 7 Dec 2022 07:10:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B36893832364 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb35.google.com with SMTP id o127so21569355yba.5 for ; Tue, 06 Dec 2022 23:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DzfVM2BSb6Uo2pYyVJn3QGLEsfj3Py/rvrHSfBtFcm0=; b=bXsT1HdOOTozyi4RYB5Z9y+/6GySbUV93qDK2U56VztIHGhIqc4OMmFaNDsee6W0XG cR5RuBvhelB35hNW9mbZc8EynFq0APciIaBKef8mUehjVCYaL/92xh6S3hr3bKQcw5kW ItJ8kP/aq/pTDVsH+S6X3iS0y6UBVAA1LQpNRf/AktW0TREXFHOaTMr8iOWzvliu0V0Q v1dqVXtB3ngaIGd8kt+Zk17W564xtwSRn3YwEWA1pECJZKdykpjf1vA2T0NfcOCRQDW9 EluPDYrv0avqArtXW+Thh2AOCP2Fft9OhPQRAn7obB4LMttWOd5rUrvbg6rTDO63eUGH kN+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DzfVM2BSb6Uo2pYyVJn3QGLEsfj3Py/rvrHSfBtFcm0=; b=OcNQ/+ABrAxsKFCrFrZDBSCMrE9NvZ3453X4xny4E4ZPLo1lcGzvpcEcEeogrSlNMG iPr2vyNEaMbh2JKZ9ISkgpjHIOv3X9+eJ6rLTEr75OfMelEsYqg0vWrCBw0NEG21zRsG Z/KdNaVZijUgh9qqhh8T3QVhVV8nfLzZ/TA+njZ6qsMy/o5ArMGcI9D43KFlQCfcIVKx bqW9R8o6Pn04wNMnuQ8IHVA+rf/aX0aNJ1Hz1FGiwpxpNzAv983ncFu7AuxupkVsfuu0 AeIiF7hoXW6EOC7h3io2Va8fQLv2YdrqTn13yDCkhfrNt/hyS2QD3QAVftkcuNrbr//F vi/w== X-Gm-Message-State: ANoB5pkf+dISPXmZ6U3mDLBTH7TL21RtoqX/XxMLn/JhVvY5IK9DuY+y 9bizIYRlY0Mn2U3crYVTwd0M8LAJiI/k36z/JVU= X-Google-Smtp-Source: AA0mqf5svCC0TtUfBziCo1bqdXKw4MSKkCqMHysNoqALi2wCie7r/NeunXJqPeR0xOjAUdPHI9NZeflr7DHiakuXGxQ= X-Received: by 2002:a25:7383:0:b0:6fb:b4af:e56e with SMTP id o125-20020a257383000000b006fbb4afe56emr24401700ybc.60.1670397024987; Tue, 06 Dec 2022 23:10:24 -0800 (PST) MIME-Version: 1.0 References: <20221207063644.100134-1-hongyu.wang@intel.com> In-Reply-To: <20221207063644.100134-1-hongyu.wang@intel.com> From: Uros Bizjak Date: Wed, 7 Dec 2022 08:10:14 +0100 Message-ID: Subject: Re: [PATCH] i386: Avoid fma_chain for -march=alderlake and sapphirerapids. To: Hongyu Wang Cc: gcc-patches@gcc.gnu.org, hongtao.liu@intel.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 7, 2022 at 7:36 AM Hongyu Wang wrote: > > For Alderlake there is similar issue like PR 81616, enable > avoid_fma256_chain will also benefit on Intel latest platforms > Alderlake and Sapphire Rapids. > > Bootstrapped/regtested on x86_64-pc-linux-gnu{-m32,}. > > Ok for master? > > gcc/ChangeLog: > > * config/i386/x86-tune.def (X86_TUNE_AVOID_256FMA_CHAINS): Add > m_SAPPHIRERAPIDS, m_ALDERLAKE and m_CORE_ATOM. OK. Thanks, Uros. > --- > gcc/config/i386/x86-tune.def | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/config/i386/x86-tune.def b/gcc/config/i386/x86-tune.def > index cd66f335113..db85de20bae 100644 > --- a/gcc/config/i386/x86-tune.def > +++ b/gcc/config/i386/x86-tune.def > @@ -499,7 +499,8 @@ DEF_TUNE (X86_TUNE_AVOID_128FMA_CHAINS, "avoid_fma_chains", m_ZNVER) > > /* X86_TUNE_AVOID_256FMA_CHAINS: Avoid creating loops with tight 256bit or > smaller FMA chain. */ > -DEF_TUNE (X86_TUNE_AVOID_256FMA_CHAINS, "avoid_fma256_chains", m_ZNVER2 | m_ZNVER3) > +DEF_TUNE (X86_TUNE_AVOID_256FMA_CHAINS, "avoid_fma256_chains", m_ZNVER2 | m_ZNVER3 > + | m_ALDERLAKE | m_SAPPHIRERAPIDS | m_CORE_ATOM) > > /* X86_TUNE_V2DF_REDUCTION_PREFER_PHADDPD: Prefer haddpd > for v2df vector reduction. */ > -- > 2.18.1 >