From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41021 invoked by alias); 29 Apr 2016 11:52:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 41006 invoked by uid 89); 29 Apr 2016 11:52:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1708 X-HELO: mail-yw0-f169.google.com Received: from mail-yw0-f169.google.com (HELO mail-yw0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 29 Apr 2016 11:52:05 +0000 Received: by mail-yw0-f169.google.com with SMTP id t10so181874874ywa.0 for ; Fri, 29 Apr 2016 04:52:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=9SP8ITa2EebGQEAzGje0cUdX/2oiCdGxQggVWlJYWaY=; b=iVS4UZeWLiGBhyOmYED29Sy7eXrLLlLCXvBsCXY2pTR2X0k3zXD94BtzjlUUACFg5T wsNZM5pV83dc5FC4UJxiE7b2TiG5PvnMa8wyUGkbdjIFmnaKQVkn+jolf5VHq66pn3Zi 4yqcARmAGcL5zjn06i3BcrQXXoY/fNnu69QdWajxO/G8PhWHnt+/ye5wQwZoSD+TpiXT hJgOOX7b08P7SXFmUxuyRK1zPIGm/y7S5Gzdkyx1C5z+iX6QuA57spnuzUuZ80w/ygWq P1XgKN8vsdRLgvFXZVKL3jjCTVKDCLieGMPWZYhhW03xZIwR4ITw47vtW8bAqMK1f+Xf nawA== X-Gm-Message-State: AOPr4FW+VXGe3m1zfeHEmU8Ko3BriCK3MS80xYcnogoD9EuIIJBQKWxL2xfDzMVIybe0rReqS78gKhdSJ9uovg== MIME-Version: 1.0 X-Received: by 10.176.5.226 with SMTP id e89mr11113812uae.50.1461930723059; Fri, 29 Apr 2016 04:52:03 -0700 (PDT) Received: by 10.103.76.220 with HTTP; Fri, 29 Apr 2016 04:52:02 -0700 (PDT) In-Reply-To: <1587814.Yvh9q60GN3@polaris> References: <3799415.uPfXC5v7Nr@polaris> <1587814.Yvh9q60GN3@polaris> Date: Fri, 29 Apr 2016 11:52:00 -0000 Message-ID: Subject: Re: [PATCH, i386]: Extend TARGET_READ_MODIFY{,_WRITE} peepholes to all integer modes From: Uros Bizjak To: Eric Botcazou Cc: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary=94eb2c1241686f6b7705319e45fc X-SW-Source: 2016-04/txt/msg01983.txt.bz2 --94eb2c1241686f6b7705319e45fc Content-Type: text/plain; charset=UTF-8 Content-length: 532 On Fri, Apr 29, 2016 at 1:23 PM, Eric Botcazou wrote: >> Attached patch was actually tested on a couple of cases. It generates >> the same assembly as before. > > Note that you could just remove the second ":W" in the define_insn pattern. Eh, then the build yawns about the missing mode of the input operand. > That's better, but not quite it because this segfaults at -O2: This is getting a bit frustrating, but attached patch should solve this failure. Again lightly tested, regtest in progress. Uros. --94eb2c1241686f6b7705319e45fc Content-Type: text/plain; charset=US-ASCII; name="r.diff.txt" Content-Disposition: attachment; filename="r.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_inlnsknt0 Content-length: 1554 SW5kZXg6IGkzODYubWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaTM4 Ni5tZAkocmV2aXNpb24gMjM1NjIwKQorKysgaTM4Ni5tZAkod29ya2luZyBj b3B5KQpAQCAtODgsNiArODgsNyBAQAogICBVTlNQRUNfU0VUX0dPVF9PRkZT RVQKICAgVU5TUEVDX01FTU9SWV9CTE9DS0FHRQogICBVTlNQRUNfU1RBQ0tf Q0hFQ0sKKyAgVU5TUEVDX1BST0JFX1NUQUNLCiAKICAgOzsgVExTIHN1cHBv cnQKICAgVU5TUEVDX1RQCkBAIC0xNzU1Miw2ICsxNzU1MywzMCBAQAogICBE T05FOwogfSkKIAorKGRlZmluZV9leHBhbmQgInByb2JlX3N0YWNrIgorICBb KG1hdGNoX29wZXJhbmQgMCAibWVtb3J5X29wZXJhbmQiKV0KKyAgIiIKK3sK KyAgcnR4ICgqaW5zbikgKHJ0eCwgcnR4KQorICAgID0gKEdFVF9NT0RFIChv cGVyYW5kc1swXSkgPT0gREltb2RlCisgICAgICAgPyBnZW5fcHJvYmVfc3Rh Y2tfZGkgOiBnZW5fcHJvYmVfc3RhY2tfc2kpOworCisgIGVtaXRfaW5zbiAo aW5zbiAob3BlcmFuZHNbMF0sIGNvbnN0MF9ydHgpKTsKKyAgRE9ORTsKK30p CisKKzs7IFVzZSBPUiBmb3Igc3RhY2sgcHJvYmVzLCB0aGlzIGlzIHNob3J0 ZXIuCisoZGVmaW5lX2luc24gInByb2JlX3N0YWNrXzxtb2RlPiIKKyAgWyhz ZXQgKG1hdGNoX29wZXJhbmQ6VyAwICJtZW1vcnlfb3BlcmFuZCIgIj1tIikK KwkodW5zcGVjOlcgWyhtYXRjaF9vcGVyYW5kOlcgMSAiY29uc3QwX29wZXJh bmQiKV0KKwkJICBVTlNQRUNfUFJPQkVfU1RBQ0spKQorICAgKGNsb2JiZXIg KHJlZzpDQyBGTEFHU19SRUcpKV0KKyAgIiIKKyAgIm9yezxpbW9kZXN1ZmZp eD59XHR7JTEsICUwfCUwLCAlMX0iCisgIFsoc2V0X2F0dHIgInR5cGUiICJh bHUxIikKKyAgIChzZXRfYXR0ciAibW9kZSIgIjxNT0RFPiIpCisgICAoc2V0 X2F0dHIgImxlbmd0aF9pbW1lZGlhdGUiICIxIildKQorICAKIChkZWZpbmVf aW5zbiAiYWRqdXN0X3N0YWNrX2FuZF9wcm9iZTxtb2RlPiIKICAgWyhzZXQg KG1hdGNoX29wZXJhbmQ6UCAwICJyZWdpc3Rlcl9vcGVyYW5kIiAiPXIiKQog CSh1bnNwZWNfdm9sYXRpbGU6UCBbKG1hdGNoX29wZXJhbmQ6UCAxICJyZWdp c3Rlcl9vcGVyYW5kIiAiMCIpXQo= --94eb2c1241686f6b7705319e45fc--