* [PATCH] PR64393
@ 2015-01-14 12:08 Ilya Tocar
2015-01-14 12:15 ` Uros Bizjak
0 siblings, 1 reply; 3+ messages in thread
From: Ilya Tocar @ 2015-01-14 12:08 UTC (permalink / raw)
To: Uros Bizjak; +Cc: GCC Patches
Hi,
This patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64393
It makes -mavx512vbmi enable avx512bw, as it requires 64-bit masks.
OK for trunk?
ChangeLog:
gcc/
PR target/64393
* common/config/i386/i386-common.c (OPTION_MASK_ISA_AVX512VBMI_SET):
Enable AVX512BW.
(OPTION_MASK_ISA_AVX512BW_UNSET): Disable AVX512BW.
* config/i386/i386.c (ix86_hard_regno_mode_ok): Don't check
AVX512VBMI, as it implies AVX512BW.
testsuite/
PR target/64393
* gcc.target/i386/pr64393.c: New test.
---
gcc/common/config/i386/i386-common.c | 5 +++--
gcc/config/i386/i386.c | 2 +-
gcc/testsuite/gcc.target/i386/pr64393.c | 12 ++++++++++++
3 files changed, 16 insertions(+), 3 deletions(-)
create mode 100644 gcc/testsuite/gcc.target/i386/pr64393.c
diff --git a/gcc/common/config/i386/i386-common.c b/gcc/common/config/i386/i386-common.c
index 77edb47..4e5687a 100644
--- a/gcc/common/config/i386/i386-common.c
+++ b/gcc/common/config/i386/i386-common.c
@@ -74,7 +74,7 @@ along with GCC; see the file COPYING3. If not see
#define OPTION_MASK_ISA_AVX512IFMA_SET \
(OPTION_MASK_ISA_AVX512IFMA | OPTION_MASK_ISA_AVX512F_SET)
#define OPTION_MASK_ISA_AVX512VBMI_SET \
- (OPTION_MASK_ISA_AVX512VBMI | OPTION_MASK_ISA_AVX512F_SET)
+ (OPTION_MASK_ISA_AVX512VBMI | OPTION_MASK_ISA_AVX512BW_SET)
#define OPTION_MASK_ISA_RTM_SET OPTION_MASK_ISA_RTM
#define OPTION_MASK_ISA_PRFCHW_SET OPTION_MASK_ISA_PRFCHW
#define OPTION_MASK_ISA_RDSEED_SET OPTION_MASK_ISA_RDSEED
@@ -171,7 +171,8 @@ along with GCC; see the file COPYING3. If not see
#define OPTION_MASK_ISA_AVX512PF_UNSET OPTION_MASK_ISA_AVX512PF
#define OPTION_MASK_ISA_AVX512ER_UNSET OPTION_MASK_ISA_AVX512ER
#define OPTION_MASK_ISA_AVX512DQ_UNSET OPTION_MASK_ISA_AVX512DQ
-#define OPTION_MASK_ISA_AVX512BW_UNSET OPTION_MASK_ISA_AVX512BW
+#define OPTION_MASK_ISA_AVX512BW_UNSET \
+ (OPTION_MASK_ISA_AVX512BW | OPTION_MASK_ISA_AVX512VBMI_UNSET)
#define OPTION_MASK_ISA_AVX512VL_UNSET OPTION_MASK_ISA_AVX512VL
#define OPTION_MASK_ISA_AVX512IFMA_UNSET OPTION_MASK_ISA_AVX512IFMA
#define OPTION_MASK_ISA_AVX512VBMI_UNSET OPTION_MASK_ISA_AVX512VBMI
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index 7a39f80..91eae5a 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -41669,7 +41669,7 @@ ix86_hard_regno_mode_ok (int regno, machine_mode mode)
return VALID_FP_MODE_P (mode);
if (MASK_REGNO_P (regno))
return (VALID_MASK_REG_MODE (mode)
- || ((TARGET_AVX512BW || TARGET_AVX512VBMI)
+ || (TARGET_AVX512BW
&& VALID_MASK_AVX512BW_MODE (mode)));
if (BND_REGNO_P (regno))
return VALID_BND_REG_MODE (mode);
diff --git a/gcc/testsuite/gcc.target/i386/pr64393.c b/gcc/testsuite/gcc.target/i386/pr64393.c
new file mode 100644
index 0000000..37a0e48
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr64393.c
@@ -0,0 +1,12 @@
+/* { dg-do compile } */
+/* { dg-options "-O -mavx512vbmi" } */
+
+int a[1024];
+
+void
+foo (int i)
+{
+ for (;; i++)
+ if (a[i] != (i ^ (i * 3) ^ (i * 7)))
+ return;
+}
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PR64393
2015-01-14 12:08 [PATCH] PR64393 Ilya Tocar
@ 2015-01-14 12:15 ` Uros Bizjak
2015-01-14 12:18 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: Uros Bizjak @ 2015-01-14 12:15 UTC (permalink / raw)
To: Ilya Tocar; +Cc: GCC Patches
On Wed, Jan 14, 2015 at 12:56 PM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> Hi,
>
> This patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64393
> It makes -mavx512vbmi enable avx512bw, as it requires 64-bit masks.
> OK for trunk?
>
> ChangeLog:
>
> gcc/
> PR target/64393
> * common/config/i386/i386-common.c (OPTION_MASK_ISA_AVX512VBMI_SET):
> Enable AVX512BW.
> (OPTION_MASK_ISA_AVX512BW_UNSET): Disable AVX512BW.
> * config/i386/i386.c (ix86_hard_regno_mode_ok): Don't check
> AVX512VBMI, as it implies AVX512BW.
>
> testsuite/
> PR target/64393
> * gcc.target/i386/pr64393.c: New test.
OK.
Thanks,
Uros.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PR64393
2015-01-14 12:15 ` Uros Bizjak
@ 2015-01-14 12:18 ` H.J. Lu
0 siblings, 0 replies; 3+ messages in thread
From: H.J. Lu @ 2015-01-14 12:18 UTC (permalink / raw)
To: Uros Bizjak; +Cc: Ilya Tocar, GCC Patches
On Wed, Jan 14, 2015 at 4:08 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Wed, Jan 14, 2015 at 12:56 PM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> Hi,
>>
>> This patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64393
>> It makes -mavx512vbmi enable avx512bw, as it requires 64-bit masks.
>> OK for trunk?
>>
>> ChangeLog:
>>
>> gcc/
>> PR target/64393
>> * common/config/i386/i386-common.c (OPTION_MASK_ISA_AVX512VBMI_SET):
>> Enable AVX512BW.
>> (OPTION_MASK_ISA_AVX512BW_UNSET): Disable AVX512BW.
^^^^^^^^^^^^^^^ Typo.
>> * config/i386/i386.c (ix86_hard_regno_mode_ok): Don't check
>> AVX512VBMI, as it implies AVX512BW.
>>
>> testsuite/
>> PR target/64393
>> * gcc.target/i386/pr64393.c: New test.
>
> OK.
>
> Thanks,
> Uros.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-14 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-14 12:08 [PATCH] PR64393 Ilya Tocar
2015-01-14 12:15 ` Uros Bizjak
2015-01-14 12:18 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).