From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9209 invoked by alias); 30 Jan 2015 10:07:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9135 invoked by uid 89); 30 Jan 2015 10:07:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 30 Jan 2015 10:07:47 +0000 Received: by mail-oi0-f44.google.com with SMTP id a3so33888918oib.3 for ; Fri, 30 Jan 2015 02:07:45 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.202.176.4 with SMTP id z4mr3018912oie.43.1422612465366; Fri, 30 Jan 2015 02:07:45 -0800 (PST) Received: by 10.60.159.166 with HTTP; Fri, 30 Jan 2015 02:07:45 -0800 (PST) In-Reply-To: <54CB20CA.3070709@redhat.com> References: <54CB20CA.3070709@redhat.com> Date: Fri, 30 Jan 2015 11:02:00 -0000 Message-ID: Subject: Re: [PATCH][PR target/15184] Fix for direct byte access on x86 From: Uros Bizjak To: "gcc-patches@gcc.gnu.org" Cc: Jeff Law , Jakub Jelinek , Dominique Dhumieres Content-Type: multipart/mixed; boundary=001a113d3a92a6f53a050ddbc670 X-SW-Source: 2015-01/txt/msg02706.txt.bz2 --001a113d3a92a6f53a050ddbc670 Content-Type: text/plain; charset=UTF-8 Content-length: 911 On Fri, Jan 30, 2015 at 7:12 AM, Jeff Law wrote: >> Hello! >> >>> So here's the updated patch which handles all 4 testcases from the PR as >>> well as a couple of my own. >> >> >> @@ -0,0 +1,33 @@ >> +/* PR 15184 first two tests, plus two addition ones. */ >> +/* { dg-do compile } */ >> +/* { dg-options "-O2 -m32 -march=pentiumpro" } */ >> >> No, we don't want -m32 in dg-options. Please write this part as: >> >> /* { dg-do compile { target ia32 } } */ >> /* { dg-options "-O2 -march=pentiumpro" } */ > > Will update after sniff testing. Sorry for the noise. I'll commit the attached patch that fixes this and -fpic problem as soon as regtest finishes. 2015-01-30 Uros Bizjak * gcc.target/i386/pr15184-1.c: Compile for ia32 target only. (dg-options): Remove -m32. (dg-final): Scan for "movb %al" only. * gcc.target/i386/pr15184-2.c: Ditto. Uros. --001a113d3a92a6f53a050ddbc670 Content-Type: text/plain; charset=US-ASCII; name="t.diff.txt" Content-Disposition: attachment; filename="t.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i5jeq4yc0 Content-length: 2514 SW5kZXg6IGdjYy50YXJnZXQvaTM4Ni9wcjE1MTg0LTEuYwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBnY2MudGFyZ2V0L2kzODYvcHIxNTE4NC0xLmMJ KHJldmlzaW9uIDIyMDI3MykKKysrIGdjYy50YXJnZXQvaTM4Ni9wcjE1MTg0 LTEuYwkod29ya2luZyBjb3B5KQpAQCAtMSwxMSArMSwxMCBAQAogLyogUFIg MTUxODQgZmlyc3QgdHdvIHRlc3RzLCBwbHVzIHR3byBhZGRpdGlvbiBvbmVz LiAgKi8KLS8qIHsgZGctZG8gY29tcGlsZSB9ICovCi0vKiB7IGRnLW9wdGlv bnMgIi1PMiAtbTMyIC1tYXJjaD1wZW50aXVtcHJvIiB9ICovCisvKiB7IGRn LWRvIGNvbXBpbGUgeyB0YXJnZXQgaWEzMiB9IH0gKi8KKy8qIHsgZGctb3B0 aW9ucyAiLU8yIC1tYXJjaD1wZW50aXVtcHJvIiB9ICovCiAKLSNkZWZpbmUg cmVncGFybSBfX2F0dHJpYnV0ZV9fKChfX3JlZ3Bhcm1fXygzKSkpCisjZGVm aW5lIHJlZ3Bhcm0gX19hdHRyaWJ1dGVfXygoX19yZWdwYXJtX18oMSkpKQog CiBleHRlcm4gdW5zaWduZWQgaW50IHg7Ci1leHRlcm4gdW5zaWduZWQgc2hv cnQgeTsKIAogdm9pZCByZWdwYXJtIGYwKHVuc2lnbmVkIGNoYXIgYykKIHsK QEAgLTI5LDUgKzI4LDUgQEAKIAogLyogRWFjaCBmdW5jdGlvbiBzaG91bGQg Y29tcGlsZSBkb3duIHRvIGEgYnl0ZSBtb3ZlIGZyb20KICAgIHRoZSBpbnB1 dCByZWdpc3RlciBpbnRvIHgsIHBvc3NpYmx5IGF0IGFuIG9mZnNldCB3aXRo aW4geC4gICovCi0vKiB7IGRnLWZpbmFsIHsgc2Nhbi1hc3NlbWJsZXItdGlt ZXMgIlx0bW92Ylx0JWFsLCB4IiA0IH0gfSAqLworLyogeyBkZy1maW5hbCB7 IHNjYW4tYXNzZW1ibGVyLXRpbWVzICJtb3ZiXFsgXFx0XF0rJWFsIiA0IH0g fSAqLwogCkluZGV4OiBnY2MudGFyZ2V0L2kzODYvcHIxNTE4NC0yLmMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gZ2NjLnRhcmdldC9pMzg2L3ByMTUx ODQtMi5jCShyZXZpc2lvbiAyMjAyNzMpCisrKyBnY2MudGFyZ2V0L2kzODYv cHIxNTE4NC0yLmMJKHdvcmtpbmcgY29weSkKQEAgLTEsMTAgKzEsOSBAQAog LyogUFIgMTUxODQgc2Vjb25kIHR3byB0ZXN0cwotLyogeyBkZy1kbyBjb21w aWxlIH0gKi8KLS8qIHsgZGctb3B0aW9ucyAiLU8yIC1tMzIgLW1hcmNoPXBl bnRpdW1wcm8iIH0gKi8KKy8qIHsgZGctZG8gY29tcGlsZSB7IHRhcmdldCBp YTMyIH0gfSAqLworLyogeyBkZy1vcHRpb25zICItTzIgLW1hcmNoPXBlbnRp dW1wcm8iIH0gKi8KIAotI2RlZmluZSByZWdwYXJtIF9fYXR0cmlidXRlX18o KF9fcmVncGFybV9fKDMpKSkKKyNkZWZpbmUgcmVncGFybSBfX2F0dHJpYnV0 ZV9fKChfX3JlZ3Bhcm1fXygxKSkpCiAKLWV4dGVybiB1bnNpZ25lZCBpbnQg eDsKIGV4dGVybiB1bnNpZ25lZCBzaG9ydCB5OwogCiB2b2lkIHJlZ3Bhcm0g ZzAodW5zaWduZWQgY2hhciBjKQpAQCAtMTgsNiArMTcsNiBAQAogfQogCiAv KiBFYWNoIGZ1bmN0aW9uIHNob3VsZCBjb21waWxlIGRvd24gdG8gYSBieXRl IG1vdmUgZnJvbQotICAgdGhlIGlucHV0IHJlZ2lzdGVyIGludG8geCwgcG9z c2libHkgYXQgYW4gb2Zmc2V0IHdpdGhpbiB4LiAgKi8KLS8qIHsgZGctZmlu YWwgeyBzY2FuLWFzc2VtYmxlci10aW1lcyAiXHRtb3ZiXHQlYWwsIHkiIDIg fSB9ICovCisgICB0aGUgaW5wdXQgcmVnaXN0ZXIgaW50byB5LCBwb3NzaWJs eSBhdCBhbiBvZmZzZXQgd2l0aGluIHkuICAqLworLyogeyBkZy1maW5hbCB7 IHNjYW4tYXNzZW1ibGVyLXRpbWVzICJtb3ZiXFsgXFx0XF0rJWFsIiAyIH0g fSAqLwogCg== --001a113d3a92a6f53a050ddbc670--