From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-413552-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 74310 invoked by alias); 10 Nov 2015 18:24:54 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 74296 invoked by uid 89); 10 Nov 2015 18:24:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-oi0-f46.google.com
Received: from mail-oi0-f46.google.com (HELO mail-oi0-f46.google.com) (209.85.218.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 10 Nov 2015 18:24:52 +0000
Received: by oiad129 with SMTP id d129so3068056oia.0        for <gcc-patches@gcc.gnu.org>; Tue, 10 Nov 2015 10:24:50 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.202.195.202 with SMTP id t193mr2338861oif.94.1447179890618; Tue, 10 Nov 2015 10:24:50 -0800 (PST)
Received: by 10.60.138.6 with HTTP; Tue, 10 Nov 2015 10:24:50 -0800 (PST)
In-Reply-To: <CAFULd4brqWm6dwc843B8DG_C_OXeHE+UoFjmESH_2tFUpm9tvg@mail.gmail.com>
References: <CAFULd4ZadbE1LO_TzDpi6D3qw3BKJ=YwXXVB9QT2OuhAHpEy+w@mail.gmail.com>	<564230CC.4080400@redhat.com>	<CAFULd4brqWm6dwc843B8DG_C_OXeHE+UoFjmESH_2tFUpm9tvg@mail.gmail.com>
Date: Tue, 10 Nov 2015 18:24:00 -0000
Message-ID: <CAFULd4b3Vg-ao3HV7jaT5h6dfbzK-7eCD9YL4oGiTnxZbLJKpg@mail.gmail.com>
Subject: Re: [PATCH, i386]: Fix gcc.c-torture/compile/pr41634.c FAIL
From: Uros Bizjak <ubizjak@gmail.com>
To: Richard Henderson <rth@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2015-11/txt/msg01268.txt.bz2

On Tue, Nov 10, 2015 at 7:14 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Tue, Nov 10, 2015 at 7:00 PM, Richard Henderson <rth@redhat.com> wrote:
>> On 11/10/2015 06:54 PM, Uros Bizjak wrote:
>>>
>>> -      return "movabs{<imodesuffix>}\t{%1, %0|%0, %1}";
>>> +      return "movabs{<imodesuffix>}\t{%1, %P0|[%P0], %1}";
>>
>>
>> The thing that's missing from this, that's present in the patch that I sent
>> you off-list, is the <iptrsize> thing for Intel syntax.
>>
>> Would you prefer to just add that back here via <iptrsize>, rather than
>> using a new %v specifier like in my patch?
>
> I have opted for the same assembly code as it was generated
> previously. But, since we have macroized pattern and already available
> mode attribute, I'd prefer to use <iptrsize> PTR [...]. There are
> already a couple of examples using this approach in i386.md.
>
> BTW: gas is able to determine pointer size from register name, so
> having PTR prefix does not change generated object code.

I'm testing following patch:

--cut here--
Index: i386.md
===================================================================
--- i386.md     (revision 230117)
+++ i386.md     (working copy)
@@ -2601,7 +2601,7 @@
   switch (which_alternative)
     {
     case 0:
-      return "movabs{<imodesuffix>}\t{%1, %P0|[%P0], %1}";
+      return "movabs{<imodesuffix>}\t{%1, %P0|<iptrsize> PTR [%P0], %1}";
     case 1:
       return "mov{<imodesuffix>}\t{%1, %0|%0, %1}";
     default:
@@ -2625,7 +2625,7 @@
   switch (which_alternative)
     {
     case 0:
-      return "movabs{<imodesuffix>}\t{%P1, %0|%0, [%P1]}";
+      return "movabs{<imodesuffix>}\t{%P1, %0|%0, <iptrsize> PTR [%P1]}";
     case 1:
       return "mov{<imodesuffix>}\t{%1, %0|%0, %1}";
     default:
--cut here--

Uros.