From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com
 [IPv6:2607:f8b0:4864:20::734])
 by sourceware.org (Postfix) with ESMTPS id 09DFC3857362
 for <gcc-patches@gcc.gnu.org>; Mon, 20 Jun 2022 14:51:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09DFC3857362
Received: by mail-qk1-x734.google.com with SMTP id g15so7941637qke.4
 for <gcc-patches@gcc.gnu.org>; Mon, 20 Jun 2022 07:51:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=rCAjjt01lQ98d8uWeAjxmgt6tv35qbJUDNTE4Fi+is8=;
 b=gTYulFS2c20cidfjDDMfoI0A5HmUxnenLDQjzR+iQGytGbYvyDNFVa7lNZbtWjJfJr
 8CgFH/WHokt77fS/eeF6yCA8rKwlyWZPwdqKpu0SGXX0J2TRP3tIhB2ZgKoosI6wnsEI
 bkjyE8SU3QERS6Kco7F3yOGkcPrG4cGpVhMDnllhk7iBLEKWwC4jjP8lYWAC4buR3o4Q
 q05NFlMjw3n+4qtcn7bk4Hen6R2P4UoQQzdEX9t4qhc2GgwMpsaSmiLsAC1bRu22cW08
 QKJVmrpiQDlnd1A6ViS/gdXh7lFT5Nu8Z/IpvEER30R94pKQAALkDpdkWwg7ttQOeGXC
 ezbQ==
X-Gm-Message-State: AJIora/AgpK07KViH0+5kB9jEog31KQdG9rvkO0ZHnEn6oP51dq9gKE0
 SgTRIAf2TJ056sN8i1+gynTeLOVYMnSg1azhpQQ=
X-Google-Smtp-Source: AGRyM1tQqA0yECJqZrCRyznq2Y2yiuBbVP+8CU09qQc4DEWIT8ce24G+w0K7n7uIfJtMRA66oj7t8RiZoh718Jd/ELw=
X-Received: by 2002:ae9:d60b:0:b0:6a6:ab28:3c05 with SMTP id
 r11-20020ae9d60b000000b006a6ab283c05mr16450056qkk.180.1655736678299; Mon, 20
 Jun 2022 07:51:18 -0700 (PDT)
MIME-Version: 1.0
References: <20220614192548.1929268-1-hjl.tools@gmail.com>
 <CAMe9rOrCE+VFfM0jV0qT0Ma43T4QOQEo+M3BUrFR2R6rFY8zYQ@mail.gmail.com>
In-Reply-To: <CAMe9rOrCE+VFfM0jV0qT0Ma43T4QOQEo+M3BUrFR2R6rFY8zYQ@mail.gmail.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Mon, 20 Jun 2022 16:51:07 +0200
Message-ID: <CAFULd4b54BKqJua6CRiT0cSadOAsBaLHvg2hHCtoqo0LGXVpsg@mail.gmail.com>
Subject: Re: PING^1 [PATCH] i386: Disallow sibcall when calling ifunc
 functions with PIC register
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jun 2022 14:51:20 -0000

On Mon, Jun 20, 2022 at 4:03 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Jun 14, 2022 at 12:25 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > Disallow siball when calling ifunc functions with PIC register so that
> > PIC register can be restored.
> >
> > gcc/
> >
> >         PR target/105960
> >         * config/i386/i386.cc (ix86_function_ok_for_sibcall): Return
> >         false if PIC register is used when calling ifunc functions.
> >
> > gcc/testsuite/
> >
> >         PR target/105960
> >         * gcc.target/i386/pr105960.c: New test.

LGTM.

Thanks,
Uros.

> > ---
> >  gcc/config/i386/i386.cc                  |  9 +++++++++
> >  gcc/testsuite/gcc.target/i386/pr105960.c | 19 +++++++++++++++++++
> >  2 files changed, 28 insertions(+)
> >  create mode 100644 gcc/testsuite/gcc.target/i386/pr105960.c
> >
> > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
> > index 3d189e124e4..1ca7836e11e 100644
> > --- a/gcc/config/i386/i386.cc
> > +++ b/gcc/config/i386/i386.cc
> > @@ -1015,6 +1015,15 @@ ix86_function_ok_for_sibcall (tree decl, tree exp)
> >         }
> >      }
> >
> > +  if (decl && ix86_use_pseudo_pic_reg ())
> > +    {
> > +      /* When PIC register is used, it must be restored after ifunc
> > +        function returns.  */
> > +       cgraph_node *node = cgraph_node::get (decl);
> > +       if (node && node->ifunc_resolver)
> > +        return false;
> > +    }
> > +
> >    /* Otherwise okay.  That also includes certain types of indirect calls.  */
> >    return true;
> >  }
> > diff --git a/gcc/testsuite/gcc.target/i386/pr105960.c b/gcc/testsuite/gcc.target/i386/pr105960.c
> > new file mode 100644
> > index 00000000000..db137a1642d
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/i386/pr105960.c
> > @@ -0,0 +1,19 @@
> > +/* { dg-do compile } */
> > +/* { dg-require-ifunc "" } */
> > +/* { dg-options "-O2 -fpic" } */
> > +
> > +__attribute__((target_clones("default","fma")))
> > +static inline double
> > +expfull_ref(double x)
> > +{
> > +  return __builtin_pow(x, 0.1234);
> > +}
> > +
> > +double
> > +exp_ref(double x)
> > +{
> > +  return expfull_ref(x);
> > +}
> > +
> > +/* { dg-final { scan-assembler "jmp\[ \t\]*expfull_ref@PLT" { target { ! ia32 } } } } */
> > +/* { dg-final { scan-assembler "call\[ \t\]*expfull_ref@PLT" { target ia32 } } } */
> > --
> > 2.36.1
> >
>
> PING.
>
> --
> H.J.