From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by sourceware.org (Postfix) with ESMTPS id AE9F93857012 for ; Wed, 2 Jun 2021 06:28:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE9F93857012 Received: by mail-qk1-x72f.google.com with SMTP id r17so1319575qkp.10 for ; Tue, 01 Jun 2021 23:28:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/b9jPUtrWc93Nw4G3GjKX/03C79tEBpa8Eq0vPuVjyo=; b=LUdezDvfpts1nvLQzt74UQKG4pldoHvXkSA9R0mDSbi9fTzc4FnXDmuldLc6GdE0WU ShpNAzlcFSixWqjl2ibirZVQAgkL28rMsCMYBTJFWGAEZLuzQ68gQYj5vTnspJsg4yqd IC7nz9P8F6K2mY+9qfC04Y8LBUHl1sBjNHP4bnlhQGpFL1iNkhyanoIqsa4knnB87Xq7 CFQo9wG4AoXPdKP9J+OYvPv5rIB479vZPHOV2NfyOZHNKscRG+h3Fwj8gr6d6x6WuQFF w/Ngh9QYgKyUYg22UyHij3EFtKLb34LOHtMlYJCnDXGesKvtCmFpLayL3zIyDiK9o1Qh Xd0w== X-Gm-Message-State: AOAM531rguJDcxT4zDiXn0Apk7EyY9820mdPw3ZD34PCCRzRyX37aase UnLaSvP7s8mMBc8Iunsi94MX2UKV3TDnNl8g3e0887hwZ0w= X-Google-Smtp-Source: ABdhPJxw49Z/u/rDBTzrYX5NF0hGdrmiHLAxr159IK94ytAVVUGZCq3oziHo6+L7A/f/He/0hc5UujArsBq81KrUZ9M= X-Received: by 2002:a37:424c:: with SMTP id p73mr26179540qka.465.1622615323187; Tue, 01 Jun 2021 23:28:43 -0700 (PDT) MIME-Version: 1.0 References: <513fefb141a66df5675c1cb0210f7f88ace4c740.1622179420.git.linkw@linux.ibm.com> In-Reply-To: <513fefb141a66df5675c1cb0210f7f88ace4c740.1622179420.git.linkw@linux.ibm.com> From: Uros Bizjak Date: Wed, 2 Jun 2021 08:28:32 +0200 Message-ID: Subject: Re: [PATCH 06/11] i386: Update unexpected empty split condition To: Kewen Lin Cc: "gcc-patches@gcc.gnu.org" , Jan Hubicka Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 06:28:45 -0000 On Wed, Jun 2, 2021 at 7:05 AM Kewen Lin wrote: > > gcc/ChangeLog: > > * config/i386/i386.md (*load_tp_x32_zext, *add_tp_x32_zext, > *tls_dynamic_gnu2_combine_32): Fix empty split condition. > * config/i386/sse.md (*_pmovmskb_lt, > *_pmovmskb_zext_lt, *sse2_pmovmskb_ext_lt, > *_pblendvb_lt): Likewise. OK. Thanks, Uros. > --- > gcc/config/i386/i386.md | 6 +++--- > gcc/config/i386/sse.md | 8 ++++---- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md > index 9ff35d9a607..545d048906d 100644 > --- a/gcc/config/i386/i386.md > +++ b/gcc/config/i386/i386.md > @@ -15712,7 +15712,7 @@ (define_insn_and_split "*load_tp_x32_zext" > (unspec:SI [(const_int 0)] UNSPEC_TP)))] > "TARGET_X32" > "#" > - "" > + "&& 1" > [(set (match_dup 0) > (zero_extend:DI (match_dup 1)))] > { > @@ -15750,7 +15750,7 @@ (define_insn_and_split "*add_tp_x32_zext" > (clobber (reg:CC FLAGS_REG))] > "TARGET_X32" > "#" > - "" > + "&& 1" > [(parallel > [(set (match_dup 0) > (zero_extend:DI > @@ -15841,7 +15841,7 @@ (define_insn_and_split "*tls_dynamic_gnu2_combine_32" > (clobber (reg:CC FLAGS_REG))] > "!TARGET_64BIT && TARGET_GNU2_TLS" > "#" > - "" > + "&& 1" > [(set (match_dup 0) (match_dup 5))] > { > operands[5] = can_create_pseudo_p () ? gen_reg_rtx (Pmode) : operands[0]; > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md > index 9d3728d1cb0..a9d78030119 100644 > --- a/gcc/config/i386/sse.md > +++ b/gcc/config/i386/sse.md > @@ -16467,7 +16467,7 @@ (define_insn_and_split "*_pmovmskb_lt" > UNSPEC_MOVMSK))] > "TARGET_SSE2" > "#" > - "" > + "&& 1" > [(set (match_dup 0) > (unspec:SI [(match_dup 1)] UNSPEC_MOVMSK))] > "" > @@ -16489,7 +16489,7 @@ (define_insn_and_split "*_pmovmskb_zext_lt" > UNSPEC_MOVMSK)))] > "TARGET_64BIT && TARGET_SSE2" > "#" > - "" > + "&& 1" > [(set (match_dup 0) > (zero_extend:DI (unspec:SI [(match_dup 1)] UNSPEC_MOVMSK)))] > "" > @@ -16511,7 +16511,7 @@ (define_insn_and_split "*sse2_pmovmskb_ext_lt" > UNSPEC_MOVMSK)))] > "TARGET_64BIT && TARGET_SSE2" > "#" > - "" > + "&& 1" > [(set (match_dup 0) > (sign_extend:DI (unspec:SI [(match_dup 1)] UNSPEC_MOVMSK)))] > "" > @@ -17769,7 +17769,7 @@ (define_insn_and_split "*_pblendvb_lt" > UNSPEC_BLENDV))] > "TARGET_SSE4_1" > "#" > - "" > + "&& 1" > [(set (match_dup 0) > (unspec:VI1_AVX2 > [(match_dup 1) (match_dup 2) (match_dup 3)] UNSPEC_BLENDV))] > -- > 2.17.1 >