* [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17
@ 2018-08-06 15:10 Uros Bizjak
2018-08-06 15:23 ` Jeff Law
0 siblings, 1 reply; 7+ messages in thread
From: Uros Bizjak @ 2018-08-06 15:10 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
2018-08-06 Uros Bizjak <ubizjak@gmail.com>
* g++.dg/torture/pr86763.C (dg-additional-options): Add -lrt.
Tested on CentOS 5.10 and Fedora 28.
OK for mainline?
Uros.
[-- Attachment #2: t.diff.txt --]
[-- Type: text/plain, Size: 408 bytes --]
Index: g++.dg/torture/pr86763.C
===================================================================
--- g++.dg/torture/pr86763.C (revision 263317)
+++ g++.dg/torture/pr86763.C (working copy)
@@ -1,5 +1,5 @@
// { dg-do run }
-// { dg-additional-options "-fschedule-insns2 -fstrict-aliasing" }
+// { dg-additional-options "-fschedule-insns2 -fstrict-aliasing -lrt" }
#include <cstdint>
#include <cassert>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17
2018-08-06 15:10 [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17 Uros Bizjak
@ 2018-08-06 15:23 ` Jeff Law
2018-08-06 15:33 ` Uros Bizjak
0 siblings, 1 reply; 7+ messages in thread
From: Jeff Law @ 2018-08-06 15:23 UTC (permalink / raw)
To: Uros Bizjak, gcc-patches
On 08/06/2018 09:10 AM, Uros Bizjak wrote:
> 2018-08-06 Uros Bizjak <ubizjak@gmail.com>
>
> * g++.dg/torture/pr86763.C (dg-additional-options): Add -lrt.
>
> Tested on CentOS 5.10 and Fedora 28.
>
> OK for mainline?
But what about systems without librt? I'm thinking primarily of the
embedded *-elf targets.
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17
2018-08-06 15:23 ` Jeff Law
@ 2018-08-06 15:33 ` Uros Bizjak
2018-08-06 15:44 ` Jeff Law
2018-08-06 15:54 ` Andreas Schwab
0 siblings, 2 replies; 7+ messages in thread
From: Uros Bizjak @ 2018-08-06 15:33 UTC (permalink / raw)
To: Jeff Law; +Cc: gcc-patches
On Mon, Aug 6, 2018 at 5:23 PM, Jeff Law <law@redhat.com> wrote:
> On 08/06/2018 09:10 AM, Uros Bizjak wrote:
>> 2018-08-06 Uros Bizjak <ubizjak@gmail.com>
>>
>> * g++.dg/torture/pr86763.C (dg-additional-options): Add -lrt.
>>
>> Tested on CentOS 5.10 and Fedora 28.
>>
>> OK for mainline?
> But what about systems without librt? I'm thinking primarily of the
> embedded *-elf targets.
Perhaps the following patch is better:
--cut here--
Index: g++.dg/torture/pr86763.C
===================================================================
--- g++.dg/torture/pr86763.C (revision 263317)
+++ g++.dg/torture/pr86763.C (working copy)
@@ -1,5 +1,6 @@
// { dg-do run }
// { dg-additional-options "-fschedule-insns2 -fstrict-aliasing" }
+// { dg-additional-options "-lrt" { target *-*-linux-gnu } }
#include <cstdint>
#include <cassert>
--cut here--
Uros.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17
2018-08-06 15:33 ` Uros Bizjak
@ 2018-08-06 15:44 ` Jeff Law
2018-08-06 15:46 ` Uros Bizjak
2018-08-06 15:54 ` Andreas Schwab
1 sibling, 1 reply; 7+ messages in thread
From: Jeff Law @ 2018-08-06 15:44 UTC (permalink / raw)
To: Uros Bizjak; +Cc: gcc-patches
On 08/06/2018 09:33 AM, Uros Bizjak wrote:
> On Mon, Aug 6, 2018 at 5:23 PM, Jeff Law <law@redhat.com> wrote:
>> On 08/06/2018 09:10 AM, Uros Bizjak wrote:
>>> 2018-08-06 Uros Bizjak <ubizjak@gmail.com>
>>>
>>> * g++.dg/torture/pr86763.C (dg-additional-options): Add -lrt.
>>>
>>> Tested on CentOS 5.10 and Fedora 28.
>>>
>>> OK for mainline?
>> But what about systems without librt? I'm thinking primarily of the
>> embedded *-elf targets.
>
> Perhaps the following patch is better:
>
> --cut here--
> Index: g++.dg/torture/pr86763.C
> ===================================================================
> --- g++.dg/torture/pr86763.C (revision 263317)
> +++ g++.dg/torture/pr86763.C (working copy)
> @@ -1,5 +1,6 @@
> // { dg-do run }
> // { dg-additional-options "-fschedule-insns2 -fstrict-aliasing" }
> +// { dg-additional-options "-lrt" { target *-*-linux-gnu } }
That's be fine with me.
If someone wants the test to be run on solaris or some other target with
librt, they can extend the selector to include the proper target/versions.
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17
2018-08-06 15:44 ` Jeff Law
@ 2018-08-06 15:46 ` Uros Bizjak
0 siblings, 0 replies; 7+ messages in thread
From: Uros Bizjak @ 2018-08-06 15:46 UTC (permalink / raw)
To: Jeff Law; +Cc: gcc-patches
On Mon, Aug 6, 2018 at 5:44 PM, Jeff Law <law@redhat.com> wrote:
> On 08/06/2018 09:33 AM, Uros Bizjak wrote:
>> On Mon, Aug 6, 2018 at 5:23 PM, Jeff Law <law@redhat.com> wrote:
>>> On 08/06/2018 09:10 AM, Uros Bizjak wrote:
>>>> 2018-08-06 Uros Bizjak <ubizjak@gmail.com>
>>>>
>>>> * g++.dg/torture/pr86763.C (dg-additional-options): Add -lrt.
>>>>
>>>> Tested on CentOS 5.10 and Fedora 28.
>>>>
>>>> OK for mainline?
>>> But what about systems without librt? I'm thinking primarily of the
>>> embedded *-elf targets.
>>
>> Perhaps the following patch is better:
>>
>> --cut here--
>> Index: g++.dg/torture/pr86763.C
>> ===================================================================
>> --- g++.dg/torture/pr86763.C (revision 263317)
>> +++ g++.dg/torture/pr86763.C (working copy)
>> @@ -1,5 +1,6 @@
>> // { dg-do run }
>> // { dg-additional-options "-fschedule-insns2 -fstrict-aliasing" }
>> +// { dg-additional-options "-lrt" { target *-*-linux-gnu } }
> That's be fine with me.
>
> If someone wants the test to be run on solaris or some other target with
> librt, they can extend the selector to include the proper target/versions.
Thanks, I'll commit the patch to mainline with updated ChangeLog entry:
2018-08-06 Uros Bizjak <ubizjak@gmail.com>
* g++.dg/torture/pr86763.C (dg-additional-options): Add -lrt
for target *-*-linux-gnu.
Uros.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17
2018-08-06 15:33 ` Uros Bizjak
2018-08-06 15:44 ` Jeff Law
@ 2018-08-06 15:54 ` Andreas Schwab
2018-08-07 19:55 ` Rainer Orth
1 sibling, 1 reply; 7+ messages in thread
From: Andreas Schwab @ 2018-08-06 15:54 UTC (permalink / raw)
To: Uros Bizjak; +Cc: Jeff Law, gcc-patches
How about replacing clock_gettime with something else? It's not needed
for the particular test.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17
2018-08-06 15:54 ` Andreas Schwab
@ 2018-08-07 19:55 ` Rainer Orth
0 siblings, 0 replies; 7+ messages in thread
From: Rainer Orth @ 2018-08-07 19:55 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Uros Bizjak, Jeff Law, gcc-patches
Hi Andreas,
> How about replacing clock_gettime with something else? It's not needed
> for the particular test.
that would certainly be useful: Solaris 10 also needs librt or
clock_gettime, while Solaris 11 has folded it into libc.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-08-07 19:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-06 15:10 [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17 Uros Bizjak
2018-08-06 15:23 ` Jeff Law
2018-08-06 15:33 ` Uros Bizjak
2018-08-06 15:44 ` Jeff Law
2018-08-06 15:46 ` Uros Bizjak
2018-08-06 15:54 ` Andreas Schwab
2018-08-07 19:55 ` Rainer Orth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).