From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30504 invoked by alias); 22 Nov 2014 19:03:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30488 invoked by uid 89); 22 Nov 2014 19:03:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f169.google.com Received: from mail-lb0-f169.google.com (HELO mail-lb0-f169.google.com) (209.85.217.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 22 Nov 2014 19:03:27 +0000 Received: by mail-lb0-f169.google.com with SMTP id p9so4715775lbv.28 for ; Sat, 22 Nov 2014 11:03:23 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.112.162.41 with SMTP id xx9mr11730422lbb.21.1416683003887; Sat, 22 Nov 2014 11:03:23 -0800 (PST) Received: by 10.152.127.168 with HTTP; Sat, 22 Nov 2014 11:03:23 -0800 (PST) In-Reply-To: <507E7F44-3CB4-49FA-A715-DAF513DCDF0D@gmail.com> References: <32201320.a2T5pL3L4j@polaris> <1871210.X8Ouu1Z02f@polaris> <507E7F44-3CB4-49FA-A715-DAF513DCDF0D@gmail.com> Date: Sat, 22 Nov 2014 22:38:00 -0000 Message-ID: Subject: Re: [PATCH x86] Increase PARAM_MAX_COMPLETELY_PEELED_INSNS when branch is costly From: Uros Bizjak To: Richard Biener Cc: Eric Botcazou , "gcc-patches@gcc.gnu.org" , Evgeny Stupachenko , Jan Hubicka Content-Type: multipart/mixed; boundary=089e0116062234dcec05087737e4 X-SW-Source: 2014-11/txt/msg02915.txt.bz2 --089e0116062234dcec05087737e4 Content-Type: text/plain; charset=UTF-8 Content-length: 904 On Sat, Nov 22, 2014 at 7:38 PM, Richard Biener wrote: > On November 22, 2014 12:24:22 PM CET, Eric Botcazou wrote: >>> Yeah, but after a couple of pings for a generic change, we went the >>target >>> way. >> >>That's a bit of a shame, the 400 -> 100 change was very likely tested >>only on >>x86-64 and nevetheless applied to the generic code, so the fix >>repairing the >>damages should also be applied to the generic code. > > A patch to bump the generic limit is OK. > > Targets that dont want it can reduce it in target specific code. I have committed the attached patch: 2014-11-22 Uros Bizjak * params.def (PARAM_MAX_COMPLETELY_PEELED_INSNS): Increase to 200. * config/i386/i386.c (ix86_option_override_internal): Do not increase PARAM_MAX_COMPLETELY_PEELED_INSNS. Bootstrapped on x86_64-linux-gnu. Uros. --089e0116062234dcec05087737e4 Content-Type: text/plain; charset=US-ASCII; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i2tch0xe0 Content-length: 1582 SW5kZXg6IHBhcmFtcy5kZWYKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g cGFyYW1zLmRlZgkocmV2aXNpb24gMjE3OTYxKQorKysgcGFyYW1zLmRlZgko d29ya2luZyBjb3B5KQpAQCAtMzAzLDcgKzMwMyw3IEBAIERFRlBBUkFNKFBB UkFNX01BWF9QRUVMX0JSQU5DSEVTLAogREVGUEFSQU0oUEFSQU1fTUFYX0NP TVBMRVRFTFlfUEVFTEVEX0lOU05TLAogCSJtYXgtY29tcGxldGVseS1wZWVs ZWQtaW5zbnMiLAogCSJUaGUgbWF4aW11bSBudW1iZXIgb2YgaW5zbnMgb2Yg YSBjb21wbGV0ZWx5IHBlZWxlZCBsb29wIiwKLQkxMDAsIDAsIDApCisJMjAw LCAwLCAwKQogLyogVGhlIG1heGltdW0gbnVtYmVyIG9mIHBlZWxpbmdzIG9m IGEgc2luZ2xlIGxvb3AgdGhhdCBpcyBwZWVsZWQgY29tcGxldGVseS4gICov CiBERUZQQVJBTShQQVJBTV9NQVhfQ09NUExFVEVMWV9QRUVMX1RJTUVTLAog CSJtYXgtY29tcGxldGVseS1wZWVsLXRpbWVzIiwKSW5kZXg6IGNvbmZpZy9p Mzg2L2kzODYuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjb25maWcv aTM4Ni9pMzg2LmMJKHJldmlzaW9uIDIxNzk2MSkKKysrIGNvbmZpZy9pMzg2 L2kzODYuYwkod29ya2luZyBjb3B5KQpAQCAtNDE0MiwxMiArNDE0Miw2IEBA IGl4ODZfb3B0aW9uX292ZXJyaWRlX2ludGVybmFsIChib29sIG1haW5fYXJn c19wLAogCQkJIG9wdHMtPnhfcGFyYW1fdmFsdWVzLAogCQkJIG9wdHNfc2V0 LT54X3BhcmFtX3ZhbHVlcyk7CiAKLSAgLyogSW5jcmVhc2UgZnVsbCBwZWVs IG1heCBpbnNucyBwYXJhbWV0ZXIgZm9yIHg4Ni4gICovCi0gIG1heWJlX3Nl dF9wYXJhbV92YWx1ZSAoUEFSQU1fTUFYX0NPTVBMRVRFTFlfUEVFTEVEX0lO U05TLAotCQkJIDIwMCwKLQkJCSBvcHRzLT54X3BhcmFtX3ZhbHVlcywKLQkJ CSBvcHRzX3NldC0+eF9wYXJhbV92YWx1ZXMpOwotCiAgIC8qIEVuYWJsZSBz dyBwcmVmZXRjaGluZyBhdCAtTzMgZm9yIENQVVMgdGhhdCBwcmVmZXRjaGlu ZyBpcyBoZWxwZnVsLiAgKi8KICAgaWYgKG9wdHMtPnhfZmxhZ19wcmVmZXRj aF9sb29wX2FycmF5cyA8IDAKICAgICAgICYmIEhBVkVfcHJlZmV0Y2gK --089e0116062234dcec05087737e4--