From: Uros Bizjak <ubizjak@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Vladimir Makarov <vmakarov@redhat.com>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: patch to fix PR82353
Date: Thu, 12 Oct 2017 11:38:00 -0000 [thread overview]
Message-ID: <CAFULd4bMngLTxz2re=-Ekfkrg0dAVgSYq1zoPO2181Azj96yWQ@mail.gmail.com> (raw)
Hello!
> The following patch fixes
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82353
>
> LRA did not update hard reg liveness on bb borders for hard regs which are part of insn patterns
> like CFLAGS reg. It was ok for inheritance in EBB which creates only moves and they usually
> have no embedded hard regs in the patterns. But LRA rematerialization needs this. So this patch
> implements such hard reg liveness updates.
>
> The patch was successfully bootstrapped and tested on x86-64.
>
> Committed as rev. 253656.
It looks that this patch caused libgo build bootstrap failure on
x86_64-linux-gnu:
../../../git/gcc/libgo/go/cmd/go/internal/load/pkg.go:377:1: error:
this is the insn:
(insn 1134 2835 2611 195 (parallel [
(set (reg:DI 492)
(const_int 0 [0]))
(set (reg/f:DI 1008 [orig:490 <retval> ] [490])
(plus:DI (ashift:DI (reg:DI 492)
(const_int 3 [0x3]))
(reg/f:DI 1008 [orig:490 <retval> ] [490])))
(set (reg/f:DI 1009 [880])
(plus:DI (ashift:DI (reg:DI 492)
(const_int 3 [0x3]))
(reg/f:DI 1009 [880])))
(set (mem:BLK (reg/f:DI 1008 [orig:490 <retval> ] [490])
[22 *_372+0 S1048 A64])
(mem/c:BLK (reg/f:DI 1009 [880]) [22 GOTMP.492+0 S1048 A128]))
(use (reg:DI 492))
]) "../../../git/gcc/libgo/go/cmd/go/internal/load/pkg.go":679
930 {*rep_movdi_rex64}
(expr_list:REG_UNUSED (reg/f:DI 1009 [880])
(expr_list:REG_UNUSED (reg/f:DI 1008 [orig:490 <retval> ] [490])
(expr_list:REG_UNUSED (reg:DI 492)
(expr_list:REG_EH_REGION (const_int 1 [0x1])
(nil))))))
during RTL pass: reload
../../../git/gcc/libgo/go/cmd/go/internal/load/pkg.go:377:1: internal
compiler error: in assign_by_spills, at lra-assigns.c:1468
0x6b2709 _fatal_insn(char const*, rtx_def const*, char const*, int, char const*)
../../git/gcc/gcc/rtl-error.c:108
0xbe87fa assign_by_spills
../../git/gcc/gcc/lra-assigns.c:1468
0xbe94a6 lra_assign()
../../git/gcc/gcc/lra-assigns.c:1662
0xbe48d4 lra(_IO_FILE*)
../../git/gcc/gcc/lra.c:2450
0xb9ec51 do_reload
../../git/gcc/gcc/ira.c:5440
0xb9ec51 execute
../../git/gcc/gcc/ira.c:5624
Please submit a full bug report,
Uros.
next reply other threads:[~2017-10-12 11:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 11:38 Uros Bizjak [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-16 20:39 Vladimir Makarov
2017-12-13 12:35 ` Tom de Vries
2017-12-14 17:01 ` Vladimir Makarov
2017-10-11 19:51 Vladimir Makarov
2017-10-11 21:17 ` Jakub Jelinek
2017-10-11 22:54 ` Vladimir Makarov
2017-10-12 17:05 ` Jakub Jelinek
2017-10-12 17:11 ` Vladimir Makarov
2017-10-12 17:34 ` Jakub Jelinek
2017-10-13 18:49 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4bMngLTxz2re=-Ekfkrg0dAVgSYq1zoPO2181Azj96yWQ@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).