From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83410 invoked by alias); 14 Feb 2020 11:16:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 82464 invoked by uid 89); 14 Feb 2020 11:16:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*RU:209.85.166.66, HX-Spam-Relays-External:209.85.166.66, H*r:ip*209.85.166.66 X-HELO: mail-io1-f66.google.com Received: from mail-io1-f66.google.com (HELO mail-io1-f66.google.com) (209.85.166.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Feb 2020 11:16:33 +0000 Received: by mail-io1-f66.google.com with SMTP id x1so10115892iop.7 for ; Fri, 14 Feb 2020 03:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P1N0twqiUgPuqXtk5Izsvdv5NPzEd0nCF+VE6Rz5rKA=; b=NAXERvcmXexYkqnnvCXSBg64jvopdAbMa1LsclLkTF4wXHMwvsbV9QY82XXQnHbR2P txN1Xrp8ymeS/xAL3qXAsCyKjklQPi7+wBnte6dUgdjtSmcr2W1YYNuC9yKIUIFXnbsO w51EyCjv9x6aSSpXgueHVxxcGPut3acVg8HmvJMI23Ur5Ln3QM9cZUgsWJ/lvvQXMDEc e8Bfh6S9xXtiKMaGKkhbR35DQkXmn2FV7oMUYcBx3HfflEMO8brsIjL1uf27O7k3afVQ qvPB/R/1XYp8Iv5LTyH5U5Og9NC/js0W5C6b+rb1kdImI198mkVp1uGKxV+90dqL7q7u YK/w== MIME-Version: 1.0 References: <20200213085329.GG17695@tucnak> In-Reply-To: From: Uros Bizjak Date: Fri, 14 Feb 2020 11:16:00 -0000 Message-ID: Subject: Re: [PATCH]Several intrinsic macros lack a closing parenthesis[PR93274] To: Hongtao Liu Cc: Jakub Jelinek , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2020-02/txt/msg00849.txt.bz2 On Fri, Feb 14, 2020 at 8:06 AM Uros Bizjak wrote: > > On Fri, Feb 14, 2020 at 7:03 AM Hongtao Liu wrote: > > > > On Thu, Feb 13, 2020 at 5:31 PM Hongtao Liu wrote: > > > > > > On Thu, Feb 13, 2020 at 5:12 PM Uros Bizjak wrote: > > > > > > > > On Thu, Feb 13, 2020 at 9:53 AM Jakub Jelinek wrote: > > > > > > > > > > On Thu, Feb 13, 2020 at 09:39:05AM +0100, Uros Bizjak wrote: > > > > > > > Changelog > > > > > > > gcc/ > > > > > > > * config/i386/avx512vbmi2intrin.h > > > > > > > (_mm512_[,mask_,maskz_]shrdi_epi16, > > > > > > > _mm512_[,mask_,maskz_]shrdi_epi32, > > > > > > > _m512_[,mask_,maskz_]shrdi_epi64, > > > > > > > _mm512_[,mask_,maskz_]shldi_epi16, > > > > > > > _mm512_[,mask_,maskz_]shldi_epi32, > > > > > > > _m512_[,mask_,maskz_]shldi_epi64): Fix typo of lacking a > > > > > > > closing parenthesis. > > > > > > > * config/i386/avx512vbmi2vlintrin.h > > > > > > > (_mm256_[,mask_,maskz_]shrdi_epi16, > > > > > > > _mm256_[,mask_,maskz_]shrdi_epi32, > > > > > > > _m256_[,mask_,maskz_]shrdi_epi64, > > > > > > > _mm_[,mask_,maskz_]shrdi_epi16, > > > > > > > _mm_[,mask_,maskz_]shrdi_epi32, > > > > > > > _mm_[,mask_,maskz_]shrdi_epi64, > > > > > > > _mm256_[,mask_,maskz_]shldi_epi16, > > > > > > > _mm256_[,mask_,maskz_]shldi_epi32, > > > > > > > _m256_[,mask_,maskz_]shldi_epi64, > > > > > > > _mm_[,mask_,maskz_]shldi_epi16, > > > > > > > _mm_[,mask_,maskz_]shldi_epi32, > > > > > > > _mm_[,mask_,maskz_]shldi_epi64): Ditto. > > > > > > > > > > > > > > gcc/testsuite/ > > > > > > > * gcc.target/i386/avx512vbmi2-vpshld-1.c: New test. > > > > > > > * gcc.target/i386/avx512vbmi2-vpshld-O0-1.c: Ditto. > > > > > > > * gcc.target/i386/avx512vbmi2-vpshrd-1.c: Ditto. > > > > > > > * gcc.target/i386/avx512vbmi2-vpshrd-O0-1.c: Ditto. > > > > > > > * gcc.target/i386/avx512vl-vpshld-O0-1.c: Ditto. > > > > > > > * gcc.target/i386/avx512vl-vpshrd-O0-1.c: Ditto. > > > > > > > > > > > > This is obvious patch, so OK for mainline and backports. > > > > > > > > > > The header changes sure, but for the testsuite, the standard way > > > > > would be to have it covered in the standard tests we have for this. > > > > > I think that is gcc.target/i386/sse-{13,14,22a,23}.c, so it would be worth > > > > > trying to figure out why it hasn't caught that. > > > > > > > > Indeed. It looks that these macros are not listed in sse-14.c, which > > > > would catch the problem. So, there is no need for new -O0 tests, > > > > please add missing functions to sse-14.c and sse-22.c testcases. I was > > > > also surprised that no testsuite coverage for vbmi2 functions was > > > > added at submission. > > > > > > > Yes, i saw that, thanks. > > > > Uros. > > > > > > > > > And, I don't think we allow any wildcards etc. (and [,whatever,whateverelse] > > > > > isn't even one, neither regexp nor shell wildcard) in the names of functions > > > > > changed, they can appear in the description text, but for the names of > > > > > macros one needs to list them all expanded, people do grep for those. > > > > > > > > > > Jakub > > > > > > > > > > > > > > > > > -- > > > BR, > > > Hongtao > > > > Update patch: > > Update Changelog, delete O0 testcase, and add testcase in sse-14.c, sse-22.c > > OK. Please also commit ChangeLog entries to relevant ChangeLog files. Uros.