From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com
 [IPv6:2607:f8b0:4864:20::741])
 by sourceware.org (Postfix) with ESMTPS id 1CA2E3857C42
 for <gcc-patches@gcc.gnu.org>; Fri, 14 Aug 2020 09:57:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1CA2E3857C42
Received: by mail-qk1-x741.google.com with SMTP id 62so7812137qkj.7
 for <gcc-patches@gcc.gnu.org>; Fri, 14 Aug 2020 02:57:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=eb7Q3bNl/D6U7Qf/yij8sR6sF28EY9XPHy5UDkP9630=;
 b=hJJk5UnyGFdyb4oS845yh9Ud80ZeRVk84+GC177n28OO9oJFHJPdTOSRXpypGMi0ud
 FJFiTT9ZXUi2aOZOYPorjRbgagzzqP+YdYcArBG6nVY106SI4eTOGx9rEaKqNPNkQhre
 mfiKFz0BdFWyHxEUUiu5A+j+1qx6zXvGBrOnFqzc0CkSqOAm8wDEw7qAHcUeOoisUo8t
 koH3PRcmZ5kyKbeQGKYb6PwTEnkYgL6vBJxcxcg3E0AIhcbwYcgAGEn6I0/RsdLZDcxu
 6Bg52Pe9oqHEF4GBi+7tqmguGer1v+5qGTx6eNS/8/u4uxtLqkonrqBO6aznIWwDXomP
 bZoA==
X-Gm-Message-State: AOAM532NWtuefL/vq4BN96LJqaP8UMf064ERB8c9SxR5hBiXwJltxl0S
 V49BiC+0FBe9FWoOsq3xl9K7NVCBMiPc2nlXSGI=
X-Google-Smtp-Source: ABdhPJw4UTXAeJDOfvE+N4+xFAH4f/5C7KvHIPZX+AbDLCqNCFFUsO6zf9fXRaL6F5lHObrz1ox1jcFJ8jOZppagqbM=
X-Received: by 2002:a05:620a:21d1:: with SMTP id
 h17mr1217685qka.292.1597399049651; 
 Fri, 14 Aug 2020 02:57:29 -0700 (PDT)
MIME-Version: 1.0
References: <CAMZc-bwNfCzuhFSDFOjmFsSyX1+bPtFA5gcZq55wy4tKw==mWQ@mail.gmail.com>
In-Reply-To: <CAMZc-bwNfCzuhFSDFOjmFsSyX1+bPtFA5gcZq55wy4tKw==mWQ@mail.gmail.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Fri, 14 Aug 2020 11:57:18 +0200
Message-ID: <CAFULd4bPLk+J4O=JTWHkGANV2W6c929HbKg6ihoReNUeoFpy6g@mail.gmail.com>
Subject: Re: [PATCH]Don't use pinsr for struct initialization.
To: Hongtao Liu <crazylht@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Aug 2020 09:57:31 -0000

On Fri, Aug 14, 2020 at 8:03 AM Hongtao Liu <crazylht@gmail.com> wrote:
>
> Hi:
>   For struct initialization, when it fits in a TImode, gcc will use
> pinsr insn which causes poor codegen described in PR93897 and PR96562.

You should probably remove TImode handling also from ix86_expand_pextr.

Uros.

>   Bootstrap is ok, regression test is ok for i386/x86-64 backend.
>   Ok for trunk?
>
> ChangeLog
> gcc/
>         PR target/96562
>         PR target/93897
>         * config/i386/i386-expand.c (ix86_expand_pinsr): Don't use
>         pinsr for TImode.
>
> gcc/testsuite/
>         * gcc.target/i386/pr96562-1.c: New test.
>
> --
> BR,
> Hongtao