From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3593 invoked by alias); 19 Nov 2012 07:55:58 -0000 Received: (qmail 3580 invoked by uid 22791); 19 Nov 2012 07:55:57 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pb0-f47.google.com (HELO mail-pb0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Nov 2012 07:55:53 +0000 Received: by mail-pb0-f47.google.com with SMTP id un1so1720704pbc.20 for ; Sun, 18 Nov 2012 23:55:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.189.163 with SMTP id gj3mr36888027pbc.110.1353311752628; Sun, 18 Nov 2012 23:55:52 -0800 (PST) Received: by 10.66.246.232 with HTTP; Sun, 18 Nov 2012 23:55:52 -0800 (PST) In-Reply-To: <50A98F1E.4000002@redhat.com> References: <50A98F1E.4000002@redhat.com> Date: Mon, 19 Nov 2012 07:55:00 -0000 Message-ID: Subject: Re: RFA: patch to fix PR19398 From: Uros Bizjak To: Vladimir Makarov Cc: GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg01535.txt.bz2 On Mon, Nov 19, 2012 at 2:45 AM, Vladimir Makarov wrote: > The following patch fixes > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19398 > > Uros, there is i386.md part for which I need an approval. Without this > change, GCC will still generate the same code even if LRA uses an > alternative with 'm' constraint. > > 2012-11-18 Vladimir Makarov > > PR target/19398 > * lra-constraints.c (process_alt_operands): Discourage reloads > through secodnary memory. > * config/i386/i386.md (fix_trunc?f?i_sse): Remove peephole2 > patterns. Thanks! Please note that i386.md change is not correct, it is peephole2 with "Shorten x87->SSE reload sequences ..." comment that is not effective anymore with your patch and should now be removed. The peephole2s that your patch removes undo LRA transformation for targets that *do not* benefit from MEM->REG operation for this particular FIX RTX. (Also, please note that your patch includes movti_internal_rex64 change that was already reverted due to better fix). Please remove mentioned peephole2 instead. The test from the PR will show effects of LRA change for all targets, other than core2i7_64, k8 and generic 64bit targets. The patch that removes mentioned peephole2 from i386.md is pre-approved. Thanks, Uros. >