From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id BAD273858C2D for ; Fri, 12 May 2023 17:05:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BAD273858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-75764d20db3so646946085a.2 for ; Fri, 12 May 2023 10:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683911118; x=1686503118; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ptpng0WXMG1RQzQeQkOjBuz146d6z4Rx26IhaTqHYLg=; b=MnjMotVOdOxq+0W/ZHqlaZ3Bi1c3E1sKUlAsH/L9WTh4MdgQKfE5xX66Jf3BhnePUJ j+UZg0AsYoNJvCPbgkiDibGPU3hVcNIasLhkwXKC2QSo3RPDdftckaMEc+nksOh58oQB MDa0jRTGYxKnRofkHiNfpuXf0cXVNqgxy7Z1583vCynMAj7MswzrIJyI2AwGhi6pX7oK aG9Rx7mQF6nEf6qaKMr560YrisW8gJUGxAecd1WQSQ+YGvfL+qmAzASmf237NAwzzeV1 yRhG9FiISPS7KgwnLP9xX0wx8ld/GuYAYlV4UIkD4sG2wcCwy3a46OBRTR3MoCYNpDXx knyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683911118; x=1686503118; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ptpng0WXMG1RQzQeQkOjBuz146d6z4Rx26IhaTqHYLg=; b=NasETyQFbqOiT16rz848afo9Oekk/P/vGA7M2Mw7f3btTlm3ADtDrBsPiMptKriYd8 pmVAiAnpkhyoLc8fDIHOUjyiN1T5KZLbS+kZazKs9KJxnI89wzZfJX1m0s7s8oBALNGL Cl4Bjeakq162yCADi8Xh6QnNrDHQ0oV6BNcGBBx+qGpE9BBq8u5CybLxVWCBc9JqWy/p 3zIOqhtKZ/3GOAeiR+mxOZ5bWwLoua9vSjMYNWCd9f1a8p4yH+0qWCcwr32+/pbULtwQ BogjvKjkxOqqpr27nPGYoSebY6d4WD41io/suSiZuZyTmIl3PtmuUY+q1YjsUqWHXEZt OpAQ== X-Gm-Message-State: AC+VfDxy2wCTXgqG/bpFiZY+faIBPusmBM6AdbxnVfBSRy8A9svfHg8c sbtR3QUpcpAzlWmc4n/MB60flLpEV9Wrnr/eGQA= X-Google-Smtp-Source: ACHHUZ7ozTVkkdIRtUHGA8GCBPif+AyTTkA9smjC/uha+Ox+NS8+H8xPEfCejVBrCP+nVmfIHwmEGJof/Ntlb89fbWs= X-Received: by 2002:ad4:5ba6:0:b0:5ef:8004:e0b0 with SMTP id 6-20020ad45ba6000000b005ef8004e0b0mr32234704qvq.17.1683911117962; Fri, 12 May 2023 10:05:17 -0700 (PDT) MIME-Version: 1.0 References: <20230509085835.1143661-1-ardb@kernel.org> In-Reply-To: From: Uros Bizjak Date: Fri, 12 May 2023 19:05:06 +0200 Message-ID: Subject: Re: [PATCH] i386: Honour -mdirect-extern-access when calling __fentry__ To: Ard Biesheuvel Cc: "H.J. Lu" , gcc-patches@gcc.gnu.org, keescook@chromium.org, Jakub Jelinek , Richard Biener , Hou Wenlong Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, May 12, 2023 at 4:07=E2=80=AFPM Ard Biesheuvel wr= ote: > > > > > Note that the GOT reference in question is in fact a data referen= ce: we > > > > > explicitly load the address of __fentry__ from the GOT, which amo= unts to > > > > > eager binding, rather than emitting a PLT call that could bind ea= gerly, > > > > > lazily or directly at link time. > > > > > > > > > > gcc/ChangeLog: > > > > > > > > > > * config/i386/i386.cc (x86_function_profiler): Take > > > > > ix86_direct_extern_access into account when generating = calls > > > > > to __fentry__() > > > > > > > > HJ, is the patch OK with you? > > > > > > LGTM. > > > > OK then. > > > > Thanks all. Is anything expected of me at this point? Do you have write access to the repository? If not I can commit the patch for you, but you should state this [1] in your patch submission. [1] https://gcc.gnu.org/contribute.html Uros.