On Mon, Aug 22, 2011 at 8:51 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:

> Attached fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50155
>
> ChangeLog entry:
> 2011-08-22  Kirill Yukhin  <kirill.yukhin@intel.com>
>
>        PR target/50155
>        * config/i386/sse.md (VI1248_AVX2): New.
>        (<plusminus_insn><mode>3): Update.
>        (*<plusminus_insn><mode>3): Likewise.
>        (<sse2_avx2>_andnot<mode>3): Likewise.
>        (avx2_pbroadcast<mode>): Likewise.
>
> testsuite/ChangeLog entry:
> 2011-08-22  Kirill Yukhin  <kirill.yukhin@intel.com>
>
>        PR target/50155
>        * gcc.target/i386/pr50155.c: New test.
>
> New test fails without fix, passed with it applied.
>
> Ok for trunk if bootstrap will success?

No.

- you are disabling andnotps for 256bit integer modes on !TARGET_AVX2 targets.
- avx2_pbroadcast change is a no-op.

I found two additional problems with the patch:
- order of evaluation of cond RTX in mode attribute calculation is
wrong for *andnot<mode>3 and *<any_logic:code><mode>3 instructions.
- shortmode mode attribute is not used (minor)

Attached (lightly tested) patch fixes all problems and adds additional
asserts into mentioned logic instructions.

Uros.