From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10233 invoked by alias); 22 Aug 2011 19:09:40 -0000 Received: (qmail 10224 invoked by uid 22791); 22 Aug 2011 19:09:38 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_AV X-Spam-Check-By: sourceware.org Received: from mail-pz0-f49.google.com (HELO mail-pz0-f49.google.com) (209.85.210.49) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Aug 2011 19:09:22 +0000 Received: by pzk6 with SMTP id 6so12207794pzk.8 for ; Mon, 22 Aug 2011 12:09:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.71.168 with SMTP id w8mr296196pbu.471.1314040161514; Mon, 22 Aug 2011 12:09:21 -0700 (PDT) Received: by 10.143.13.8 with HTTP; Mon, 22 Aug 2011 12:09:21 -0700 (PDT) In-Reply-To: References: Date: Mon, 22 Aug 2011 19:51:00 -0000 Message-ID: Subject: Re: [PATCH, test, i386] Fix for PR50155 From: Uros Bizjak To: Kirill Yukhin Cc: gcc-patches List , Jakub Jelinek , "H.J. Lu" Content-Type: multipart/mixed; boundary=bcaec544eb780c353104ab1cd160 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg01822.txt.bz2 --bcaec544eb780c353104ab1cd160 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1300 On Mon, Aug 22, 2011 at 8:51 PM, Kirill Yukhin wr= ote: > Attached fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D50155 > > ChangeLog entry: > 2011-08-22 =A0Kirill Yukhin =A0 > > =A0 =A0 =A0 =A0PR target/50155 > =A0 =A0 =A0 =A0* config/i386/sse.md (VI1248_AVX2): New. > =A0 =A0 =A0 =A0(3): Update. > =A0 =A0 =A0 =A0(*3): Likewise. > =A0 =A0 =A0 =A0(_andnot3): Likewise. > =A0 =A0 =A0 =A0(avx2_pbroadcast): Likewise. > > testsuite/ChangeLog entry: > 2011-08-22 =A0Kirill Yukhin =A0 > > =A0 =A0 =A0 =A0PR target/50155 > =A0 =A0 =A0 =A0* gcc.target/i386/pr50155.c: New test. > > New test fails without fix, passed with it applied. > > Ok for trunk if bootstrap will success? No. - you are disabling andnotps for 256bit integer modes on !TARGET_AVX2 targe= ts. - avx2_pbroadcast change is a no-op. I found two additional problems with the patch: - order of evaluation of cond RTX in mode attribute calculation is wrong for *andnot3 and *3 instructions. - shortmode mode attribute is not used (minor) Attached (lightly tested) patch fixes all problems and adds additional asserts into mentioned logic instructions. Uros. --bcaec544eb780c353104ab1cd160 Content-Type: text/plain; charset=US-ASCII; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_grntk5tk1 Content-length: 6300 SW5kZXg6IHNzZS5tZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzc2Uu bWQJKHJldmlzaW9uIDE3Nzk2OCkKKysrIHNzZS5tZAkod29ya2luZyBjb3B5 KQpAQCAtNzMsNiArNzMsMTIgQEAKICAgIChWOFNJICJUQVJHRVRfQVZYIikg VjRTSQogICAgKFY0REkgIlRBUkdFVF9BVlgiKSBWMkRJXSkKIAorKGRlZmlu ZV9tb2RlX2l0ZXJhdG9yIFZJX0FWWDIKKyAgWyhWMzJRSSAiVEFSR0VUX0FW WDIiKSBWMTZRSQorICAgKFYxNkhJICJUQVJHRVRfQVZYMiIpIFY4SEkKKyAg IChWOFNJICJUQVJHRVRfQVZYMiIpIFY0U0kKKyAgIChWNERJICJUQVJHRVRf QVZYMiIpIFYyREldKQorCiA7OyBBbGwgUUltb2RlIHZlY3RvciBpbnRlZ2Vy IG1vZGVzCiAoZGVmaW5lX21vZGVfaXRlcmF0b3IgVkkxCiAgIFsoVjMyUUkg IlRBUkdFVF9BVlgiKSBWMTZRSV0pCkBAIC0xMjQsOCArMTMwLDggQEAKICAg W1Y0U0kgVjRESV0pCiAKIChkZWZpbmVfbW9kZV9pdGVyYXRvciBWNDhfQVZY MgotICBbKFY0U0YgIlRBUkdFVF9TU0UiKSAoVjJERiAiVEFSR0VUX1NTRTIi KQotICAgKFY4U0YgIlRBUkdFVF9BVlgiKSAoVjRERiAiVEFSR0VUX0FWWCIp CisgIFtWNFNGIFYyREYKKyAgIFY4U0YgVjRERgogICAgKFY0U0kgIlRBUkdF VF9BVlgyIikgKFYyREkgIlRBUkdFVF9BVlgyIikKICAgIChWOFNJICJUQVJH RVRfQVZYMiIpIChWNERJICJUQVJHRVRfQVZYMiIpXSkKIApAQCAtMTcwLDkg KzE3Niw2IEBACiAoZGVmaW5lX21vZGVfYXR0ciBzc2VieXRlbW9kZQogICBb KFY0REkgIlYzMlFJIikgKFYyREkgIlYxNlFJIildKQogCi0oZGVmaW5lX21v ZGVfYXR0ciBzaG9ydG1vZGUKLSAgWyhWNERJICJ2NHNpIikgKFYyREkgInYy c2kiKV0pCi0KIDs7IEFsbCAxMjhiaXQgdmVjdG9yIGludGVnZXIgbW9kZXMK IChkZWZpbmVfbW9kZV9pdGVyYXRvciBWSV8xMjggW1YxNlFJIFY4SEkgVjRT SSBWMkRJXSkKIApAQCAtNDY0MSwxOCArNDY0NCwxOCBAQAogICAib3BlcmFu ZHNbMl0gPSBmb3JjZV9yZWcgKDxNT0RFPm1vZGUsIENPTlNUMF9SVFggKDxN T0RFPm1vZGUpKTsiKQogCiAoZGVmaW5lX2V4cGFuZCAiPHBsdXNtaW51c19p bnNuPjxtb2RlPjMiCi0gIFsoc2V0IChtYXRjaF9vcGVyYW5kOlZJIDAgInJl Z2lzdGVyX29wZXJhbmQiICIiKQotCShwbHVzbWludXM6VkkKLQkgIChtYXRj aF9vcGVyYW5kOlZJIDEgIm5vbmltbWVkaWF0ZV9vcGVyYW5kIiAiIikKLQkg IChtYXRjaF9vcGVyYW5kOlZJIDIgIm5vbmltbWVkaWF0ZV9vcGVyYW5kIiAi IikpKV0KKyAgWyhzZXQgKG1hdGNoX29wZXJhbmQ6VklfQVZYMiAwICJyZWdp c3Rlcl9vcGVyYW5kIiAiIikKKwkocGx1c21pbnVzOlZJX0FWWDIKKwkgICht YXRjaF9vcGVyYW5kOlZJX0FWWDIgMSAibm9uaW1tZWRpYXRlX29wZXJhbmQi ICIiKQorCSAgKG1hdGNoX29wZXJhbmQ6VklfQVZYMiAyICJub25pbW1lZGlh dGVfb3BlcmFuZCIgIiIpKSldCiAgICJUQVJHRVRfU1NFMiIKICAgIml4ODZf Zml4dXBfYmluYXJ5X29wZXJhbmRzX25vX2NvcHkgKDxDT0RFPiwgPE1PREU+ bW9kZSwgb3BlcmFuZHMpOyIpCiAKIChkZWZpbmVfaW5zbiAiKjxwbHVzbWlu dXNfaW5zbj48bW9kZT4zIgotICBbKHNldCAobWF0Y2hfb3BlcmFuZDpWSSAw ICJyZWdpc3Rlcl9vcGVyYW5kIiAiPXgseCIpCi0JKHBsdXNtaW51czpWSQot CSAgKG1hdGNoX29wZXJhbmQ6VkkgMSAibm9uaW1tZWRpYXRlX29wZXJhbmQi ICI8Y29tbT4wLHgiKQotCSAgKG1hdGNoX29wZXJhbmQ6VkkgMiAibm9uaW1t ZWRpYXRlX29wZXJhbmQiICJ4bSx4bSIpKSldCisgIFsoc2V0IChtYXRjaF9v cGVyYW5kOlZJX0FWWDIgMCAicmVnaXN0ZXJfb3BlcmFuZCIgIj14LHgiKQor CShwbHVzbWludXM6VklfQVZYMgorCSAgKG1hdGNoX29wZXJhbmQ6VklfQVZY MiAxICJub25pbW1lZGlhdGVfb3BlcmFuZCIgIjxjb21tPjAseCIpCisJICAo bWF0Y2hfb3BlcmFuZDpWSV9BVlgyIDIgIm5vbmltbWVkaWF0ZV9vcGVyYW5k IiAieG0seG0iKSkpXQogICAiVEFSR0VUX1NTRTIgJiYgaXg4Nl9iaW5hcnlf b3BlcmF0b3Jfb2sgKDxDT0RFPiwgPE1PREU+bW9kZSwgb3BlcmFuZHMpIgog ICAiQAogICAgcDxwbHVzbWludXNfbW5lbW9uaWM+PHNzZW1vZGVzdWZmaXg+ XHR7JTIsICUwfCUwLCAlMn0KQEAgLTYxNzYsMTAgKzYxNzksMzAgQEAKIHsK ICAgc3RhdGljIGNoYXIgYnVmWzMyXTsKICAgY29uc3QgY2hhciAqb3BzOwot ICBjb25zdCBjaGFyICp0bXAKLSAgICA9ICgoZ2V0X2F0dHJfbW9kZSAoaW5z bikgPT0gTU9ERV9USSkgfHwKLSAgICAgICAoZ2V0X2F0dHJfbW9kZSAoaW5z bikgPT0gTU9ERV9PSSkpID8gInBhbmRuIiA6ICJhbmRucHMiOworICBjb25z dCBjaGFyICp0bXA7CiAKKyAgc3dpdGNoIChnZXRfYXR0cl9tb2RlIChpbnNu KSkKKyAgICB7CisgICAgY2FzZSBNT0RFX09JOgorICAgICAgZ2NjX2Fzc2Vy dCAoVEFSR0VUX0FWWDIpOworICAgIGNhc2UgTU9ERV9USToKKyAgICAgIGdj Y19hc3NlcnQgKFRBUkdFVF9TU0UyKTsKKworICAgICAgdG1wID0gInBhbmRu IjsKKyAgICAgIGJyZWFrOworCisgICBjYXNlIE1PREVfVjhTRjoKKyAgICAg IGdjY19hc3NlcnQgKFRBUkdFVF9BVlgpOworICAgY2FzZSBNT0RFX1Y0U0Y6 CisgICAgICBnY2NfYXNzZXJ0IChUQVJHRVRfU1NFKTsKKworICAgICAgdG1w ID0gImFuZG5wcyI7CisgICAgICBicmVhazsKKworICAgZGVmYXVsdDoKKyAg ICAgIGdjY191bnJlYWNoYWJsZSAoKTsKKyAgIH0KKwogICBzd2l0Y2ggKHdo aWNoX2FsdGVybmF0aXZlKQogICAgIHsKICAgICBjYXNlIDA6CkBAIC02MjA1 LDEyICs2MjI4LDEyIEBACiAgICAgICAgKGNvbnN0X3N0cmluZyAiKiIpKSkK ICAgIChzZXRfYXR0ciAicHJlZml4IiAib3JpZyx2ZXgiKQogICAgKHNldCAo YXR0ciAibW9kZSIpCi0gICAgIChjb25kIFsobmUgKHN5bWJvbF9yZWYgIkdF VF9NT0RFX1NJWkUgKDxNT0RFPm1vZGUpID4gMTI4IikgKGNvbnN0X2ludCAw KSkKKyAgICAgKGNvbmQgWyhuZSAoc3ltYm9sX3JlZiAiVEFSR0VUX0FWWDIi KSAoY29uc3RfaW50IDApKQorCSAgICAgIChjb25zdF9zdHJpbmcgIk9JIikK KwkgICAgKG5lIChzeW1ib2xfcmVmICJHRVRfTU9ERV9TSVpFICg8TU9ERT5t b2RlKSA+IDEyOCIpIChjb25zdF9pbnQgMCkpCiAJICAgICAgKGNvbnN0X3N0 cmluZyAiVjhTRiIpCiAJICAgIChuZSAoc3ltYm9sX3JlZiAiVEFSR0VUX1NT RTIiKSAoY29uc3RfaW50IDApKQogCSAgICAgIChjb25zdF9zdHJpbmcgIlRJ IikKLQkgICAgKG5lIChzeW1ib2xfcmVmICJUQVJHRVRfQVZYMiIpIChjb25z dF9pbnQgMCkpCi0JICAgICAgKGNvbnN0X3N0cmluZyAiT0kiKQogCSAgIF0K IAkgICAoY29uc3Rfc3RyaW5nICJWNFNGIikpKV0pCiAKQEAgLTYyMzIsMTAg KzYyNTUsMzAgQEAKIHsKICAgc3RhdGljIGNoYXIgYnVmWzMyXTsKICAgY29u c3QgY2hhciAqb3BzOwotICBjb25zdCBjaGFyICp0bXAKLSAgICA9IChnZXRf YXR0cl9tb2RlIChpbnNuKSA9PSBNT0RFX1RJKXx8Ci0gICAgICAoZ2V0X2F0 dHJfbW9kZSAoaW5zbikgPT0gTU9ERV9PSSkgPyAicDxsb2dpYz4iIDogIjxs b2dpYz5wcyI7CisgIGNvbnN0IGNoYXIgKnRtcDsKIAorICBzd2l0Y2ggKGdl dF9hdHRyX21vZGUgKGluc24pKQorICAgIHsKKyAgICBjYXNlIE1PREVfT0k6 CisgICAgICBnY2NfYXNzZXJ0IChUQVJHRVRfQVZYMik7CisgICAgY2FzZSBN T0RFX1RJOgorICAgICAgZ2NjX2Fzc2VydCAoVEFSR0VUX1NTRTIpOworCisg ICAgICB0bXAgPSAicDxsb2dpYz4iOworICAgICAgYnJlYWs7CisKKyAgIGNh c2UgTU9ERV9WOFNGOgorICAgICAgZ2NjX2Fzc2VydCAoVEFSR0VUX0FWWCk7 CisgICBjYXNlIE1PREVfVjRTRjoKKyAgICAgIGdjY19hc3NlcnQgKFRBUkdF VF9TU0UpOworCisgICAgICB0bXAgPSAiPGxvZ2ljPnBzIjsKKyAgICAgIGJy ZWFrOworCisgICBkZWZhdWx0OgorICAgICAgZ2NjX3VucmVhY2hhYmxlICgp OworICAgfQorCiAgIHN3aXRjaCAod2hpY2hfYWx0ZXJuYXRpdmUpCiAgICAg ewogICAgIGNhc2UgMDoKQEAgLTYyNjEsMTIgKzYzMDQsMTIgQEAKICAgICAg ICAoY29uc3Rfc3RyaW5nICIqIikpKQogICAgKHNldF9hdHRyICJwcmVmaXgi ICJvcmlnLHZleCIpCiAgICAoc2V0IChhdHRyICJtb2RlIikKLSAgICAgKGNv bmQgWyhuZSAoc3ltYm9sX3JlZiAiR0VUX01PREVfU0laRSAoPE1PREU+bW9k ZSkgPiAxMjgiKSAoY29uc3RfaW50IDApKQorICAgICAoY29uZCBbKG5lIChz eW1ib2xfcmVmICJUQVJHRVRfQVZYMiIpIChjb25zdF9pbnQgMCkpCisJICAg ICAgKGNvbnN0X3N0cmluZyAiT0kiKQorCSAgICAobmUgKHN5bWJvbF9yZWYg IkdFVF9NT0RFX1NJWkUgKDxNT0RFPm1vZGUpID4gMTI4IikgKGNvbnN0X2lu dCAwKSkKIAkgICAgICAoY29uc3Rfc3RyaW5nICJWOFNGIikKIAkgICAgKG5l IChzeW1ib2xfcmVmICJUQVJHRVRfU1NFMiIpIChjb25zdF9pbnQgMCkpCiAJ ICAgICAgKGNvbnN0X3N0cmluZyAiVEkiKQotCSAgICAobmUgKHN5bWJvbF9y ZWYgIlRBUkdFVF9BVlgyIikgKGNvbnN0X2ludCAwKSkKLQkgICAgICAoY29u c3Rfc3RyaW5nICJPSSIpCiAJICAgXQogCSAgIChjb25zdF9zdHJpbmcgIlY0 U0YiKSkpXSkKIAo= --bcaec544eb780c353104ab1cd160--