From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=tXWQ=CC=gmail.com=ubizjak@sourceware.org>
Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729])
	by sourceware.org (Postfix) with ESMTPS id 3DE723858C53
	for <gcc-patches@gcc.gnu.org>; Wed, 14 Jun 2023 15:01:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DE723858C53
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-75d4a4cf24aso212525885a.1
        for <gcc-patches@gcc.gnu.org>; Wed, 14 Jun 2023 08:01:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20221208; t=1686754897; x=1689346897;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=oCDuyYWhYFN/94I6e2LZpx79DVfDvXebaZmY8/b924c=;
        b=WIKVeY7PJRqaKNU1s4SVdr8ViqNT7dR1q0KM6tBmdG/JO0JquvlbX9FZdtuAmzRRp2
         096dBuPs6/OiobimJtnXWPK5UQ4wwuhvuRZArAhJIelvRRRCAv3floLKhy4u0YSjtNaI
         gri8FB7svkDU2gPUD7OInOBjnuoGNC2MzGYNkXIbbzdgZZn7wfDxrIzWmo1W4FVG/urL
         u6thjS+D0fazwzwqYnis7FPpM2UGZGud5gwXXq66fopT1kTtZtF2GlHl/3JLnZ/K+HJH
         cPAn7EWDSRswip7rJBicZUvslC/BUi81YmAV7thqXYZDKoabfxIW7x9oHJgohIiJd9ti
         FY2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1686754897; x=1689346897;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=oCDuyYWhYFN/94I6e2LZpx79DVfDvXebaZmY8/b924c=;
        b=lQAWvEvbv7vklOpqDEPjv70w4OoLBEdg8YT7PRBEZEKNPQC7Uo5eJMlzqBscF1I/hO
         D5QwJOEZMh4jwxTyypCBhJ3XHJBVZ4H1aMwzmg27w9gIMeCrocCBoL9E53O3zhJpCm5p
         CrrIRFadZjDaT09AUANROLhB9rPAaVEXKlcs9c+mxG7gd4ad24DczQUwx1tLUk5I8Wtf
         clT/I19YuexHp9b/M1HIMLVn/q2YA/5l7bHi6WCc2NwaUtbJzUDiOm+75hdZa52Tgl3r
         hgygnWIf8ALpUFtfFcwUKIy3UWWSjIaU5a3feGH8mUJF/s++t1Z+00uzEh6hZy6Werd5
         qeAg==
X-Gm-Message-State: AC+VfDwv45OvvXr/k1lwwFW3fAKOOVSAHijb9ZhPsT/QGHSOL9YVVnwn
	4CZiAHKl5djuLD+gWq8wG5Er0z+q3+tocE8FLh8=
X-Google-Smtp-Source: ACHHUZ706T8ioe1BVjq+adg2CiQlEzcCkmbMniIeACybQlMo7jAsQni2FFdKtxBCws7/CtzTsdsm3W9Df8n7WTy+Exc=
X-Received: by 2002:a05:6214:194d:b0:62d:ef66:ff1c with SMTP id
 q13-20020a056214194d00b0062def66ff1cmr10652024qvk.24.1686754897494; Wed, 14
 Jun 2023 08:01:37 -0700 (PDT)
MIME-Version: 1.0
References: <ZH+oL657y6sfy08/@tucnak> <nycvar.YFH.7.77.849.2306130810310.4723@jbgna.fhfr.qr>
 <ZIhTAAWzIK9Z09QU@tucnak> <nycvar.YFH.7.77.849.2306141227540.4723@jbgna.fhfr.qr>
 <ZInH2L1MHxI13xgK@tucnak> <CAFULd4bsEnQHQEJZOa1=7Xpee7g_YzWEsSV5P9QEdaA9qJvCSA@mail.gmail.com>
 <ZInVFb/ehNgd0Sup@tucnak>
In-Reply-To: <ZInVFb/ehNgd0Sup@tucnak>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Wed, 14 Jun 2023 17:01:25 +0200
Message-ID: <CAFULd4bcPVWyEX=dCH10BpKY62tKEvHbWiY=4eBPpPiGGkhUBw@mail.gmail.com>
Subject: Re: [PATCH] middle-end, i386, v3: Pattern recognize add/subtract with
 carry [PR79173]
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Wed, Jun 14, 2023 at 4:56=E2=80=AFPM Jakub Jelinek <jakub@redhat.com> wr=
ote:
>
> On Wed, Jun 14, 2023 at 04:34:27PM +0200, Uros Bizjak wrote:
> > LGTM for the x86 part. I did my best, but those peephole2 patterns are
> > real PITA to be reviewed thoroughly.
> >
> > Maybe split out peephole2 pack to a separate patch, followed by a
> > testcase patch. This way, bisection would be able to point out if a
> > generic part or target-dependent part caused eventual regression.
>
> Ok.  Guess if it helps for bisection, I could even split the peephole2s
> to one peephole2 addition per commit and then the final patch would add t=
he
> expanders and the generic code.

I don't think it is necessary to split it too much. Peephole2s can be
tricky, but if there is something wrong, it is easy to figure out
which one is problematic.

Uros.