From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com
 [IPv6:2607:f8b0:4864:20::832])
 by sourceware.org (Postfix) with ESMTPS id A7DE93858CDA
 for <gcc-patches@gcc.gnu.org>; Mon, 18 Jul 2022 06:10:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7DE93858CDA
Received: by mail-qt1-x832.google.com with SMTP id r24so1470872qtx.6
 for <gcc-patches@gcc.gnu.org>; Sun, 17 Jul 2022 23:10:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=OCHdEr40k/AkesPcXDAAzBKm962OoDkHS/BhL0f97Dg=;
 b=OSbgFtmM1Eyu+Sn1VJppV6u5tTh9I4Mk8UPv1GsV5G42umzpDkh554eUDDuQvJMkyO
 eUvridArzHqQNipNOzgh82SfFHcLpCefTK0DfT0OGf7Ciy3bzDROb2Mba60kHTYEEwK2
 EaZOv+MXWedLQVa3+q38cw4xlPJRuXBclpGES5sFH6dNYOEhAkDqMnhRJFifdTIkdOBY
 j9VDeNBnA0JiWQGCTM48AxwLJza8/kmdCCFVsjl87s7C0N8A0t+68jfQRpnK0d1PbPuU
 pgL95TCo5IQwcCwl7OoiD36QBBMlLOjh9W0bSFbzizAiqd7M0D1Tljs+GLQO56Wegqfx
 /o0Q==
X-Gm-Message-State: AJIora/K40p/HJjz8YjvGVDB4O3D8Y9RodEmnd6UJpKwZgq+SRBp9DfN
 gWtXG0JJg2Utcmqw8p+GWOhfTWFTli7eqE2vhRXUQfG7gkQ=
X-Google-Smtp-Source: AGRyM1uzJvCpo9ijz6uLxCnvvH9anOkV17wNyabKyR6oY9E8v9CNiHk5IP1s/3pXpJYX+ZVCh5S3FSXpn5yhXWczf2k=
X-Received: by 2002:a05:622a:110a:b0:31e:d8ed:abb9 with SMTP id
 e10-20020a05622a110a00b0031ed8edabb9mr11666904qty.54.1658124635045; Sun, 17
 Jul 2022 23:10:35 -0700 (PDT)
MIME-Version: 1.0
References: <036601d89947$c425d0d0$4c717270$@nextmovesoftware.com>
In-Reply-To: <036601d89947$c425d0d0$4c717270$@nextmovesoftware.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Mon, 18 Jul 2022 08:10:24 +0200
Message-ID: <CAFULd4bg0zRB+BK0t_NQgbq6+1J-b2F+o8dfRmyu6v2vghVDbw@mail.gmail.com>
Subject: Re: [x86_64 PATCH] PR target/106231: Optimize (any_extend:DI (ctz:SI
 ...)).
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jul 2022 06:10:37 -0000

On Sat, Jul 16, 2022 at 9:10 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> This patch resolves PR target/106231 by providing insns that recognize
> (zero_extend:DI (ctz:SI ...)) and (sign_extend:DI (ctz:SI ...)).  The
> result of ctz:SI is always between 0 and 32 (or undefined), so
> sign_extension is the same as zero_extension, and the result is already
> extended in the destination register.
>
> Things are a little complicated, because the existing implementation
> of *ctzsi2 handles multiple cases, including false dependencies, which
> we continue to support in this patch.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check with no new failures.  Ok for mainline?
>
> 2022-07-16  Roger Sayle  <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
>         PR target/106231
>         * config/i386/i386.md (*ctzsidi2_<s>ext): New insn_and_split
>         to recognize any_extend:DI of ctz:SI which is implicitly extended.
>         (*ctzsidi2_<s>ext_falsedep): New define_insn to model a DImode
>         extended ctz:SI that has preceding xor to break false dependency.
>
> gcc/testsuite/ChangeLog
>         PR target/106231
>         * gcc.target/i386/pr106231-1.c: New test case.
>         * gcc.target/i386/pr106231-2.c: New test case.

OK.

Thanks,
Uros.

>
> Thanks in advance,
> Roger
> --
>