* [PATCH][X86] Fix Typo
@ 2020-12-21 11:03 Hongtao Liu
2020-12-21 12:46 ` Uros Bizjak
0 siblings, 1 reply; 2+ messages in thread
From: Hongtao Liu @ 2020-12-21 11:03 UTC (permalink / raw)
To: Uros Bizjak, GCC Patches
When i'm working on PR98348, i notice there's Typo in define_insn
"*one_cmpl<mode>2_1", There are 2 alternatives, so the index couldn't
be 2.
Bootstrap and regress test is ok on x86_64-unknown-linux.
gcc/ChangeLog
* config/i386/i386.md (*one_cmpl<mode>2_1): Fix typo, change
alternative from 2 to 1 in attr isa.
1 file changed, 1 insertion(+), 1 deletion(-)
gcc/config/i386/i386.md | 2 +-
modified gcc/config/i386/i386.md
@@ -10561,7 +10561,7 @@ (define_insn "*one_cmpl<mode>2_1"
not{<imodesuffix>}\t%0
#"
[(set (attr "isa")
- (cond [(eq_attr "alternative" "2")
+ (cond [(eq_attr "alternative" "1")
(if_then_else (eq_attr "mode" "SI,DI")
(const_string "avx512bw")
--
BR,
Hongtao
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][X86] Fix Typo
2020-12-21 11:03 [PATCH][X86] Fix Typo Hongtao Liu
@ 2020-12-21 12:46 ` Uros Bizjak
0 siblings, 0 replies; 2+ messages in thread
From: Uros Bizjak @ 2020-12-21 12:46 UTC (permalink / raw)
To: Hongtao Liu; +Cc: GCC Patches
On Mon, Dec 21, 2020 at 12:01 PM Hongtao Liu <crazylht@gmail.com> wrote:
>
> When i'm working on PR98348, i notice there's Typo in define_insn
> "*one_cmpl<mode>2_1", There are 2 alternatives, so the index couldn't
> be 2.
> Bootstrap and regress test is ok on x86_64-unknown-linux.
>
> gcc/ChangeLog
>
> * config/i386/i386.md (*one_cmpl<mode>2_1): Fix typo, change
> alternative from 2 to 1 in attr isa.
OK.
Thanks,
Uros.
>
> 1 file changed, 1 insertion(+), 1 deletion(-)
> gcc/config/i386/i386.md | 2 +-
>
> modified gcc/config/i386/i386.md
> @@ -10561,7 +10561,7 @@ (define_insn "*one_cmpl<mode>2_1"
> not{<imodesuffix>}\t%0
> #"
> [(set (attr "isa")
> - (cond [(eq_attr "alternative" "2")
> + (cond [(eq_attr "alternative" "1")
> (if_then_else (eq_attr "mode" "SI,DI")
> (const_string "avx512bw")
>
> --
> BR,
> Hongtao
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-21 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 11:03 [PATCH][X86] Fix Typo Hongtao Liu
2020-12-21 12:46 ` Uros Bizjak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).