From: Uros Bizjak <ubizjak@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>,
Marek Polacek <polacek@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] FALLTHRU markers for sse.md and some cleanups
Date: Sat, 01 Oct 2016 08:31:00 -0000 [thread overview]
Message-ID: <CAFULd4bkdSmJJUVw_eYSXOgabWABjPDEWrQ08DvvEDVFKTZ0gQ@mail.gmail.com> (raw)
In-Reply-To: <20160930201750.GI7282@tucnak.redhat.com>
On Fri, Sep 30, 2016 at 10:17 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Sep 29, 2016 at 06:21:13PM +0200, Marek Polacek wrote:
>> On Tue, Sep 27, 2016 at 09:58:20PM +0200, Jakub Jelinek wrote:
>> > On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote:
>> > > Not sure if I read this code correctly, but if we fall through from
>> > > V32HImode, and we have TARGET_SSE2 set, we execute this code:
>> > >
>> > > tmp = "p<logic>";
>> > > ssesuffix = TARGET_AVX512VL ? "q" : "";
>> > >
>> > > And not gcc_unreachable (), as is probably intended.
>> >
>> > It really doesn't matter.
>> > The instruction uses
>> > (define_mode_iterator VI12_AVX_AVX512F
>> > [ (V64QI "TARGET_AVX512F") (V32QI "TARGET_AVX") V16QI
>> > (V32HI "TARGET_AVX512F") (V16HI "TARGET_AVX") V8HI])
>> > iterator (and, after all, ix86_hard_regno_mode_ok should ensure the same),
>> > which means V64QI/V32HI will only show up for TARGET_AVX512F, V32QI/V16HI
>> > only for TARGET_AVX (which implies TARGET_SSE2), and the slightly
>> > nonsensical
>> > gcc_assert (TARGET_SSE2 || TARGET_AVX512VL);
>> > before the switch (the || TARGET_AVX512VL is pointless, because
>> > TARGET_AVX512VL implies TARGET_SSE2 as well as TARGET_AVX2).
>> > So, I'd go perhaps for (untested) following patch, first diff -up, followed
>> > by diff -upb:
>>
>> Looks good, are you going to test/commit it? Or should I?
>
> Here it is, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
>
> 2016-09-30 Jakub Jelinek <jakub@redhat.com>
>
> * config/i386/sse.md (<mask_codefor><code><mode>): Add FALLTHRU
> comments. Simplify asserts, remove unnecessary conditions.
> Formatting fixes.
> (*<code><mode>3): Likewise.
OK.
Thanks,
Uros.
prev parent reply other threads:[~2016-10-01 8:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 16:55 PATCH to add more FALLTHRU markers Marek Polacek
2016-09-27 19:00 ` Richard Sandiford
2016-09-29 17:22 ` Marek Polacek
2016-09-27 19:08 ` Florian Weimer
2016-09-27 19:22 ` Marek Polacek
2016-09-27 19:33 ` Florian Weimer
2016-09-27 19:39 ` Marek Polacek
2016-09-27 20:13 ` Jakub Jelinek
2016-09-29 17:17 ` Marek Polacek
2016-09-29 20:21 ` Jakub Jelinek
2016-09-30 21:31 ` [PATCH] FALLTHRU markers for sse.md and some cleanups Jakub Jelinek
2016-10-01 8:31 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4bkdSmJJUVw_eYSXOgabWABjPDEWrQ08DvvEDVFKTZ0gQ@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).