From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95098 invoked by alias); 1 Oct 2016 08:31:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95080 invoked by uid 89); 1 Oct 2016 08:31:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: Yes, score=5.7 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,MEDICAL_SUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=cleanups, sk:VI12_AV, v8hi, TARGET_AVX512VL X-HELO: mail-vk0-f65.google.com Received: from mail-vk0-f65.google.com (HELO mail-vk0-f65.google.com) (209.85.213.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 01 Oct 2016 08:30:19 +0000 Received: by mail-vk0-f65.google.com with SMTP id v205so4627702vke.3 for ; Sat, 01 Oct 2016 01:30:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TuimzAb0spUqshmiiVoue3BDShxHWKnBypC4XsjBZeo=; b=mhpoCZxt73KQZqqOvwrYii5RHaUX5lElhgwtMMVNy0+4tjL70VgSnJ4fszUjpsVImh nXfUESLw7wxYm2frz3dPnR71sjyYY5LjFllgUJu9JpgQGbkUNpphnCMeYvU6YGoX7Ilr VfkebDaJ2PYKHRLUFhB4Uv+ZkzAQA029uBE7gPY5uMrxigf+wcbbHKwVe7d1B0Idb7hI sXwN5BuVOdyK6iFaIjBDMQ+AX8BHzbhqI+cpkMFKvlCk28/TdhLrDJNp0lPDOr8UXDmD gEhuGcM/qsF7kyF+MT876JHxU/0KJhrhZQ7pfLFv4yPaqZB9QDW7T1mF0f2afHkg0VsN 92Hw== X-Gm-Message-State: AA6/9RmQrvf/O/Pt/s9Sp2Ky7JA33/9VqB4cOcFDpX0lOo2vQVCcix5bkGaQKajQwlo99i0GSHw7yqsXv6/+ag== X-Received: by 10.31.230.4 with SMTP id d4mr2254984vkh.107.1475310614384; Sat, 01 Oct 2016 01:30:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.113.6 with HTTP; Sat, 1 Oct 2016 01:30:13 -0700 (PDT) In-Reply-To: <20160930201750.GI7282@tucnak.redhat.com> References: <20160927164726.GG3223@redhat.com> <87bmz9xj7w.fsf@mid.deneb.enyo.de> <20160927191847.GJ3223@redhat.com> <874m51xhtl.fsf@mid.deneb.enyo.de> <20160927195820.GE7282@tucnak.redhat.com> <20160929162113.GU3223@redhat.com> <20160930201750.GI7282@tucnak.redhat.com> From: Uros Bizjak Date: Sat, 01 Oct 2016 08:31:00 -0000 Message-ID: Subject: Re: [PATCH] FALLTHRU markers for sse.md and some cleanups To: Jakub Jelinek Cc: Kirill Yukhin , Marek Polacek , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-10/txt/msg00006.txt.bz2 On Fri, Sep 30, 2016 at 10:17 PM, Jakub Jelinek wrote: > On Thu, Sep 29, 2016 at 06:21:13PM +0200, Marek Polacek wrote: >> On Tue, Sep 27, 2016 at 09:58:20PM +0200, Jakub Jelinek wrote: >> > On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: >> > > Not sure if I read this code correctly, but if we fall through from >> > > V32HImode, and we have TARGET_SSE2 set, we execute this code: >> > > >> > > tmp = "p"; >> > > ssesuffix = TARGET_AVX512VL ? "q" : ""; >> > > >> > > And not gcc_unreachable (), as is probably intended. >> > >> > It really doesn't matter. >> > The instruction uses >> > (define_mode_iterator VI12_AVX_AVX512F >> > [ (V64QI "TARGET_AVX512F") (V32QI "TARGET_AVX") V16QI >> > (V32HI "TARGET_AVX512F") (V16HI "TARGET_AVX") V8HI]) >> > iterator (and, after all, ix86_hard_regno_mode_ok should ensure the same), >> > which means V64QI/V32HI will only show up for TARGET_AVX512F, V32QI/V16HI >> > only for TARGET_AVX (which implies TARGET_SSE2), and the slightly >> > nonsensical >> > gcc_assert (TARGET_SSE2 || TARGET_AVX512VL); >> > before the switch (the || TARGET_AVX512VL is pointless, because >> > TARGET_AVX512VL implies TARGET_SSE2 as well as TARGET_AVX2). >> > So, I'd go perhaps for (untested) following patch, first diff -up, followed >> > by diff -upb: >> >> Looks good, are you going to test/commit it? Or should I? > > Here it is, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk? > > 2016-09-30 Jakub Jelinek > > * config/i386/sse.md (): Add FALLTHRU > comments. Simplify asserts, remove unnecessary conditions. > Formatting fixes. > (*3): Likewise. OK. Thanks, Uros.