From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-296221-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 21710 invoked by alias); 7 Jul 2011 15:12:41 -0000
Received: (qmail 21696 invoked by uid 22791); 7 Jul 2011 15:12:39 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-pz0-f47.google.com (HELO mail-pz0-f47.google.com) (209.85.210.47)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jul 2011 15:12:24 +0000
Received: by pzk36 with SMTP id 36so890054pzk.20        for <multiple recipients>; Thu, 07 Jul 2011 08:12:23 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.66.7 with SMTP id o7mr458935wfa.367.1310051543289; Thu, 07 Jul 2011 08:12:23 -0700 (PDT)
Received: by 10.142.107.13 with HTTP; Thu, 7 Jul 2011 08:12:23 -0700 (PDT)
In-Reply-To: <CAMe9rOoaX3bWhbfZXOov34hyCJXWcA9r301MkEFopg-1=UCmMw@mail.gmail.com>
References: <20110605195441.GA1225@intel.com>	<20110705143920.GA25294@intel.com>	<CAFULd4ZvcB+kiXRFv+GkM67FZOCYdyOkYEaS61Z8CNh=ENEf-Q@mail.gmail.com>	<CAMe9rOoOUrV7rHb1nADYafkcHrK9v3DR3cjGUfOT0Aej6C3=3g@mail.gmail.com>	<CAFULd4apUvbT4h6iT=+CincfiyWoKZ28=CngUyr9m0Py5+ooAQ@mail.gmail.com>	<CAMe9rOrCWLnyO=hcK2CHajBEoj8XQmx7mCPW-22g87uR3oXxmw@mail.gmail.com>	<CAMe9rOob0efP2A=giUHmLTOLTK+=ZNTNxuTKws2WHuxyTX_KNg@mail.gmail.com>	<CAFiYyc3cffxHrDrO2miU=R2z_yLLHHpr73dosKBW3iBZWK8xHQ@mail.gmail.com>	<CAMe9rOpQ3uqJoT6dq-z9EHi_LDOsfzLNtEQB2Zb_0SB8PW05fQ@mail.gmail.com>	<CAHFMJ7scHyBijqrKGtDZgfgbTrDKsL58Z=8A7G5ym6pGGT1t8A@mail.gmail.com>	<CAMe9rOoaX3bWhbfZXOov34hyCJXWcA9r301MkEFopg-1=UCmMw@mail.gmail.com>
Date: Thu, 07 Jul 2011 15:14:00 -0000
Message-ID: <CAFULd4bnhGkAqho12fFu_EKYViiFWVYS8r161SA3T1emLcdhpg@mail.gmail.com>
Subject: Re: PATCH [1/n] X32: Add initial -x32 support
From: Uros Bizjak <ubizjak@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Paolo Bonzini <bonzini@gnu.org>, Richard Guenther <richard.guenther@gmail.com>, 	DJ Delorie <dj@redhat.com>, Alexandre Oliva <aoliva@redhat.com>, 	Ralf Wildenhues <Ralf.Wildenhues@gmx.de>, neroden@gcc.gnu.org, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-07/txt/msg00490.txt.bz2

On Thu, Jul 7, 2011 at 5:02 PM, H.J. Lu <hjl.tools@gmail.com> wrote:

>> Did you even _think_ of looking at the sh configury, and do something
>> vaguely similar for x86?
>>
>> You should not duplicate t-linux64 at all. =A0Instead, in config.gcc set
>> m64/m32 as the default value for with_multilib_list on i386 biarch and
>> x86_64. =A0Pass $with_multilib_list to t-linux64 using
>> TM_MULTILIB_CONFIG. =A0Then, do something like
>>
>> comma=3D,
>> MULTILIB_OPTIONS =A0 =A0=3D $(subst $(comma),/,@TM_MULTILIB_CONFIG@)
>> MULTILIB_DIRNAMES =A0 =3D $(patsubst m%, %, $(subst /, ,$(MULTILIB_OPTIO=
NS)))
>> MULTILIB_OSDIRNAMES =A0=3D 64=3D../lib64
>> MULTILIB_OSDIRNAMES +=3D 32=3D$(if $(wildcard $(shell echo
>> $(SYSTEM_HEADER_DIR))/../../usr/lib32),../lib32,../lib)
>> MULTILIB_OSDIRNAMES +=3D x32=3D../libx32
>>
>> in config/t-linux64. =A0(Each on one line, apologies for any wrapping)
>>
>> The option will be used as --with-multilib-list=3Dm64,m32,mx32 (allowing
>> the user to omit some of the variants, too).
>>
>
> This is an excellent suggestion. =A0Here is the updated patch. It
> uses TM_MULTILIB_CONFIG and removes config/i386/t-linux-x32.
>
> Uros, is this OK for trunk to replace the patch you approved earlier?

Er, the approval was fo x86 parts, I will leave approval for build
parts to Paolo.

Thanks,
Uros.