From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by sourceware.org (Postfix) with ESMTPS id 7C0333858D1E for ; Thu, 22 Dec 2022 08:04:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7C0333858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2c.google.com with SMTP id t15so1101657ybq.4 for ; Thu, 22 Dec 2022 00:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XMQkbRHYQa3kzDITC5kOtwhPVaa5hE66IAY3AFMPtdQ=; b=HeEl68fah1+md/Rn4xm+V/xlNnjCo7Ba4FBzJKNfZBePWUnHVrl8ixGHzNMGlKrz1d F4xs/DMUDfzDVjlY0BkmOM8HK7RbOgpaDvUYH/t+BA5TiJ3dIWBdmUSXqxpFrCCyzT3K e27ikfLWxLVUImhiPml+BBgeVC12fZCWj4oxTWLbOvMQZKqLHBcd2iB9IlLiLtCvo/PU rhqwBUNtVUo0uJ2Y6Df3waXYkkAJyNzn8NIVNUnJ9ql5IHHXFudoyMDd2w6whZP0r3LV 32oNF59aWnuRAgSryzXhWn0s+IKe3h/KM72IgA8ZRZ4Ic+3Azg9GsnMPzehMa0nelX6/ wmyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XMQkbRHYQa3kzDITC5kOtwhPVaa5hE66IAY3AFMPtdQ=; b=iNSMHwx32NTTjtU1lcu5zBkb/dkJwcKlA2aCoK2UHDZZIaAvrzDLrXTdIZQwpODek7 8mYCqnkZh+lRGozXzkxqMvaeGLjBvCSGi7G5CR0XkQlrviPLavs45cggY3TpF7KA/rc1 A362+8eVDmjlsxwTqAUCbjX8LxLr+NtGW04Ia8E4PwiweWCHRZy0kFlPGQsVWCkZnvw4 emghGOxaoDWIQM97Q4GGy0+t9s1xpZtOwcC/+rRkahC2n9IsV/Hw0qgWs+nYj1eghdLg oz7Y5bjCqW9bqlx6F9AN5ddDnP6htkkPX4ip0dLLkuv3hfmO1nQJpjE4tOCRNVNc2bWA GzDw== X-Gm-Message-State: AFqh2koP33Gna/Ac9+2vkzv0Mzp2LxACCragjyNegxCKe80lEGmDcaN6 9QIUNQf7dUtqJXInhEOJ+AgstV177sK5sbhCGDE= X-Google-Smtp-Source: AMrXdXvb2L3BZwXhiTrSToOSCJYuifERLM93y1A9iW5rnx2RALvwsOQVlNuYyJwAvHlBLWmB3t0Zbs7mhYWqHLKR0ac= X-Received: by 2002:a25:8387:0:b0:75a:71d8:9094 with SMTP id t7-20020a258387000000b0075a71d89094mr410952ybk.223.1671696284011; Thu, 22 Dec 2022 00:04:44 -0800 (PST) MIME-Version: 1.0 References: <20221215062137.3128845-1-hongtao.liu@intel.com> <20221215062137.3128845-2-hongtao.liu@intel.com> In-Reply-To: From: Uros Bizjak Date: Thu, 22 Dec 2022 09:04:33 +0100 Message-ID: Subject: Re: [PATCH V2 2/2] [x86] x86: Add a new option -mdaz-ftz to enable FTZ and DAZ flags in MXCSR. To: Hongtao Liu Cc: "H.J. Lu" , gcc-patches@gcc.gnu.org, Jakub Jelinek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 22, 2022 at 5:40 AM Hongtao Liu wrote: > > On Thu, Dec 22, 2022 at 6:46 AM Jakub Jelinek wrote: > > > > On Wed, Dec 21, 2022 at 02:43:43PM -0800, H.J. Lu wrote: > > > > > > > > > Target RejectNegative > > > > > > > > > Set 80387 floating-point precision to 80-bit. > > > > > > > > > > > > > > > > > > +mdaz-ftz > > > > > > > > > +Target > > > > > > > > > > > > > > > > s/Target/Driver/ > > > > > > > Change to Driver and Got error like:cc1: error: command-line = option > > > > > > > =E2=80=98-mdaz-ftz=E2=80=99 is valid for the driver but not f= or C. > > > > > > Hi Jakub: > > > > > > I didn't find a good solution to handle this error after chan= ging > > > > > > *Target* to *Driver*, Could you give some hints how to solve th= is > > > > > > problem? > > > > > > Or is it ok for you to mark this as *Target*(there won't be any= save > > > > > > and restore in cfun since there's no variable defined here.) > > > > > > > > > > Since all -m* options are passed to cc1, -mdaz-ftz can't be marke= d > > > > > as Driver. We need to give it a different name to mark it as Dri= ver. > > > > > > > > It is ok like that. > > > > > > > > Jakub > > > > > > > > > > The GCC driver handles -mno-XXX automatically for -mXXX. Use > > > a different name needs to handle the negation. Or we can do somethi= ng > > > like this to check for CL_DRIVER before passing it to cc1. > > > > I meant I'm ok with -m{,no-}daz-ftz option being Target rather than Dri= ver. > > > Thanks. > Uros, Is the patch for you? The original patch is then OK. Thanks, Uros.