From: Uros Bizjak <ubizjak@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] i386: Fix up *_doubleword_mask [PR105825]
Date: Fri, 3 Jun 2022 13:10:55 +0200 [thread overview]
Message-ID: <CAFULd4bp_txwp3SixSCCzDa9b-peMpwe_PHnq+a70LA1Mp4BxQ@mail.gmail.com> (raw)
In-Reply-To: <Ypnkq3rTkahg9OTN@tucnak>
On Fri, Jun 3, 2022 at 12:38 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Fri, Jun 03, 2022 at 12:23:36PM +0200, Uros Bizjak wrote:
> > I think it is better to leave the operation in its natural mode and
> > leave the peephole pass to do its magic, depending on the target.
>
> So like this?
You can use ix86_expand_binary_operator.
> 2022-06-03 Jakub Jelinek <jakub@redhat.com>
>
> PR target/105825
> * config/i386/i386.md (*ashl<dwi>3_doubleword_mask,
> *<insn><dwi>3_doubleword_mask): If top bit of mask is clear, but lower
> bits of mask aren't all set, use operands[2] mode for the AND
> operation instead of always SImode.
>
> * gcc.dg/pr105825.c: New test.
OK with using ix86_expand_binary_operator.
Thanks,
Uros.
>
> --- gcc/config/i386/i386.md.jj 2022-06-02 10:40:00.034660893 +0200
> +++ gcc/config/i386/i386.md 2022-06-03 12:33:38.180448918 +0200
> @@ -11934,8 +11934,16 @@ (define_insn_and_split "*ashl<dwi>3_doub
> if ((INTVAL (operands[3]) & ((<MODE_SIZE> * BITS_PER_UNIT) - 1))
> != ((<MODE_SIZE> * BITS_PER_UNIT) - 1))
> {
> - rtx tem = gen_reg_rtx (SImode);
> - emit_insn (gen_andsi3 (tem, operands[2], operands[3]));
> + rtx tem = gen_reg_rtx (GET_MODE (operands[2]));
> + rtx (*gen) (rtx, rtx, rtx);
> + switch (GET_MODE (operands[2]))
> + {
> + case E_HImode: gen = gen_andhi3; break;
> + case E_SImode: gen = gen_andsi3; break;
> + case E_DImode: gen = gen_anddi3; break;
> + default: gcc_unreachable ();
> + }
> + emit_insn (gen (tem, operands[2], operands[3]));
> operands[2] = tem;
> }
>
> @@ -12899,8 +12907,16 @@ (define_insn_and_split "*<insn><dwi>3_do
> if ((INTVAL (operands[3]) & ((<MODE_SIZE> * BITS_PER_UNIT) - 1))
> != ((<MODE_SIZE> * BITS_PER_UNIT) - 1))
> {
> - rtx tem = gen_reg_rtx (SImode);
> - emit_insn (gen_andsi3 (tem, operands[2], operands[3]));
> + rtx tem = gen_reg_rtx (GET_MODE (operands[2]));
> + rtx (*gen) (rtx, rtx, rtx);
> + switch (GET_MODE (operands[2]))
> + {
> + case E_HImode: gen = gen_andhi3; break;
> + case E_SImode: gen = gen_andsi3; break;
> + case E_DImode: gen = gen_anddi3; break;
> + default: gcc_unreachable ();
> + }
> + emit_insn (gen (tem, operands[2], operands[3]));
> operands[2] = tem;
> }
>
> --- gcc/testsuite/gcc.dg/pr105825.c.jj 2022-06-03 12:01:58.008460659 +0200
> +++ gcc/testsuite/gcc.dg/pr105825.c 2022-06-03 12:01:41.259637783 +0200
> @@ -0,0 +1,13 @@
> +/* PR target/105825 */
> +/* { dg-do compile { target int128 } } */
> +/* { dg-options "-O2" } */
> +/* { dg-additional-options "-mavx" { target avx } } */
> +
> +__int128 j;
> +int i;
> +
> +void
> +foo (void)
> +{
> + j <<= __builtin_parityll (i);
> +}
>
>
> Jakub
>
prev parent reply other threads:[~2022-06-03 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 10:17 Jakub Jelinek
2022-06-03 10:23 ` Uros Bizjak
2022-06-03 10:38 ` Jakub Jelinek
2022-06-03 11:10 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4bp_txwp3SixSCCzDa9b-peMpwe_PHnq+a70LA1Mp4BxQ@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).