From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102672 invoked by alias); 10 Jul 2015 10:08:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102662 invoked by uid 89); 10 Jul 2015 10:08:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-oi0-f42.google.com Received: from mail-oi0-f42.google.com (HELO mail-oi0-f42.google.com) (209.85.218.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 10 Jul 2015 10:08:31 +0000 Received: by oibp128 with SMTP id p128so46776378oib.3 for ; Fri, 10 Jul 2015 03:08:28 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.55.7 with SMTP id e7mr17710057oia.56.1436522908673; Fri, 10 Jul 2015 03:08:28 -0700 (PDT) Received: by 10.60.147.170 with HTTP; Fri, 10 Jul 2015 03:08:28 -0700 (PDT) In-Reply-To: References: <20150709131052.GA7254@intel.com> Date: Fri, 10 Jul 2015 10:08:00 -0000 Message-ID: Subject: Re: [PATCH] PR target/66813: gcc.target/i386/asm-flag-5.c failed with -march=pentium From: Uros Bizjak To: "H.J. Lu" Cc: "gcc-patches@gcc.gnu.org" , Richard Henderson Content-Type: multipart/mixed; boundary=001a113cea26af1553051a828d5f X-SW-Source: 2015-07/txt/msg00865.txt.bz2 --001a113cea26af1553051a828d5f Content-Type: text/plain; charset=UTF-8 Content-length: 1009 On Thu, Jul 9, 2015 at 3:15 PM, Uros Bizjak wrote: >> gen_rtx_ZERO_EXTEND isn't suitable in ix86_md_asm_adjust since ZERO_EXTEND >> may be expaned. We should call gen_zero_extendqiXi2 instead. >> >> OK for trunk? > > No, your patch will clobber flags when multiple flag outputs are used. > > (I plan to rewrite x86 zero_extend patterns to use preferred_for_size > attribute with peepholes, this will magically solve this bug and > readeflags-1.c failure). No, the above mentioned patch won't fly, it limits AND insn operands too much with "q" constraint. So, the patch below is what I plan to commit after bootstrap/regression test on x86_64-linux-gnu {,-m32}. 2015-07-10 Uros Bizjak PR target/66813 * config/i386/i386.c (ix86_md_asm_adjust): Emit movstrictqi sequence for TARGET_ZERO_EXTEND_WITH_AND targets. testsuite/ChangeLog: 2015-07-10 Uros Bizjak PR target/66813 * gcc.target/i386/pr66813.c: New test. Uros. --001a113cea26af1553051a828d5f Content-Type: text/plain; charset=US-ASCII; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ibxgmus30 Content-length: 1448 SW5kZXg6IHRlc3RzdWl0ZS9nY2MudGFyZ2V0L2kzODYvcHI2NjgxMy5jCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIHRlc3RzdWl0ZS9nY2MudGFyZ2V0 L2kzODYvcHI2NjgxMy5jCShyZXZpc2lvbiAwKQorKysgdGVzdHN1aXRlL2dj Yy50YXJnZXQvaTM4Ni9wcjY2ODEzLmMJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsNCBAQAorLyogeyBkZy1kbyBjb21waWxlIHsgdGFyZ2V0IHsgaWEzMiB9 IH0gfSAqLworLyogeyBkZy1vcHRpb25zICItbWFyY2g9cGVudGl1bSIgfSAq LworCisjaW5jbHVkZSAiYXNtLWZsYWctNS5jIgpJbmRleDogY29uZmlnL2kz ODYvaTM4Ni5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNvbmZpZy9p Mzg2L2kzODYuYwkocmV2aXNpb24gMjI1NjQ4KQorKysgY29uZmlnL2kzODYv aTM4Ni5jCSh3b3JraW5nIGNvcHkpCkBAIC00NTg0Miw3ICs0NTg0MiwxNyBA QCBpeDg2X21kX2FzbV9hZGp1c3QgKHZlYzxydHg+ICZvdXRwdXRzLCB2ZWM8 cnR4PiAmLwogCXsKIAkgIHJ0eCBkZXN0cWkgPSBnZW5fcmVnX3J0eCAoUUlt b2RlKTsKIAkgIGVtaXRfaW5zbiAoZ2VuX3J0eF9TRVQgKGRlc3RxaSwgeCkp OwotCSAgeCA9IGdlbl9ydHhfWkVST19FWFRFTkQgKGRlc3RfbW9kZSwgZGVz dHFpKTsKKworCSAgaWYgKFRBUkdFVF9aRVJPX0VYVEVORF9XSVRIX0FORAor CSAgICAgICYmIG9wdGltaXplX2Z1bmN0aW9uX2Zvcl9zcGVlZF9wIChjZnVu KSkKKwkgICAgeworCSAgICAgIHggPSBmb3JjZV9yZWcgKGRlc3RfbW9kZSwg Y29uc3QwX3J0eCk7CisKKwkgICAgICBlbWl0X2luc24gKGdlbl9tb3ZzdHJp Y3RxaQorCQkJIChnZW5fbG93cGFydCAoUUltb2RlLCB4KSwgZGVzdHFpKSk7 CisJICAgIH0KKwkgIGVsc2UKKwkgICAgeCA9IGdlbl9ydHhfWkVST19FWFRF TkQgKGRlc3RfbW9kZSwgZGVzdHFpKTsKIAl9CiAgICAgICBlbWl0X2luc24g KGdlbl9ydHhfU0VUIChkZXN0LCB4KSk7CiAgICAgfQo= --001a113cea26af1553051a828d5f--