From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by sourceware.org (Postfix) with ESMTPS id 3CAC43856DED for ; Tue, 21 Jun 2022 14:53:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3CAC43856DED Received: by mail-qk1-x72e.google.com with SMTP id c83so10282372qke.3 for ; Tue, 21 Jun 2022 07:53:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C1jRHIP2Q3/hgDQFBFAklj18QSbUN7UeIFymyBbr72U=; b=opVatcC8oQlIF8hRk4MFiF2sVFFdakXLjffZptcDVWdpc0aSufgN6M71cxhsJw/viV 8efhGYofSQ+xnfFJ3D8odp2WboxVRvBgWaxnILeziDBQGpm6Ny+qH8YraJxhXKqSvhEa SQ2Ird3WLDcttKEJcqDkq2IVzBj4Y8954THmuVY+AqQRaDctCmg4yj4HZ2Mi6CZyc2ik GpTcAZpkXVydYAP8uVNXX2oWinE5we7lEk1wtMDJrd6gTO07BtGbmPfjwZjlGBo1X8tW xCSdT7bH0cAPvZESH02VJeArc0JsqhR/TKxAHhF7/6l+W7proOQUxM34EUSmO1eQLUBi u1Ww== X-Gm-Message-State: AJIora/mHO7Y9H8h4Wm/aUSMMSyltlf8jJVorfysvXXz60CFdA6uFEh2 LtWNppye39tlV3e7xAVSAB6Ok+VOfjdvfl9NbqM= X-Google-Smtp-Source: AGRyM1tvr7eCXrJi4MzP2DFppqM/kqcZRajYW5at0QYsd88HsBQywnKdeqmgc44Q1UJElUFSjercr7iPrxws2TMZUXQ= X-Received: by 2002:a05:620a:2587:b0:6a7:ee6f:bf2a with SMTP id x7-20020a05620a258700b006a7ee6fbf2amr20584112qko.542.1655823218511; Tue, 21 Jun 2022 07:53:38 -0700 (PDT) MIME-Version: 1.0 References: <20220614192548.1929268-1-hjl.tools@gmail.com> In-Reply-To: From: Uros Bizjak Date: Tue, 21 Jun 2022 16:53:27 +0200 Message-ID: Subject: Re: PING^1 [PATCH] i386: Disallow sibcall when calling ifunc functions with PIC register To: "H.J. Lu" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 14:53:40 -0000 On Tue, Jun 21, 2022 at 4:46 PM H.J. Lu wrote: > > On Mon, Jun 20, 2022 at 7:51 AM Uros Bizjak wrote: > > > > On Mon, Jun 20, 2022 at 4:03 PM H.J. Lu wrote: > > > > > > On Tue, Jun 14, 2022 at 12:25 PM H.J. Lu wrote: > > > > > > > > Disallow siball when calling ifunc functions with PIC register so that > > > > PIC register can be restored. > > > > > > > > gcc/ > > > > > > > > PR target/105960 > > > > * config/i386/i386.cc (ix86_function_ok_for_sibcall): Return > > > > false if PIC register is used when calling ifunc functions. > > > > > > > > gcc/testsuite/ > > > > > > > > PR target/105960 > > > > * gcc.target/i386/pr105960.c: New test. > > > > LGTM. > > OK to backport to GCC 12 branch? OK. Thanks, Uros. > Thanks. > > > Thanks, > > Uros. > > > > > > --- > > > > gcc/config/i386/i386.cc | 9 +++++++++ > > > > gcc/testsuite/gcc.target/i386/pr105960.c | 19 +++++++++++++++++++ > > > > 2 files changed, 28 insertions(+) > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr105960.c > > > > > > > > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > > > > index 3d189e124e4..1ca7836e11e 100644 > > > > --- a/gcc/config/i386/i386.cc > > > > +++ b/gcc/config/i386/i386.cc > > > > @@ -1015,6 +1015,15 @@ ix86_function_ok_for_sibcall (tree decl, tree exp) > > > > } > > > > } > > > > > > > > + if (decl && ix86_use_pseudo_pic_reg ()) > > > > + { > > > > + /* When PIC register is used, it must be restored after ifunc > > > > + function returns. */ > > > > + cgraph_node *node = cgraph_node::get (decl); > > > > + if (node && node->ifunc_resolver) > > > > + return false; > > > > + } > > > > + > > > > /* Otherwise okay. That also includes certain types of indirect calls. */ > > > > return true; > > > > } > > > > diff --git a/gcc/testsuite/gcc.target/i386/pr105960.c b/gcc/testsuite/gcc.target/i386/pr105960.c > > > > new file mode 100644 > > > > index 00000000000..db137a1642d > > > > --- /dev/null > > > > +++ b/gcc/testsuite/gcc.target/i386/pr105960.c > > > > @@ -0,0 +1,19 @@ > > > > +/* { dg-do compile } */ > > > > +/* { dg-require-ifunc "" } */ > > > > +/* { dg-options "-O2 -fpic" } */ > > > > + > > > > +__attribute__((target_clones("default","fma"))) > > > > +static inline double > > > > +expfull_ref(double x) > > > > +{ > > > > + return __builtin_pow(x, 0.1234); > > > > +} > > > > + > > > > +double > > > > +exp_ref(double x) > > > > +{ > > > > + return expfull_ref(x); > > > > +} > > > > + > > > > +/* { dg-final { scan-assembler "jmp\[ \t\]*expfull_ref@PLT" { target { ! ia32 } } } } */ > > > > +/* { dg-final { scan-assembler "call\[ \t\]*expfull_ref@PLT" { target ia32 } } } */ > > > > -- > > > > 2.36.1 > > > > > > > > > > PING. > > > > > > -- > > > H.J. > > > > -- > H.J.