From: Uros Bizjak <ubizjak@gmail.com>
To: Sunil Pandey <skpgkp1@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"H. J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] i386: Add AVX512 unaligned intrinsics
Date: Thu, 11 Jul 2019 18:47:00 -0000 [thread overview]
Message-ID: <CAFULd4buTAf4fR=BGZWqa2MjeCyCKWJObGGCM29EzcJYZvZaaA@mail.gmail.com> (raw)
In-Reply-To: <CAFMdu1La+mdVGM7Vy9VPCCn0gcoTXNt7TwS6OnAMmpwC17JP7w@mail.gmail.com>
On Thu, Jul 11, 2019 at 6:54 PM Sunil Pandey <skpgkp1@gmail.com> wrote:
>
> Fixed.
>
> --Sunil Pandey
>
> i386: Add AVX512 unaligned intrinsics
>
> __m512i _mm512_loadu_epi64( void * sa);
> void _mm512_storeu_epi64(void * d, __m512i a);
> __m512i _mm512_loadu_epi32( void * sa);
> void _mm512_storeu_epi32(void * d, __m512i a);
> void _mm256_storeu_epi64(void * d, __m256i a);
> void _mm_storeu_epi64(void * d, __m128i a);
> void _mm256_storeu_epi32(void * d, __m256i a);
> void _mm_storeu_epi32(void * d, __m128i a);
>
> Tested on x86-64.
>
> gcc/
>
> PR target/90980
> * config/i386/avx512fintrin.h (_mm512_loadu_epi64): New.
> (_mm512_storeu_epi64): Likewise.
> (_mm512_loadu_epi32): Likewise.
> (_mm512_storeu_epi32): Likewise.
> * config/i386/avx512vlintrin.h (_mm256_storeu_epi64): New.
> (_mm_storeu_epi64): Likewise.
> (_mm256_storeu_epi32): Likewise.
> (_mm_storeu_epi32): Likewise.
>
> gcc/testsuite/
>
> PR target/90980
> * gcc.target/i386/pr90980-1.c: New test.
> * gcc.target/i386/pr90980-2.c: Likewise.
> * gcc.target/i386/pr90980-3.c: Likewise.
OK.
Thanks,
Uros.
> On Wed, Jul 10, 2019 at 12:20 PM Uros Bizjak <ubizjak@gmail.com> wrote:
> >
> > On Wed, Jul 10, 2019 at 9:11 PM Sunil Pandey <skpgkp1@gmail.com> wrote:
> > >
> > > Thanks Uros. I incorporated suggested changes in attached patch.
> > >
> > > --Sunil Pandey
> > >
> > > i386: Add AVX512 unaligned intrinsics
> > >
> > > __m512i _mm512_loadu_epi32( void * sa);
> > > __m512i _mm512_loadu_epi64( void * sa);
> > > void _mm512_storeu_epi32(void * d, __m512i a);
> > > void _mm256_storeu_epi32(void * d, __m256i a);
> > > void _mm_storeu_epi32(void * d, __m128i a);
> > > void _mm512_storeu_epi64(void * d, __m512i a);
> > > void _mm256_storeu_epi64(void * d, __m256i a);
> > > void _mm_storeu_epi64(void * d, __m128i a);
> > >
> > > Tested on x86-64.
> > >
> > > gcc/
> > >
> > > PR target/90980
> > > * config/i386/avx512fintrin.h (_mm512_loadu_epi32): New.
> > > (_mm512_loadu_epi64): Likewise.
> > > (_mm512_storeu_epi32): Likewise.
> > > (_mm512_storeu_epi64): Likewise.
> > > * config/i386/avx512vlintrin.h (_mm_storeu_epi32): New.
> > > (_mm256_storeu_epi32): Likewise.
> > > (_mm_storeu_epi64): Likewise.
> > > (_mm256_storeu_epi64): Likewise.
> > >
> > > gcc/testsuite/
> > >
> > > PR target/90980
> > > * gcc.target/i386/pr90980-1.c: New test.
> > > * gcc.target/i386/pr90980-2.c: Likewise.
> > > * gcc.target/i386/pr90980-3.c: Likewise.
> >
> > Looks good, but please put new intrinsics nearby existing intrinsics,
> > so we will have e.g.:
> >
> > _mm512_loadu_epi32
> > _mm512_mask_loadu_epi32
> > _mm512_maskz_loadu_epi32
> >
> > and in similar way for other loads and stores.
> >
> > Uros.
> >
> > >
> > > On Tue, Jul 9, 2019 at 11:39 PM Uros Bizjak <ubizjak@gmail.com> wrote:
> > > >
> > > > On Tue, Jul 9, 2019 at 11:44 PM Sunil Pandey <skpgkp1@gmail.com> wrote:
> > > > >
> > > > > __m512i _mm512_loadu_epi32( void * sa);
> > > > > __m512i _mm512_loadu_epi64( void * sa);
> > > > > void _mm512_storeu_epi32(void * d, __m512i a);
> > > > > void _mm256_storeu_epi32(void * d, __m256i a);
> > > > > void _mm_storeu_epi32(void * d, __m128i a);
> > > > > void _mm512_storeu_epi64(void * d, __m512i a);
> > > > > void _mm256_storeu_epi64(void * d, __m256i a);
> > > > > void _mm_storeu_epi64(void * d, __m128i a);
> > > > >
> > > > > Tested on x86-64.
> > > > >
> > > > > OK for trunk?
> > > > >
> > > > > --Sunil Pandey
> > > > >
> > > > >
> > > > > gcc/
> > > > >
> > > > > PR target/90980
> > > > > * config/i386/avx512fintrin.h (__v16si_u): New data type
> > > > > (__v8di_u): Likewise
> > > > > (_mm512_loadu_epi32): New.
> > > > > (_mm512_loadu_epi64): Likewise.
> > > > > (_mm512_storeu_epi32): Likewise.
> > > > > (_mm512_storeu_epi64): Likewise.
> > > > > * config/i386/avx512vlintrin.h (_mm_storeu_epi32): New.
> > > > > (_mm256_storeu_epi32): Likewise.
> > > > > (_mm_storeu_epi64): Likewise.
> > > > > (_mm256_storeu_epi64): Likewise.
> > > > >
> > > > > gcc/testsuite/
> > > > >
> > > > > PR target/90980
> > > > > * gcc.target/i386/avx512f-vmovdqu32-3.c: New test.
> > > > > * gcc.target/i386/avx512f-vmovdqu64-3.c: Likewise.
> > > > > * gcc.target/i386/pr90980-1.c: Likewise.
> > > > > * gcc.target/i386/pr90980-2.c: Likewise.
> > > >
> > > > +/* Internal data types for implementing unaligned version of intrinsics. */
> > > > +typedef int __v16si_u __attribute__ ((__vector_size__ (64),
> > > > + __aligned__ (1)));
> > > > +typedef long long __v8di_u __attribute__ ((__vector_size__ (64),
> > > > + __aligned__ (1)));
> > > >
> > > > You should define only one generic __m512i_u type, something like:
> > > >
> > > > typedef long long __m512i_u __attribute__ ((__vector_size__ (64),
> > > > __may_alias__, __aligned__ (1)));
> > > >
> > > > Please see avxintrin.h how __m256i_u is defined and used.
> > > >
> > > > Uros.
prev parent reply other threads:[~2019-07-11 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 22:03 Sunil Pandey
2019-07-10 9:03 ` Uros Bizjak
2019-07-10 19:20 ` Sunil Pandey
2019-07-10 19:30 ` Uros Bizjak
2019-07-11 17:04 ` Sunil Pandey
2019-07-11 18:47 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4buTAf4fR=BGZWqa2MjeCyCKWJObGGCM29EzcJYZvZaaA@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=skpgkp1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).