From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by sourceware.org (Postfix) with ESMTPS id 4BF87385B523 for ; Fri, 17 Feb 2023 08:52:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BF87385B523 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5339fa6ef20so41043927b3.10 for ; Fri, 17 Feb 2023 00:52:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Atzjlp5PQK9MVkEdLb52cS2IilXMx3PzZUnNDkGZpMA=; b=oeWgNushH6QGO/tewUuIGarZC8UcfFxdZuDU/B0N3tZgPHICXOd8N2itVW32jv/5aH 8Qs1O1R1R7Tif1kQ4HXBFmJVxs1bMWP92iI4QCv8RA+SSGdZUP/OWLUvMhWG3I8hfdNV pkoVVAAk0oNjmMQzgfYwBrA8SHp83NCEzUkELIITPktJhgLenxI+Jo+cETg9EH237PmA EBhtghuvYVgFaEId59KytJHWqjGs9VGzUPl6SwoVUZvIXk5bhAbXybbPqnbILIxGC6WR dfuANYAq6bmyyelAIvlDfNbbBeJ8kXakZaWrTojqXsxSeBR8jIXrxSxCFBTGLFwBsCQD Q6XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Atzjlp5PQK9MVkEdLb52cS2IilXMx3PzZUnNDkGZpMA=; b=bsxlE+I01LR048jtWBZeeoAAOyLCYi3UR+yB0gNeCeVgypPO4wufx+kYyr2h0do2hs S3+ze9y1anejhMCiysKb3pLVESqJo7zbp8ki14ybIA4WL4YC2MGLVdw0DhfsC7uoRsxQ WVoWO7J++MwdSfEpgjyC7DdrGk5/zmMhM1oxAGD95d6t1g8HAN5HWoxHy+AyYgHCcVhM uu850b1qSkzmvymnGFOK/mMTEjXVgjn3RrBmxyt3kIAtySER3OLzQ7jksFQEKtqO/07T wy0ejsrDwQb8P9Awt1xWhXsV+p2cwaplP18vdVGRMo3pE+4uaQ2ZKI2I9GvAiu7RP/gy JtIg== X-Gm-Message-State: AO0yUKWNmeWJpz//5oPfVPCDVKKYHE64ekm1mWPH4nble+nkyEIOrYHQ 34B7FRX5M1hBqhHYvKp7UPswz0uxhDXOjzjhfnk= X-Google-Smtp-Source: AK7set9QllV4u8v1USHBs4XVinsjnLR7i5iqxctY6gZ2my1HHHYKlNpY2fuU58r/xa8gASGf1DUY8WxWcuD8Yj8+wLU= X-Received: by 2002:a81:6008:0:b0:52e:e6ed:30ab with SMTP id u8-20020a816008000000b0052ee6ed30abmr1158820ywb.555.1676623929523; Fri, 17 Feb 2023 00:52:09 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Uros Bizjak Date: Fri, 17 Feb 2023 09:51:57 +0100 Message-ID: Subject: Re: [PATCH] simplify-rtx: Fix VOIDmode operand handling in simplify_subreg [PR108805] To: Richard Biener Cc: "gcc-patches@gcc.gnu.org" , Richard Sandiford Content-Type: multipart/mixed; boundary="000000000000bdea2705f4e16db6" X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000bdea2705f4e16db6 Content-Type: text/plain; charset="UTF-8" On Fri, Feb 17, 2023 at 8:38 AM Richard Biener wrote: > > On Thu, 16 Feb 2023, Uros Bizjak wrote: > > > simplify_subreg can return VOIDmode const_int operand and will > > cause ICE in simplify_gen_subreg when this operand is passed to it. > > > > The patch prevents VOIDmode temporary from entering simplify_gen_subreg. > > We can't process const_int operand any further, since outermode > > is not an integer mode here. > > But if it's a CONST_INT then we know it's of int_outermode, no? That is, > doesn't simplify_subreg (mode, ...) always return something in 'mode' > and thus we can always pass just 'mode' as third argument to the > following simplify_gen_subreg call? You are right. I am testing the attached patch that works too. Uros. --000000000000bdea2705f4e16db6 Content-Type: text/plain; charset="US-ASCII"; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_le8al7gm0 ZGlmZiAtLWdpdCBhL2djYy9zaW1wbGlmeS1ydHguY2MgYi9nY2Mvc2ltcGxpZnktcnR4LmNjCmlu ZGV4IDBhMWRkODhiMGE4Li4zOTU1OTI5YmI3MCAxMDA2NDQKLS0tIGEvZ2NjL3NpbXBsaWZ5LXJ0 eC5jYworKysgYi9nY2Mvc2ltcGxpZnktcnR4LmNjCkBAIC03NjY1LDcgKzc2NjUsNyBAQCBzaW1w bGlmeV9jb250ZXh0OjpzaW1wbGlmeV9zdWJyZWcgKG1hY2hpbmVfbW9kZSBvdXRlcm1vZGUsIHJ0 eCBvcCwKICAgICB7CiAgICAgICBydHggdGVtID0gc2ltcGxpZnlfc3VicmVnIChpbnRfb3V0ZXJt b2RlLCBvcCwgaW5uZXJtb2RlLCBieXRlKTsKICAgICAgIGlmICh0ZW0pCi0JcmV0dXJuIHNpbXBs aWZ5X2dlbl9zdWJyZWcgKG91dGVybW9kZSwgdGVtLCBHRVRfTU9ERSAodGVtKSwgMCk7CisJcmV0 dXJuIHNpbXBsaWZ5X2dlbl9zdWJyZWcgKG91dGVybW9kZSwgdGVtLCBpbnRfb3V0ZXJtb2RlLCAw KTsKICAgICB9CiAKICAgLyogSWYgT1AgaXMgYSB2ZWN0b3IgY29tcGFyaXNvbiBhbmQgdGhlIHN1 YnJlZyBpcyBub3QgY2hhbmdpbmcgdGhlCg== --000000000000bdea2705f4e16db6--