public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Marc Glisse <marc.glisse@inria.fr>, Richard Guenther <rguenther@suse.de>
Subject: Re: [i386] __builtin_ia32_stmxcsr could be pure
Date: Wed, 21 Jun 2017 07:43:00 -0000	[thread overview]
Message-ID: <CAFULd4bwNUJx_BWvxaeKnncQL0-4fE=YseyPFWzJbzsrQ2roNQ@mail.gmail.com> (raw)

Hello!

> glibc marks fegetround as a pure function. On x86, people tend to use
> _MM_GET_ROUNDING_MODE instead, which could benefit from the same. I think it is safe, but
> a second opinion would be welcome. I could have handled just this builtin, but it seemed better to
> provide def_builtin_pure (like "const" already has) since there should be other builtins that can be
> marked this way (maybe the gathers?).
>
> Bootstrap+testsuite on x86_64-pc-linux-gnu with default languages.
>
> 2017-05-29  Marc Glisse  <marc.glisse@inria.fr>
>
> gcc/
> * config/i386/i386.c (struct builtin_isa): New field pure_p.
> Reorder for compactness.
> (def_builtin, def_builtin2, ix86_add_new_builtins): Handle pure_p.
> (def_builtin_pure, def_builtin_pure2): New functions.
> (ix86_init_mmx_sse_builtins) [__builtin_ia32_stmxcsr]: Mark as pure.
>
> gcc/testsuite/
> * gcc.target/i386/getround.c: New file.

OK.

Thanks,
Uros.

             reply	other threads:[~2017-06-21  7:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  7:43 Uros Bizjak [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-05-26  8:57 Marc Glisse
2017-05-26  9:13 ` Richard Biener
2017-06-03 19:05   ` Marc Glisse
2017-06-20 21:34     ` Marc Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFULd4bwNUJx_BWvxaeKnncQL0-4fE=YseyPFWzJbzsrQ2roNQ@mail.gmail.com' \
    --to=ubizjak@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=marc.glisse@inria.fr \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).