[PATCH] Fix for PR63595

[PATCH] Fix for PR63595

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

Hello.

Following patch contains addition of PHI result comparison in IPA ICF.
Boostrap works on x86_64-linux-pc, no regression observed.

Ready for trunk?
Thanks,
Martin

[-- Attachment #2: PR63595.changelog --]
[-- Type: text/plain, Size: 244 bytes --]

gcc/testsuite/ChangeLog:

2014-10-24  Martin Liska  <mliska@suse.cz>

	* gcc.dg/ipa/pr63595.c: New test.


gcc/ChangeLog:

2014-10-24  Martin Liska  <mliska@suse.cz>

	* ipa-icf.c (sem_function::compare_phi_node): PHI result comparison
	added.

[-- Attachment #3: PR63595.patch --]
[-- Type: text/x-patch, Size: 3260 bytes --]

diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
index d1238a4..7456fec 100644
--- a/gcc/ipa-icf.c
+++ b/gcc/ipa-icf.c
@@ -869,6 +869,12 @@ sem_function::compare_phi_node (basic_block bb1, basic_block bb2)
       phi1 = gsi_stmt (si1);
       phi2 = gsi_stmt (si2);
 
+      tree phi_result1 = gimple_phi_result (phi1);
+      tree phi_result2 = gimple_phi_result (phi2);
+
+      if (!m_checker->compare_operand (phi_result1, phi_result2))
+	return return_false_with_msg ("PHI results are different");
+
       size1 = gimple_phi_num_args (phi1);
       size2 = gimple_phi_num_args (phi2);
 
diff --git a/gcc/testsuite/gcc.dg/ipa/pr63595.c b/gcc/testsuite/gcc.dg/ipa/pr63595.c
new file mode 100644
index 0000000..52851fb
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/ipa/pr63595.c
@@ -0,0 +1,65 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-ipa-icf-details"  } */
+
+typedef int size_t;
+
+typedef struct TypHeader {
+    unsigned long size;
+    struct TypHeader * * ptr;
+    char name[3];
+    unsigned char type;
+} * TypHandle;
+
+__attribute__((noinline))
+static TypHandle Error(const char *str, unsigned long l1, unsigned long l2)
+{
+  return 0;
+}
+
+extern TypHandle (* EvTab[81]) ( TypHandle hd );
+extern TypHandle (*TabProd[28][28]) ( TypHandle, TypHandle );
+
+__attribute__((noinline))
+TypHandle FunOnRight (TypHandle hdCall)
+{
+    TypHandle hdRes;
+    TypHandle hdPnt;
+    TypHandle hdElm;
+
+
+    if ( ((hdCall)->size) != 3*((size_t)sizeof(TypHandle)) )
+        return Error("",0L,0L);
+    hdPnt = ((long)(((TypHandle*)((hdCall)->ptr))[1])&1 ? (((TypHandle*)((hdCall)->ptr))[1]) : (* EvTab[(((long)(((TypHandle*)((hdCall)->ptr))[1]) & 1) ? 1 : ((((TypHandle*)((hdCall)->ptr))[1])->type))])((((TypHandle*)((hdCall)->ptr))[1])));
+    hdElm = ((long)(((TypHandle*)((hdCall)->ptr))[2])&1 ? (((TypHandle*)((hdCall)->ptr))[2]) : (* EvTab[(((long)(((TypHandle*)((hdCall)->ptr))[2]) & 1) ? 1 : ((((TypHandle*)((hdCall)->ptr))[2])->type))])((((TypHandle*)((hdCall)->ptr))[2])));
+
+
+    hdRes = ((*TabProd[(((long)(hdPnt) & 1) ? 1 : ((hdPnt)->type))][(((long)(hdElm) & 1) ? 1 : ((hdElm)->type))])((hdPnt),(hdElm)));
+    return hdRes;
+}
+
+__attribute__((noinline))
+TypHandle FunOnLeft (TypHandle hdCall)
+{
+    TypHandle hdRes;
+    TypHandle hdPnt;
+    TypHandle hdElm;
+
+
+    if ( ((hdCall)->size) != 3*((size_t)sizeof(TypHandle)) )
+        return Error("",0L,0L);
+    hdPnt = ((long)(((TypHandle*)((hdCall)->ptr))[1])&1 ? (((TypHandle*)((hdCall)->ptr))[1]) : (* EvTab[(((long)(((TypHandle*)((hdCall)->ptr))[1]) & 1) ? 1 : ((((TypHandle*)((hdCall)->ptr))[1])->type))])((((TypHandle*)((hdCall)->ptr))[1])));
+    hdElm = ((long)(((TypHandle*)((hdCall)->ptr))[2])&1 ? (((TypHandle*)((hdCall)->ptr))[2]) : (* EvTab[(((long)(((TypHandle*)((hdCall)->ptr))[2]) & 1) ? 1 : ((((TypHandle*)((hdCall)->ptr))[2])->type))])((((TypHandle*)((hdCall)->ptr))[2])));
+
+
+    hdRes = ((*TabProd[(((long)(hdElm) & 1) ? 1 : ((hdElm)->type))][(((long)(hdPnt) & 1) ? 1 : ((hdPnt)->type))])((hdElm),(hdPnt)));
+    return hdRes;
+}
+
+int main()
+{
+  return 0;
+}
+
+/* { dg-final { scan-ipa-dump "Equal symbols: 0" "icf"  } } */
+/* { dg-final { scan-ipa-dump "PHI results are different" "icf"  } } */
+/* { dg-final { cleanup-ipa-dump "icf" } } */

Re: [PATCH] Fix for PR63595

[Richard Biener]

On Fri, Oct 24, 2014 at 11:35 AM, Martin Liška <mliska@suse.cz> wrote:
> Hello.
>
> Following patch contains addition of PHI result comparison in IPA ICF.
> Boostrap works on x86_64-linux-pc, no regression observed.
>
> Ready for trunk?

Ok.

Thanks,
Richard.

> Thanks,
> Martin