From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59928 invoked by alias); 2 May 2017 14:25:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59855 invoked by uid 89); 2 May 2017 14:25:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 14:25:00 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39362) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d5Yjc-0002u5-Hl for gcc-patches@gnu.org; Tue, 02 May 2017 10:25:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5Yjb-0002su-5p for gcc-patches@gnu.org; Tue, 02 May 2017 10:25:00 -0400 Received: from mail-it0-x235.google.com ([2607:f8b0:4001:c0b::235]:38093) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5Yjb-0002sd-0c for gcc-patches@gnu.org; Tue, 02 May 2017 10:24:59 -0400 Received: by mail-it0-x235.google.com with SMTP id e65so13723817ita.1 for ; Tue, 02 May 2017 07:24:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zfeKSh3Nsm/WhLLEwLQ/3aUv80YEE+6ixhjb+Xmv27k=; b=KM/DKHychxrDtnZtesLIOK0MQOZWFtra+mEqMQNVG8VEFgtN2d90bIT7R/ZE4jhW3l XEDaaSl2MGHcQ1+Y9nuIqa0oMwahpi5XW/tS/dGAMgRXBj3tg8NbybxFC0Xxg3Xg5n3P dgRtRcjuT1GyfhpeTU0fHLDbzKiLc7hyum4N0wRpYLVwJ5Vt2Wx60wgUm1OONoKAjIa9 ZkFDJV2MQnW1INq3o1DxqWLlPgLC+CFrZdN766qmohECWmfpv4mSILlnLURrg2rQT9hJ r1u7rMwdaPIl63jjO3/PzfnvIuCpHmlwvzmFmt0zxejruQ2Q0eKPkFn1wPPoow6a2Yoc tPtw== X-Gm-Message-State: AN3rC/5cipPOXlAi++yZ4+bdY63wxZL/ufE0qAgz+ivx/eHsXlKsLrxi Da/+d2iHItEwVVavSeqcq/oO1/IF6sqYGzw= X-Received: by 10.202.77.8 with SMTP id a8mr3178885oib.128.1493735098398; Tue, 02 May 2017 07:24:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.51.83 with HTTP; Tue, 2 May 2017 07:24:58 -0700 (PDT) In-Reply-To: References: From: Richard Biener Date: Tue, 02 May 2017 14:32:00 -0000 Message-ID: Subject: Re: [PATCH 5/5][GIMPLE FE] PR testsuite/80580: Handle invalid SSA names To: Mikhail Maltsev Cc: gcc-patches , Prathamesh Kulkarni Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c0b::235 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00104.txt.bz2 On Mon, May 1, 2017 at 8:09 PM, Mikhail Maltsev wrote: > When parsing SSA names, we should check that parent names are scalars. > In fact, this patch just uses the condition of a 'gcc_assert' in 'make_ssa_name_fn'. + if (!(VAR_P (parent) + || TREE_CODE (parent) == PARM_DECL + || TREE_CODE (parent) == RESULT_DECL + || (TYPE_P (parent) && is_gimple_reg_type (parent)))) + { + error ("invalid SSA name %qE", parent); + return error_mark_node; + } please drop || (TYPE_P (parent) && is_gimple_reg_type (parent))), that case isn't valid. Please also change wording slightly to "invalid base %qE for SSA name". Ok with that changes. Thanks, Richard. > -- > Regards, > Mikhail Maltsev > > > gcc/testsuite/ChangeLog: > > 2017-05-01 Mikhail Maltsev > > * gcc.dg/gimplefe-error-11.c: New test. > > > gcc/c/ChangeLog: > > 2017-05-01 Mikhail Maltsev > > * gimple-parser.c (c_parser_parse_ssa_name): Validate SSA name base. > >