[PATCH] Fix -fdump-rtl-ira segfault

[PATCH] Fix -fdump-rtl-ira segfault

[Andreas Krebbel]

Hi,

-fdump-rtl-ira currently segfaults on s390 if not also a reload dump
is requested.  The problem is that the ira_dump_file variable during
reload still points to the ira dump file although the file has already
been closed by the pass manager already.

Ok for mainline?

Bye,

-Andreas-


2012-01-17  Andreas Krebbel  <Andreas.Krebbel@de.ibm.com>

	* ira.c (do_reload): Make sure ira_dump_file is re-set if no
	reload dump is requested.

---
 gcc/ira.c |    2 !!
 1 file changed, 2 modifications(!)

Index: gcc/ira.c
===================================================================
*** gcc/ira.c.orig
--- gcc/ira.c
*************** do_reload (void)
*** 3722,3728 ****
    basic_block bb;
    bool need_dce;
  
!   if (flag_ira_verbose < 10 && dump_file)
      ira_dump_file = dump_file;
  
    df_set_flags (DF_NO_INSN_RESCAN);
--- 3722,3728 ----
    basic_block bb;
    bool need_dce;
  
!   if (flag_ira_verbose < 10)
      ira_dump_file = dump_file;
  
    df_set_flags (DF_NO_INSN_RESCAN);

Re: [PATCH] Fix -fdump-rtl-ira segfault

[Richard Guenther]

On Tue, Jan 17, 2012 at 1:58 PM, Andreas Krebbel
<krebbel@linux.vnet.ibm.com> wrote:
> Hi,
>
> -fdump-rtl-ira currently segfaults on s390 if not also a reload dump
> is requested.  The problem is that the ira_dump_file variable during
> reload still points to the ira dump file although the file has already
> been closed by the pass manager already.
>
> Ok for mainline?

Looks obvious.

Richard.

> Bye,
>
> -Andreas-
>
>
> 2012-01-17  Andreas Krebbel  <Andreas.Krebbel@de.ibm.com>
>
>        * ira.c (do_reload): Make sure ira_dump_file is re-set if no
>        reload dump is requested.
>
> ---
>  gcc/ira.c |    2 !!
>  1 file changed, 2 modifications(!)
>
> Index: gcc/ira.c
> ===================================================================
> *** gcc/ira.c.orig
> --- gcc/ira.c
> *************** do_reload (void)
> *** 3722,3728 ****
>    basic_block bb;
>    bool need_dce;
>
> !   if (flag_ira_verbose < 10 && dump_file)
>      ira_dump_file = dump_file;
>
>    df_set_flags (DF_NO_INSN_RESCAN);
> --- 3722,3728 ----
>    basic_block bb;
>    bool need_dce;
>
> !   if (flag_ira_verbose < 10)
>      ira_dump_file = dump_file;
>
>    df_set_flags (DF_NO_INSN_RESCAN);
>