From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51153 invoked by alias); 8 Feb 2016 14:24:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 51132 invoked by uid 89); 8 Feb 2016 14:24:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1665 X-HELO: mail-yk0-f178.google.com Received: from mail-yk0-f178.google.com (HELO mail-yk0-f178.google.com) (209.85.160.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 08 Feb 2016 14:24:16 +0000 Received: by mail-yk0-f178.google.com with SMTP id z13so87260839ykd.0 for ; Mon, 08 Feb 2016 06:24:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=cLoESbcaMVO5XHFndun6QOFunxEIs2x2mtPs2/rI8Go=; b=BeI/AZLqYMKXJgb6RRLCOD8YhiBqzSUf3Z5nfVjAPc3ZCrIu+QPOLiVlqJcNaP2I51 96UrTYtU8cirosOU0GYO7aimR2Wk/ozfYacxgL3Znz877Ak0L174jXC/NuLUl1MdZV6p o5ay3z/n/aOc3afQXF0Sp0lytGG5hPnAyd9kza4p9+9wQ21LcMtEvrOfoDla4E4Rdl55 OLQ072KrMBVjAPocv32fUL/dP5zFGUJiRnPwyrQpy6qnQpTWSLDTk83Ztg+YuV5shVj0 XFFDPm7yHaMUCc9rbqIlEXViQuROb+M0BW5yKbcAYBghxUFcJlwfExIa5JHhHLTLMewb UW6g== X-Gm-Message-State: AG10YOSbxDqDGcGVQGDvwA4MBhSZcG2ylOIKxLc/kV7NBfVzTp3vdP063eFNNrCaKj2/WocgiiIAjuyNmt4Vuw== MIME-Version: 1.0 X-Received: by 10.37.5.84 with SMTP id 81mr15115761ybf.19.1454941454573; Mon, 08 Feb 2016 06:24:14 -0800 (PST) Received: by 10.37.223.11 with HTTP; Mon, 8 Feb 2016 06:24:14 -0800 (PST) In-Reply-To: <20160208134024.GA19031@arm.com> References: <1454936845-18517-1-git-send-email-james.greenhalgh@arm.com> <20160208134024.GA19031@arm.com> Date: Mon, 08 Feb 2016 14:24:00 -0000 Message-ID: Subject: Re: [Patch] Gate vect-mask-store-move-1.c correctly, and actually output the dump From: Richard Biener To: James Greenhalgh Cc: Yuri Rumyantsev , gcc-patches , nd@arm.com, Uros Bizjak , =?UTF-8?B?0JjQu9GM0Y8g0K3QvdC60L7QstC40Yc=?= , Igor Zamyatin Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00558.txt.bz2 On Mon, Feb 8, 2016 at 2:40 PM, James Greenhalgh wrote: > On Mon, Feb 08, 2016 at 04:29:31PM +0300, Yuri Rumyantsev wrote: >> Hi James, >> >> Thanks for reporting this issue. >> I prepared slightly different patch since we don't need to add >> tree-vect dump option - it is on by default for all tests in /vect >> directory. > > Hm, I added that line as my test runs were showing: > > UNRESOLVED: gcc.dg/vect/vect-mask-store-move-1.c: dump file does not exist > > I would guess the explicit > > /* { dg-options "-O3" } */ > > is clobbering the vect.exp setup of flags? Yes. Use { dg-additional-options "-O3" } instead. > This also affects the x86-64 results H.J. Lu is sending out: > > https://gcc.gnu.org/ml/gcc-testresults/2016-02/msg00824.html > > Thanks, > James > >> >> gcc/testsuite/ChangeLog: >> >> * gcc.dg/vect/vect-mask-store-move-1.c: Gate dump with x86 target. >> >> 2016-02-08 16:07 GMT+03:00 James Greenhalgh : >> > >> > Hi, >> > >> > As far as I can tell, this testcase will only vectorize for x86_64/i?86 >> > targets, so it should be gated to only check for vectorization on those. >> > >> > Additionally, this test wants to scan the vectorizer dumps, so we ought >> > to add -fdump-tree-vect-all to the options. >> > >> > Checked on aarch64 (cross/native) and x86 with no issues. >> > >> > OK? >> > >> > Thanks, >> > James >> > >> > --- >> > 2016-02-08 James Greenhalgh >> > >> > * gcc.dg/vect/vect-mask-store-move-1.c: Add dump option, and gate >> > check on x86_64/i?86. >> > > >