[PATCH] Typofixes and a trivial change

[PATCH] Typofixes and a trivial change

[Patrick Palka]

Hi,

This patch fixes a couple of typos in tree-vrp.c and one in
invoke.texi.  The patch also reorders the operands of an && condition in
infer_nonnull_range() under the assumption that operand_equal_p() is
much more costly than a simple TREE_TYPE() equality test.

Bootstrapped and regtested on x86_64-unknown-linux-gnu.

Cheers,
Patrick

---
 gcc/doc/invoke.texi | 2 +-
 gcc/gimple.c        | 4 ++--
 gcc/tree-vrp.c      | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 8004da8..d6580e4 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -4729,7 +4729,7 @@ Warn if a global function is defined without a previous declaration.
 Do so even if the definition itself provides a prototype.
 Use this option to detect global functions that are not declared in
 header files.  In C, no warnings are issued for functions with previous
-non-prototype declarations; use @option{-Wmissing-prototype} to detect
+non-prototype declarations; use @option{-Wmissing-prototypes} to detect
 missing prototypes.  In C++, no warnings are issued for function templates,
 or for inline functions, or for functions in anonymous namespaces.
 
diff --git a/gcc/gimple.c b/gcc/gimple.c
index 2a278e4..e60da00 100644
--- a/gcc/gimple.c
+++ b/gcc/gimple.c
@@ -2565,8 +2565,8 @@ infer_nonnull_range (gimple stmt, tree op, bool dereference, bool attribute)
 	    {
 	      for (unsigned int i = 0; i < gimple_call_num_args (stmt); i++)
 		{
-		  if (operand_equal_p (op, gimple_call_arg (stmt, i), 0)
-		      && POINTER_TYPE_P (TREE_TYPE (gimple_call_arg (stmt, i))))
+		  if (POINTER_TYPE_P (TREE_TYPE (gimple_call_arg (stmt, i)))
+		      && operand_equal_p (op, gimple_call_arg (stmt, i), 0))
 		    return true;
 		}
 	      return false;
diff --git a/gcc/tree-vrp.c b/gcc/tree-vrp.c
index 8a31e59..94d7419 100644
--- a/gcc/tree-vrp.c
+++ b/gcc/tree-vrp.c
@@ -4478,7 +4478,7 @@ debug_all_value_ranges (void)
 
 /* Given a COND_EXPR COND of the form 'V OP W', and an SSA name V,
    create a new SSA name N and return the assertion assignment
-   'V = ASSERT_EXPR <V, V OP W>'.  */
+   'N = ASSERT_EXPR <V, V OP W>'.  */
 
 static gimple
 build_assert_expr_for (tree cond, tree v)
@@ -6159,7 +6159,7 @@ process_assert_insertions (void)
     }
    else
     {
-      y = ASSERT_EXPR <y, x <= y>
+      y = ASSERT_EXPR <y, x >= y>
       x = y + 3
     }
 
-- 
1.9.2

Re: [PATCH] Typofixes and a trivial change

[Patrick Palka]

I forgot the ChangeLog entry:

2014-04-25  Patrick Palka  <patrick@parcs.ath.cx>

        * doc/invoke.texi: Fix typo.
        * tree-vrp.c: Fix typos.
        * gimple.c (infer_nonnull_range): Reorder operands of an &&
        condition.

Re: [PATCH] Typofixes and a trivial change

[Richard Biener]

On Fri, Apr 25, 2014 at 5:03 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> I forgot the ChangeLog entry:

Ok.

Thanks,
Richard.

> 2014-04-25  Patrick Palka  <patrick@parcs.ath.cx>
>
>         * doc/invoke.texi: Fix typo.
>         * tree-vrp.c: Fix typos.
>         * gimple.c (infer_nonnull_range): Reorder operands of an &&
>         condition.

Re: [PATCH] Typofixes and a trivial change

[Patrick Palka]

On Mon, Apr 28, 2014 at 4:57 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Fri, Apr 25, 2014 at 5:03 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
>> I forgot the ChangeLog entry:
>
> Ok.
>
> Thanks,
> Richard.

Thanks for reviewing.  May someone please commit this for me?  Thanks
in advance.

Re: [PATCH] Typofixes and a trivial change

[Richard Biener]

On Mon, Apr 28, 2014 at 2:44 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> On Mon, Apr 28, 2014 at 4:57 AM, Richard Biener
> <richard.guenther@gmail.com> wrote:
>> On Fri, Apr 25, 2014 at 5:03 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
>>> I forgot the ChangeLog entry:
>>
>> Ok.
>>
>> Thanks,
>> Richard.
>
> Thanks for reviewing.  May someone please commit this for me?  Thanks
> in advance.

Done.

Re: [PATCH] Typofixes and a trivial change

[Jeff Law]

On 04/25/14 09:03, Patrick Palka wrote:
> I forgot the ChangeLog entry:
>
> 2014-04-25  Patrick Palka  <patrick@parcs.ath.cx>
>
>          * doc/invoke.texi: Fix typo.
>          * tree-vrp.c: Fix typos.
>          * gimple.c (infer_nonnull_range): Reorder operands of an &&
>          condition.
This is fine.  Please install if you haven't done so already.

jeff