From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id B10F13858D28 for ; Tue, 18 Apr 2023 06:08:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B10F13858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4edb93139ddso1952036e87.0 for ; Mon, 17 Apr 2023 23:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681798132; x=1684390132; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XJ8mJ0r/es0cIMISh6kod6t3TWoA9Ie97TsMPLW/p3E=; b=IDu5BglKRSSG57zMxQhLKEk8UGGvlIUkfQgsqid2aSN42lKDPnX+4L2HkowXMtpq2J DV/MLH4Dhh1UYsVkt4BnVrUWx16cy5JHvjAb272gccnvaYaNd+gLdnEMgaHuDNNe6cla k8ejGaTbPcn0P8v1iX3RCWWZv4xu7ZE+HfFWftZud8yq1LvtbklHL59+flEiEZ677hJ8 t7AtL77qdncbZa6M1LeKZ8Nzj0WwA/99cDvM4vMqYpbPK23hC6J8JkRL5h/e/9MhTNlN lcfTP4OP9+xTcUZXIZQr/KNH9W+PirG3qiEJApdQwsjsr67vvMtEpOvOD/TPwJ/NSJoz vcdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681798132; x=1684390132; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XJ8mJ0r/es0cIMISh6kod6t3TWoA9Ie97TsMPLW/p3E=; b=OqC2jZ07k20e7TQNRqv1mMOqCr2cfgRZZ8xmO5sQqh+t8MBUCp51F73a3FGtRTPYe5 s9GqCiT6ijSUwX6J0b8JLntiaX+PT2lMFG9JSe8AW6Qz8EP2ZI7KNq0QO+WDyCYLbjYi N1DxftT4al1IAtkTJQbIL8Ku7ZyVIvfPMBN283fydbYdc9u71WSZsy9kxLIQ3wuBrcg8 30PdK02UI2uVJAaa0+QDB6CVpr5zpnc+NejUGNz5Cov39FB5pM9jypPxoCrAXnWcz3tU WPtI6/gmZ+wZ4kWLxaVF3ljXsnZbfHTP2yPyFMs4AB++Xw28jHunXdHCMdYb5chVA9DD PpJw== X-Gm-Message-State: AAQBX9cCAZ5LKAOR2/s1cKIyiUw2HmUOBMEPCEik6WvXIXRlH8AOSQQ4 HLvy3iRETtpvY4bLjzyJ/K8D2rAYXXszjhM2SaM= X-Google-Smtp-Source: AKy350Y6IOrOUnht+FKQ3vHGg/2i52PYnIKU8BcWPMbGUBxWGfcaJZl+NvF0qXjQXFyhCRWpOkHjWNir3yNe4TbJRF0= X-Received: by 2002:ac2:551b:0:b0:4d5:ca32:7bc5 with SMTP id j27-20020ac2551b000000b004d5ca327bc5mr2983203lfk.12.1681798131734; Mon, 17 Apr 2023 23:08:51 -0700 (PDT) MIME-Version: 1.0 References: <20230417163856.2253309-1-kevinl@rivosinc.com> In-Reply-To: <20230417163856.2253309-1-kevinl@rivosinc.com> From: Richard Biener Date: Tue, 18 Apr 2023 08:08:39 +0200 Message-ID: Subject: Re: [PATCH v3] vect: Verify that GET_MODE_UNITS is greater than one for vect_grouped_store_supported To: Kevin Lee Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 17, 2023 at 6:40=E2=80=AFPM Kevin Lee wro= te: > > This patch properly guards gcc_assert (multiple_p (m_full_nelts, > m_npatterns)) in vec_perm_indices indices (sel, 2, nelt) for VNx1 vectors= . > > Based on the feedback from Richard Biener and Richard Sandiford, > multiple_p has been used instead of maybe_lt to compare nelt with the > minimum size 2. > > Bootstrap and testing done on x86_64-pc-linux-gnu. Would this be ok for t= runk? Yes, this is OK. Thanks, Richard. > Patch V1: https://gcc.gnu.org/pipermail/gcc-patches/2023-March/614463.htm= l > Patch V2: https://gcc.gnu.org/pipermail/gcc-patches/2023-March/614700.htm= l > > Kevin Lee > gcc/ChangeLog: > > * tree-vect-data-refs.cc (vect_grouped_store_supported): Add new > condition > --- > gcc/tree-vect-data-refs.cc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc > index 8daf7bd7dd3..df393ba723d 100644 > --- a/gcc/tree-vect-data-refs.cc > +++ b/gcc/tree-vect-data-refs.cc > @@ -5399,6 +5399,8 @@ vect_grouped_store_supported (tree vectype, unsigne= d HOST_WIDE_INT count) > poly_uint64 nelt =3D GET_MODE_NUNITS (mode); > > /* The encoding has 2 interleaved stepped patterns. */ > + if(!multiple_p (nelt, 2)) > + return false; > vec_perm_builder sel (nelt, 2, 3); > sel.quick_grow (6); > for (i =3D 0; i < 3; i++) > -- > 2.25.1 >