From: Richard Biener <richard.guenther@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: Trevor Saunders <tbsaunde@tbsaunde.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2 04/N] Simplify usage of some TDF_* flags.
Date: Wed, 17 May 2017 12:37:00 -0000 [thread overview]
Message-ID: <CAFiYyc0BW64X1zLJDb5TLg_RZpQhHXYDyEYXRCUObx1_SFv3aA@mail.gmail.com> (raw)
In-Reply-To: <6b4fc53c-5ea5-96b6-d881-7dc363fd63ff@suse.cz>
On Tue, May 16, 2017 at 3:53 PM, Martin Liška <mliska@suse.cz> wrote:
> There's one another patch that merges some TDF_* flags that have
> very similar meaning and do not influence test-suite, because
> nobody is using them for scanning.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?
I think the patch removes too many TDF flags. For example
-fdump-tree-xxx-address
will then print not only addresses of gimple stmts but also of each
tree operand. The
change to dump_generic_node looks ok though.
Did you look who intoduced TDF_COMMENT? ISTR it was for some graph
dumping stuff.
Likewise the TDF_VERBOSE use in tree-cfg.c shouldn't be replaced with
-details but
dropped if you trop the flag.
Did you look at effects in dump-files at all?
Richard.
> Martin
next prev parent reply other threads:[~2017-05-17 12:36 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 8:14 [RFC][PATCH] Introduce -fdump*-folding Martin Liška
2017-05-03 8:20 ` Andrew Pinski
2017-05-03 10:16 ` Richard Biener
2017-05-04 9:23 ` Martin Liška
2017-05-04 10:41 ` Richard Biener
2017-05-04 12:06 ` Martin Liška
2017-05-05 10:44 ` [PATCH 1/N] Introduce dump_flags_t type and use it instead of int type Martin Liška
2017-05-05 11:50 ` Richard Biener
2017-05-06 15:04 ` Trevor Saunders
2017-05-12 13:01 ` [PATCH v2 01/N] Add default value for last argument of dump functions Martin Liška
2017-05-16 13:49 ` Richard Biener
2017-05-12 13:04 ` [PATCH v2 2/N] Introduce dump_flags_t type and use it instead of int, type Martin Liška
2017-05-16 13:50 ` Richard Biener
2017-05-16 14:56 ` Martin Liška
2017-05-17 7:55 ` Richard Biener
2017-05-17 9:06 ` Martin Liška
2017-05-18 13:37 ` Thomas Schwinge
2017-05-18 14:26 ` Martin Liška
2017-05-12 13:30 ` [PATCH v2 3/N] Transform TDF_{lang,tree,ipa,rtl} to dump_kind enum Martin Liška
2017-05-16 14:17 ` Richard Biener
2017-05-17 12:22 ` Richard Biener
2017-05-18 12:37 ` Martin Liška
2017-05-25 5:29 ` Martin Sebor
2017-05-25 9:56 ` Martin Liška
2017-05-25 10:58 ` Nathan Sidwell
2017-05-26 13:00 ` Richard Biener
2017-05-26 13:54 ` Martin Liška
2017-05-30 11:46 ` Richard Biener
2017-05-16 13:55 ` [PATCH v2 04/N] Simplify usage of some TDF_* flags Martin Liška
2017-05-17 12:37 ` Richard Biener [this message]
2017-05-18 12:58 ` Martin Liška
2017-05-24 21:23 ` Martin Liška
2017-05-26 11:46 ` Richard Biener
2017-05-24 11:04 ` [PATCH v2 05/N] Add -fdump*-folding suboption Martin Liška
2017-05-24 13:53 ` Richard Biener
2017-05-05 10:56 ` [PATCH 2/N] Add dump_flags_type<E> for handling of suboptions Martin Liška
2017-05-09 12:05 ` Martin Liška
2017-05-12 17:47 ` Martin Sebor
2017-05-15 6:52 ` Martin Sebor
2017-05-15 9:47 ` [RFC] Do we want hierarchical options & encapsulation in a class Martin Liška
2017-05-15 11:26 ` Nathan Sidwell
2017-05-15 12:24 ` Martin Liška
2017-05-15 11:46 ` Nathan Sidwell
2017-05-15 12:05 ` Martin Liška
2017-05-15 12:43 ` Nathan Sidwell
2017-05-15 13:50 ` Martin Liška
2017-05-15 14:13 ` Nathan Sidwell
2017-05-15 14:24 ` Martin Liška
2017-05-16 13:44 ` Richard Biener
2017-05-05 11:57 ` [RFC][PATCH] Introduce -fdump*-folding Richard Biener
2017-05-09 12:03 ` Martin Liška
2017-05-09 12:19 ` Richard Biener
2017-05-09 12:52 ` Martin Liška
2017-05-09 13:01 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc0BW64X1zLJDb5TLg_RZpQhHXYDyEYXRCUObx1_SFv3aA@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=tbsaunde@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).