From: Richard Biener <richard.guenther@gmail.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@cavium.com>
Cc: Jeff Law <law@redhat.com>,
"marc.glisse@inria.fr" <marc.glisse@inria.fr>,
"ramana.radhakrishnan@foss.arm.com"
<ramana.radhakrishnan@foss.arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR31096
Date: Wed, 23 Nov 2016 09:56:00 -0000 [thread overview]
Message-ID: <CAFiYyc0BrOfArunzw8G_27AyR_rw-WxdQ7T2rZdh5cn=Ax3A9w@mail.gmail.com> (raw)
In-Reply-To: <CO2PR07MB26943863309FC90F3CB2161983BB0@CO2PR07MB2694.namprd07.prod.outlook.com>
On Fri, Nov 11, 2016 at 11:19 AM, Hurugalawadi, Naveen
<Naveen.Hurugalawadi@cavium.com> wrote:
> Hi,
>
> Sorry for a very late reply as the mail was missed or overlooked.
>
>>> could now move the test tree_expr_nonzero_p next to
>>> tree_expr_nonnegative_p (it is redundant for the last case).
>
> Done.
>
>>> Often just a comment can really help here.
>
> Comments updated as per the suggestion
>
>>> when C is zero and verify this transformation doesn't fire on that case.
>
> Updated test to check with zero.
>
>>> verifying that the operand orders change appropriately when dealing
>>> with a negative constant.
>
> Done.
>
>>> verify nothing happens with floating point or vector types.
>
> Done.
>
> Please review the patch and let me know if any modifications are required.
> Regression tested on X86 and AArch64.
Ok with using wi::neg_p (@1, TYPE_SIGN (TREE_TYPE (@1))) instead of wi::lt_p.
Thanks,
Richard.
> Thanks,
> Naveen
>
> 2016-11-11 Naveen H.S <Naveen.Hurugalawadi@caviumnetworks.com>
> gcc
> * fold-const.c (tree_expr_nonzero_p) : Make non-static.
> * fold-const.h (tree_expr_nonzero_p) : Declare.
> * match.pd (cmp (mult:c @0 @1) (mult:c @2 @1) : New Pattern.
> * match.pd (cmp (mult:c @0 @1) (mult:c @2 @1) : New Pattern.
> gcc/testsuite
> * gcc.dg/pr31096.c: New testcase.
> * gcc.dg/pr31096-1.c: New testcase.
next prev parent reply other threads:[~2016-11-23 9:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 9:19 Hurugalawadi, Naveen
2016-03-31 9:32 ` Marc Glisse
2016-04-05 9:09 ` Hurugalawadi, Naveen
2016-04-05 9:17 ` Marc Glisse
2016-04-07 11:04 ` Hurugalawadi, Naveen
2016-04-07 11:28 ` Marc Glisse
2016-04-12 8:25 ` Hurugalawadi, Naveen
2016-04-12 9:33 ` Marc Glisse
2016-04-14 6:46 ` Hurugalawadi, Naveen
2016-04-15 16:25 ` Marc Glisse
2016-07-13 20:35 ` Jeff Law
2016-11-11 10:20 ` Hurugalawadi, Naveen
2016-11-23 9:56 ` Richard Biener [this message]
2016-03-31 9:35 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0BrOfArunzw8G_27AyR_rw-WxdQ7T2rZdh5cn=Ax3A9w@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=Naveen.Hurugalawadi@cavium.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=marc.glisse@inria.fr \
--cc=ramana.radhakrishnan@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).