From: Richard Biener <richard.guenther@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Richard Biener <rguenther@suse.de>,
Gerald Pfeifer <gerald@pfeifer.com>,
Dominique Dhumieres <dominiq@lps.ens.fr>,
gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] Fix PR54659, include gmp.h from system.h
Date: Thu, 27 Dec 2012 16:11:00 -0000 [thread overview]
Message-ID: <CAFiYyc0BsusR+zCGfBhg=Aaaazoh+20CkmiC6WS6XddXUB6hSw@mail.gmail.com> (raw)
In-Reply-To: <m2txretklu.fsf@linux-m68k.org>
On Sat, Dec 22, 2012 at 12:03 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Richard Biener <richard.guenther@gmail.com> writes:
>
>> On Sat, Dec 22, 2012 at 10:49 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> Richard Biener <rguenther@suse.de> writes:
>>>
>>>> (I suppose somehow gmp.h is pulled in configure tests?)
>>>
>>> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
>>> #include "ansidecl.h"
>>> #include "system.h"
>>> #ifdef HAVE_SYS_RESOURCE_H
>>> #include <sys/resource.h>
>>> #endif
>>> ]], [[rlim_t l = 0;]])],[],[AC_DEFINE([rlim_t],[long],
>>> [Define to `long' if <sys/resource.h> doesn't define.])])
>>
>> Huh - looks at least bogus to not include config.h here, no?
>
> config.h uses auto-host.h which doesn't exist yet, it's created by
> configure. All already known config defs are set in conftest.c (see
> config.log).
I still question the inclusion of system.h here - why is that needed, or
why isn't this either a copy of the relevant piece of system.h, or - _just_
including system.h and nothing else ... in fact system.h already includes
sys/resource.h the way above.
Richard.
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
next prev parent reply other threads:[~2012-12-27 16:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 16:26 Dominique Dhumieres
2012-12-21 19:03 ` Ian Lance Taylor
2012-12-21 20:06 ` Dominique Dhumieres
2012-12-21 21:20 ` Dominique Dhumieres
2012-12-22 1:56 ` Gerald Pfeifer
2012-12-22 8:55 ` Richard Biener
2012-12-22 9:50 ` Andreas Schwab
2012-12-22 10:43 ` Richard Biener
2012-12-22 10:52 ` Dominique Dhumieres
2012-12-22 11:14 ` Richard Sandiford
2012-12-22 11:03 ` Andreas Schwab
2012-12-27 16:11 ` Richard Biener [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-21 13:15 Richard Biener
2012-12-21 13:17 ` Jakub Jelinek
2012-12-21 16:00 ` Ian Lance Taylor
2013-01-08 18:50 ` H.J. Lu
2013-01-09 2:31 ` Iyer, Balaji V
2013-01-09 8:36 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0BsusR+zCGfBhg=Aaaazoh+20CkmiC6WS6XddXUB6hSw@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).