From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-334688-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 15019 invoked by alias); 27 Dec 2012 16:11:23 -0000
Received: (qmail 15003 invoked by uid 22791); 27 Dec 2012 16:11:21 -0000
X-SWARE-Spam-Status: No, hits=-4.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-wg0-f52.google.com (HELO mail-wg0-f52.google.com) (74.125.82.52)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Dec 2012 16:11:11 +0000
Received: by mail-wg0-f52.google.com with SMTP id 12so4506177wgh.7        for <gcc-patches@gcc.gnu.org>; Thu, 27 Dec 2012 08:11:09 -0800 (PST)
MIME-Version: 1.0
Received: by 10.194.76.99 with SMTP id j3mr49917821wjw.47.1356624669862; Thu, 27 Dec 2012 08:11:09 -0800 (PST)
Received: by 10.194.179.130 with HTTP; Thu, 27 Dec 2012 08:11:09 -0800 (PST)
In-Reply-To: <m2txretklu.fsf@linux-m68k.org>
References: <20121221162631.46F3A3BE1B@mailhost.lps.ens.fr>	<alpine.LNX.2.00.1212211553540.2358@tuna.site>	<a01a5fad-6ccb-47e4-963c-3c9de69f6232@email.android.com>	<m2623uv2kb.fsf@linux-m68k.org>	<CAFiYyc1+n59wHrnU_Qr0fZxfCk-W69Ma=w=zuurMsbybYaDLbA@mail.gmail.com>	<m2txretklu.fsf@linux-m68k.org>
Date: Thu, 27 Dec 2012 16:11:00 -0000
Message-ID: <CAFiYyc0BsusR+zCGfBhg=Aaaazoh+20CkmiC6WS6XddXUB6hSw@mail.gmail.com>
Subject: Re: [PATCH] Fix PR54659, include gmp.h from system.h
From: Richard Biener <richard.guenther@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Richard Biener <rguenther@suse.de>, Gerald Pfeifer <gerald@pfeifer.com>, 	Dominique Dhumieres <dominiq@lps.ens.fr>, gcc-patches@gcc.gnu.org, 	Jakub Jelinek <jakub@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-12/txt/msg01430.txt.bz2

On Sat, Dec 22, 2012 at 12:03 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Richard Biener <richard.guenther@gmail.com> writes:
>
>> On Sat, Dec 22, 2012 at 10:49 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> Richard Biener <rguenther@suse.de> writes:
>>>
>>>> (I suppose somehow gmp.h is pulled in configure tests?)
>>>
>>> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
>>> #include "ansidecl.h"
>>> #include "system.h"
>>> #ifdef HAVE_SYS_RESOURCE_H
>>> #include <sys/resource.h>
>>> #endif
>>> ]], [[rlim_t l = 0;]])],[],[AC_DEFINE([rlim_t],[long],
>>> [Define to `long' if <sys/resource.h> doesn't define.])])
>>
>> Huh - looks at least bogus to not include config.h here, no?
>
> config.h uses auto-host.h which doesn't exist yet, it's created by
> configure.  All already known config defs are set in conftest.c (see
> config.log).

I still question the inclusion of system.h here - why is that needed, or
why isn't this either a copy of the relevant piece of system.h, or - _just_
including system.h and nothing else ... in fact system.h already includes
sys/resource.h the way above.

Richard.

> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."