* [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used @ 2015-04-23 8:29 Ludovic Courtès 2015-05-18 13:41 ` Ramana Radhakrishnan 0 siblings, 1 reply; 8+ messages in thread From: Ludovic Courtès @ 2015-04-23 8:29 UTC (permalink / raw) To: gcc-patches [-- Attachment #1: Type: text/plain, Size: 354 bytes --] As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>. Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.) Tested on armhf-linux-gnu (armv7.) gcc/ 2015-04-23 Ludovic Courtès <ludo@gnu.org> PR 65711 * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move '-dynamic-linker' within %{!shared: ...}. [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: Type: text/x-patch, Size: 458 bytes --] --- gcc-4.8.4/gcc/config/arm/linux-elf.h 2015-04-08 20:31:20.376900478 +0200 +++ gcc-4.8.4/gcc/config/arm/linux-elf.h 2015-04-08 20:31:36.437014437 +0200 @@ -65,7 +65,7 @@ %{symbolic:-Bsymbolic} \ %{!static: \ %{rdynamic:-export-dynamic} \ - -dynamic-linker " GNU_USER_DYNAMIC_LINKER "} \ + %{!shared:-dynamic-linker " GNU_USER_DYNAMIC_LINKER "}} \ -X \ %{mbig-endian:-EB} %{mlittle-endian:-EL}" \ SUBTARGET_EXTRA_LINK_SPEC ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used 2015-04-23 8:29 [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used Ludovic Courtès @ 2015-05-18 13:41 ` Ramana Radhakrishnan 2015-05-18 19:48 ` Ludovic Courtès 2015-06-23 9:31 ` Ludovic Courtès 0 siblings, 2 replies; 8+ messages in thread From: Ramana Radhakrishnan @ 2015-05-18 13:41 UTC (permalink / raw) To: Ludovic Courtès; +Cc: gcc-patches, Richard Biener On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote: > As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>. > > Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.) > OK for trunk. This is also ok for all release branches if no objections in 24 hours. Sorry about the delayed review. regards Ramana > Tested on armhf-linux-gnu (armv7.) > > gcc/ > 2015-04-23 Ludovic Courtès <ludo@gnu.org> > > PR 65711 > * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move > '-dynamic-linker' within %{!shared: ...}. > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used 2015-05-18 13:41 ` Ramana Radhakrishnan @ 2015-05-18 19:48 ` Ludovic Courtès 2015-06-23 9:30 ` Richard Biener 2015-06-23 9:31 ` Ludovic Courtès 1 sibling, 1 reply; 8+ messages in thread From: Ludovic Courtès @ 2015-05-18 19:48 UTC (permalink / raw) To: Ramana Radhakrishnan; +Cc: ramrad01, gcc-patches, Richard Biener Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis: > On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote: >> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>. >> >> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.) >> > > OK for trunk. This is also ok for all release branches if no > objections in 24 hours. OK, thank you. I haven’t applied for write-after-approval so perhaps you should commit it yourself? Ludo’. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used 2015-05-18 19:48 ` Ludovic Courtès @ 2015-06-23 9:30 ` Richard Biener 2015-06-23 10:10 ` Ludovic Courtès 0 siblings, 1 reply; 8+ messages in thread From: Richard Biener @ 2015-06-23 9:30 UTC (permalink / raw) To: Ludovic Courtès Cc: Ramana Radhakrishnan, ramrad01, gcc-patches, Richard Biener On Mon, May 18, 2015 at 9:09 PM, Ludovic Courtès <ludo@gnu.org> wrote: > Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis: > >> On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote: >>> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>. >>> >>> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.) >>> >> >> OK for trunk. This is also ok for all release branches if no >> objections in 24 hours. > > OK, thank you. > > I haven’t applied for write-after-approval so perhaps you should commit > it yourself? So you just committed to the already closed 4.8 branch. Please always check gcc.gnu.org/ for branch status. Richard. > Ludo’. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used 2015-06-23 9:30 ` Richard Biener @ 2015-06-23 10:10 ` Ludovic Courtès 0 siblings, 0 replies; 8+ messages in thread From: Ludovic Courtès @ 2015-06-23 10:10 UTC (permalink / raw) To: Richard Biener Cc: Ramana Radhakrishnan, ramrad01, gcc-patches, Richard Biener Richard Biener <richard.guenther@gmail.com> skribis: > On Mon, May 18, 2015 at 9:09 PM, Ludovic Courtès <ludo@gnu.org> wrote: >> Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis: >> >>> On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote: >>>> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>. >>>> >>>> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.) >>>> >>> >>> OK for trunk. This is also ok for all release branches if no >>> objections in 24 hours. >> >> OK, thank you. >> >> I haven’t applied for write-after-approval so perhaps you should commit >> it yourself? > > So you just committed to the already closed 4.8 branch. Please always > check gcc.gnu.org/ for branch status. My bad, sorry about that! Ludo’. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used 2015-05-18 13:41 ` Ramana Radhakrishnan 2015-05-18 19:48 ` Ludovic Courtès @ 2015-06-23 9:31 ` Ludovic Courtès 2015-06-23 9:38 ` Jakub Jelinek 1 sibling, 1 reply; 8+ messages in thread From: Ludovic Courtès @ 2015-06-23 9:31 UTC (permalink / raw) To: ramrad01; +Cc: gcc-patches, Richard Biener Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis: > On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote: >> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>. >> >> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.) >> > > OK for trunk. This is also ok for all release branches if no > objections in 24 hours. [...] >> gcc/ >> 2015-04-23 Ludovic Courtès <ludo@gnu.org> >> >> PR 65711 >> * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move >> '-dynamic-linker' within %{!shared: ...}. Committed to gcc-4_8-branch, gcc-4_9-branch, gcc-5-branch, and trunk. Please let me know if there’s anything I missed. Thanks, Ludo’. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used 2015-06-23 9:31 ` Ludovic Courtès @ 2015-06-23 9:38 ` Jakub Jelinek 2015-06-23 12:29 ` Ludovic Courtès 0 siblings, 1 reply; 8+ messages in thread From: Jakub Jelinek @ 2015-06-23 9:38 UTC (permalink / raw) To: Ludovic Courtès; +Cc: ramrad01, gcc-patches, Richard Biener On Tue, Jun 23, 2015 at 11:30:25AM +0200, Ludovic Courtès wrote: > Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis: > > > On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote: > >> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>. > >> > >> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I havenât checked.) > >> > > > > OK for trunk. This is also ok for all release branches if no > > objections in 24 hours. > > [...] > > >> gcc/ > >> 2015-04-23 Ludovic Courtès <ludo@gnu.org> > >> > >> PR 65711 > >> * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move > >> '-dynamic-linker' within %{!shared: ...}. > > Committed to gcc-4_8-branch, gcc-4_9-branch, gcc-5-branch, and trunk. > Please let me know if thereâs anything I missed. See richi's mail. 4.8 branch has already been closed, and 4.9 branch is frozen, so you should have asked for RM permission. Also, in the ChangeLog entries, one should write it in the form PR component/bugno, so PR target/65711 in your case. Jakub ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used 2015-06-23 9:38 ` Jakub Jelinek @ 2015-06-23 12:29 ` Ludovic Courtès 0 siblings, 0 replies; 8+ messages in thread From: Ludovic Courtès @ 2015-06-23 12:29 UTC (permalink / raw) To: Jakub Jelinek; +Cc: ramrad01, gcc-patches, Richard Biener Jakub Jelinek <jakub@redhat.com> skribis: > On Tue, Jun 23, 2015 at 11:30:25AM +0200, Ludovic Courtès wrote: >> Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis: >> >> > On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote: >> >> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>. >> >> >> >> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.) >> >> >> > >> > OK for trunk. This is also ok for all release branches if no >> > objections in 24 hours. >> >> [...] >> >> >> gcc/ >> >> 2015-04-23 Ludovic Courtès <ludo@gnu.org> >> >> >> >> PR 65711 >> >> * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move >> >> '-dynamic-linker' within %{!shared: ...}. >> >> Committed to gcc-4_8-branch, gcc-4_9-branch, gcc-5-branch, and trunk. >> Please let me know if there’s anything I missed. > > See richi's mail. 4.8 branch has already been closed, and 4.9 branch > is frozen, so you should have asked for RM permission. Noted. That part of the process was not clear to me, apologies. > Also, in the ChangeLog entries, one should write it in the form > PR component/bugno, > so > PR target/65711 > in your case. OK. Thanks, Ludo’. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-06-23 12:22 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-04-23 8:29 [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used Ludovic Courtès 2015-05-18 13:41 ` Ramana Radhakrishnan 2015-05-18 19:48 ` Ludovic Courtès 2015-06-23 9:30 ` Richard Biener 2015-06-23 10:10 ` Ludovic Courtès 2015-06-23 9:31 ` Ludovic Courtès 2015-06-23 9:38 ` Jakub Jelinek 2015-06-23 12:29 ` Ludovic Courtès
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).