From: Richard Biener <richard.guenther@gmail.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] tree-object-size: Avoid unnecessary processing of __builtin_object_size
Date: Mon, 18 Oct 2021 11:57:19 +0200 [thread overview]
Message-ID: <CAFiYyc0EYK7t198c2nqXauhrhgXgoqPCy=6zaTrp8v5rqYWCuQ@mail.gmail.com> (raw)
In-Reply-To: <20211018042438.803964-1-siddhesh@gotplt.org>
On Mon, Oct 18, 2021 at 6:25 AM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
>
> This is a minor cleanup to bail out early if the result of
> __builtin_object_size is not assigned to anything and avoid initializing
> the object size arrays.
OK.
Thanks,
Richard.
> gcc/ChangeLog:
>
> * tree-object-size (object_sizes_execute): Consolidate LHS null
> check and do it early.
>
> Signed-off-by: Siddhesh Poyarekar <siddhesh@gotplt.org>
> ---
> gcc/tree-object-size.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/gcc/tree-object-size.c b/gcc/tree-object-size.c
> index 6a4dc724f34..46a976dfe10 100644
> --- a/gcc/tree-object-size.c
> +++ b/gcc/tree-object-size.c
> @@ -1298,6 +1298,10 @@ object_sizes_execute (function *fun, bool insert_min_max_p)
> if (!gimple_call_builtin_p (call, BUILT_IN_OBJECT_SIZE))
> continue;
>
> + tree lhs = gimple_call_lhs (call);
> + if (!lhs)
> + continue;
> +
> init_object_sizes ();
>
> /* If insert_min_max_p, only attempt to fold
> @@ -1312,11 +1316,9 @@ object_sizes_execute (function *fun, bool insert_min_max_p)
> {
> unsigned HOST_WIDE_INT object_size_type = tree_to_uhwi (ost);
> tree ptr = gimple_call_arg (call, 0);
> - tree lhs = gimple_call_lhs (call);
> if ((object_size_type == 1 || object_size_type == 3)
> && (TREE_CODE (ptr) == ADDR_EXPR
> - || TREE_CODE (ptr) == SSA_NAME)
> - && lhs)
> + || TREE_CODE (ptr) == SSA_NAME))
> {
> tree type = TREE_TYPE (lhs);
> unsigned HOST_WIDE_INT bytes;
> @@ -1339,10 +1341,6 @@ object_sizes_execute (function *fun, bool insert_min_max_p)
> continue;
> }
>
> - tree lhs = gimple_call_lhs (call);
> - if (!lhs)
> - continue;
> -
> result = gimple_fold_stmt_to_constant (call, do_valueize);
> if (!result)
> {
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-10-18 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 4:24 Siddhesh Poyarekar
2021-10-18 9:57 ` Richard Biener [this message]
2021-10-18 10:12 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0EYK7t198c2nqXauhrhgXgoqPCy=6zaTrp8v5rqYWCuQ@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).