public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: Avoid uninit var in pr60510.f [PR111427]
@ 2023-09-27  5:37 Kewen.Lin
  2023-09-27  7:30 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Kewen.Lin @ 2023-09-27  5:37 UTC (permalink / raw)
  To: GCC Patches; +Cc: Richard Biener, Peter Bergner

Hi,

The uninitialized variable a in pr60510.f can cause some
random failures as exposed in PR111427, see the details
there.  This patch is to make it initialized accordingly.

As verified, it can fix the reported -m32 failures on
P7 and P8 BE.  It's also tested well on powerpc64-linux-gnu
P9 and powerpc64le-linux-gnu P9 and P10.

Is it ok for trunk?

BR,
Kewen
-----

	PR testsuite/111427

gcc/testsuite/ChangeLog:

	* gfortran.dg/vect/pr60510.f (test): Init variable a.
---
 gcc/testsuite/gfortran.dg/vect/pr60510.f | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/gfortran.dg/vect/pr60510.f b/gcc/testsuite/gfortran.dg/vect/pr60510.f
index ecd50dd5586..6cae82acece 100644
--- a/gcc/testsuite/gfortran.dg/vect/pr60510.f
+++ b/gcc/testsuite/gfortran.dg/vect/pr60510.f
@@ -17,6 +17,7 @@

       program test
       real*8 x(1024),y(1024),a
+      a = 0.0
       do i=1,1024
         x(i) = i
         y(i) = i+1
--
2.35.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] testsuite: Avoid uninit var in pr60510.f [PR111427]
  2023-09-27  5:37 [PATCH] testsuite: Avoid uninit var in pr60510.f [PR111427] Kewen.Lin
@ 2023-09-27  7:30 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2023-09-27  7:30 UTC (permalink / raw)
  To: Kewen.Lin; +Cc: GCC Patches, Peter Bergner

On Wed, Sep 27, 2023 at 7:39 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> Hi,
>
> The uninitialized variable a in pr60510.f can cause some
> random failures as exposed in PR111427, see the details
> there.  This patch is to make it initialized accordingly.
>
> As verified, it can fix the reported -m32 failures on
> P7 and P8 BE.  It's also tested well on powerpc64-linux-gnu
> P9 and powerpc64le-linux-gnu P9 and P10.
>
> Is it ok for trunk?

OK.

Richard.

> BR,
> Kewen
> -----
>
>         PR testsuite/111427
>
> gcc/testsuite/ChangeLog:
>
>         * gfortran.dg/vect/pr60510.f (test): Init variable a.
> ---
>  gcc/testsuite/gfortran.dg/vect/pr60510.f | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gfortran.dg/vect/pr60510.f b/gcc/testsuite/gfortran.dg/vect/pr60510.f
> index ecd50dd5586..6cae82acece 100644
> --- a/gcc/testsuite/gfortran.dg/vect/pr60510.f
> +++ b/gcc/testsuite/gfortran.dg/vect/pr60510.f
> @@ -17,6 +17,7 @@
>
>        program test
>        real*8 x(1024),y(1024),a
> +      a = 0.0
>        do i=1,1024
>          x(i) = i
>          y(i) = i+1
> --
> 2.35.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-27  7:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-27  5:37 [PATCH] testsuite: Avoid uninit var in pr60510.f [PR111427] Kewen.Lin
2023-09-27  7:30 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).