From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id D654A3858419 for ; Mon, 22 Jan 2024 07:44:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D654A3858419 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D654A3858419 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705909443; cv=none; b=dqVjvTCffXG8AUdQjX70L93DbXnz9Xo3PFi/IatBHnMc8NfQOqDPiRJJEJjPZEOxjPix7E1G94J7LchFqevMROghk1DCC6SFCXvvvhglGeMs3YGXE9+/1zg5z4kIKtLVrst2QX+3vVh0HZJe7dQGmkHx+Lh1W0M5tu5R0PtA5MM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705909443; c=relaxed/simple; bh=j760G/BwOMK3Nl1BI1LuhAKwtkA2gBeh+Hq2aP6AW6I=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=dEJjAf/qn1ESq2uPAi4bWCb+hh1Y2AOgX9X/7a7ADOHFvOBBsTfrgIcOfJvVW2RCOJJLG8pOouMN4nLTRdBVFmo60x9viycugecgHPG9oERD641wLLE0ooppmgmDWAHCqdTAxmz9Dh+hU4FOWPnZR86O6CVXI0z0kwattC9IzEo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50e80d14404so3357521e87.1 for ; Sun, 21 Jan 2024 23:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705909440; x=1706514240; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fo1LyKCdomHRAIcjYpFOqheAbaDL4J9KjVv8YOFnXfw=; b=hrWetkJP230rT/BZaAPQFPKTiX5yH5tBIhph0WewUBrOWb2/09IB1VKBHSjKt+kcI1 s1RHrebr7aYyNwinzElc544DfuFzzS3SRhdDEgPKXG/EGcCWzBFe30YsiqqHoo1imbHe 416hUWYWhr2ZYa/mGoX3bLuWjMffCkXw+DKQHxQg/xbMyhiBshMjZv4cCy3Zn/nQbYw4 0Gf9Si6BPcAWbWyUHxneSFEzQt0QXeduTpKemZ8v4QJgn6t13dyIWGYPS4q+HvSvCOiW IAHZufvJ+cUUwGdNvxhbJDgWPXNVoEpeTUGhhb/lqRaEDIayhoFrVU+4w2BL4lcKBUXn kuWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705909440; x=1706514240; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fo1LyKCdomHRAIcjYpFOqheAbaDL4J9KjVv8YOFnXfw=; b=xEYUUYRRSi1jMXFAuWxlIivoAzuk6CacV64k2cUQEEvF0RRCcmcv6zbqT4o4/hcYdg rp9lzrvZFnox71aCCV9/SmZoY76KnMSqGfHkb3mGDGQ/OrPzzAtcxm49854fdvMr6EAR 0TxVAcDDlUaTRUQ3JIXy/X5+rizyb3mHKPJRqxL2vg4wAivyICMWE1Rix3hWXajGp3PC WRl49pT5tDzF5CUX27E8C/qLArpg8X1rIMx1SxVvWVcnWyqVfZBVMUT1xgsInjYqth0D AGUfGgpr6cNyS64JqVKtxcLXA9D1U/Q3Sc6xqcDQI4cvR/PUid2b+7U0qriqmElcLBFy s7GA== X-Gm-Message-State: AOJu0YwAdmRkXmxHPIVh/7xTEPW8TnP+7RyZ5sIN4tPdXmybD0pFNtAq 0BrWKwUqgLJGTJJuhowT1aVAdTL/ws1dsAwC4THEIpZo4z/iS46kxNbDW5ooeoYDoftjfg7mR1n UOB/zS/+9+6FeB1rLUj1fT3zy68Y= X-Google-Smtp-Source: AGHT+IF2lJhnU9zz4bM/nCJr8Bj+m+RlxynG/AvM90LMLtbvgObVyD1kM6SThcabUHyDlIA2YIwOFg5RjOk3Cxs3IAw= X-Received: by 2002:a05:6512:556:b0:50e:7b7c:8591 with SMTP id h22-20020a056512055600b0050e7b7c8591mr3110975lfl.25.1705909440211; Sun, 21 Jan 2024 23:44:00 -0800 (PST) MIME-Version: 1.0 References: <3a1d7856-47fd-4e00-8b08-1e985cac6130@baylibre.com> In-Reply-To: <3a1d7856-47fd-4e00-8b08-1e985cac6130@baylibre.com> From: Richard Biener Date: Mon, 22 Jan 2024 08:42:44 +0100 Message-ID: Subject: Re: [patch][gcn] mkoffload: Fix linking with "-g"; fix file deletion; improve diagnostic [PR111966] To: Tobias Burnus Cc: gcc-patches , Andrew Stubbs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jan 19, 2024 at 9:08=E2=80=AFPM Tobias Burnus wrote: > > This patch fixes PR111966, i.e. when compiling offloaded code with "-g" > but without "-march=3D", mkoffload created a file with e_flags set to > gfx803/fiji as architecture - while all other files used gfx900, which > the linker did not like. > > Reason: When the default was changed, this flag was missed. When passing > -march=3D... instead of relying on the default, it works. > > Additionally, it fixed a bug with dangling pointers and multiple > deletion attempts for the same file, leading normally only to the > accumulation of /tmp/cc*.mkoffload.dbg.o files. > > And, finally, when building with a recent GCC; it warned about missing > %<...%> or %qs quotes. I added a couple to reduce the number of warnings. > > OK for mainline? =E2=80=94 I think the /tmp/cc*.mkoffload.dbg.o part of t= he > patch could also be backported to GCC 13 (and 12) if deemed to be useful. OK for trunk > Tobias