From: Richard Biener <richard.guenther@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: fixed-point/composite-type: add -Wno-array-parameter
Date: Fri, 1 Apr 2022 08:16:48 +0200 [thread overview]
Message-ID: <CAFiYyc0FKp22=H+wB_6AM2ESCxC57wG-fQSBFkX=3KNO1E5-RA@mail.gmail.com> (raw)
In-Reply-To: <or5yntle7a.fsf@lxoliva.fsfla.org>
On Fri, Apr 1, 2022 at 4:40 AM Alexandre Oliva via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> On machines that support fixed-point and the test runs, it's failing
> because of warnings issued by -Warray-parameter=[12], enabled by
> -Wall.
>
> The warnings state "mismatch in bound 1 of argument 1 declared as...",
> referring to the redeclaration of f2_##NAME. The purpose of the
> redeclaration is not clear to me.
>
> It doesn't look like the test intends to catch mismatches between
> parameter's array lengths, despite the explicit array bound and the
> incompatible calls, so I'm adding -Wno-array-parameter to avoid this
> distraction and enable the test to pass.
>
> Tested on arm-eabi, where the patch removes the excess errors fail. Ok
> to install?
Sounds reasonable. OK.
Richard.
>
> for gcc/testsuite/ChangeLog
>
> * gcc.dg/fixed-point/composite-type.c: Add -Wno-array-parameter.
> ---
> gcc/testsuite/gcc.dg/fixed-point/composite-type.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/fixed-point/composite-type.c b/gcc/testsuite/gcc.dg/fixed-point/composite-type.c
> index 026bdaf564420..59351ff09b390 100644
> --- a/gcc/testsuite/gcc.dg/fixed-point/composite-type.c
> +++ b/gcc/testsuite/gcc.dg/fixed-point/composite-type.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-std=gnu99 -O -Wall -Wno-unused -ftrack-macro-expansion=0" } */
> +/* { dg-options "-std=gnu99 -O -Wall -Wno-unused -ftrack-macro-expansion=0 -Wno-array-parameter" } */
>
> /* C99 6.2.7: Compatible type and composite type. */
>
>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
prev parent reply other threads:[~2022-04-01 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 2:39 Alexandre Oliva
2022-04-01 6:16 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0FKp22=H+wB_6AM2ESCxC57wG-fQSBFkX=3KNO1E5-RA@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).