From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 0C3343858D1E for ; Thu, 22 Feb 2024 08:56:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C3343858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C3343858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708592217; cv=none; b=Uucs7k/B/9ayb3TyivlaHXN+gVpjP+6jYrci8f/vwPqAnPJLzmmvFk0EFoMY1BOo/LN1SBwl2T/RvS1uvRRCj3chuS0aIi2F+UpGYOYz/UfIMLiXPys2mRCc7DtvRMRaEUCs9rAK76hYndjbrD4w78mlZXZWrGgWHUxuht54fcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708592217; c=relaxed/simple; bh=WPsNzsJ22EqKWEi2TaKvG0nAzwm9mtcTwXtLkkKTC7c=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Ap1LQtYbTD8AG+vi8dQGA6vlhFoEUwD0m3QpGmrQS8/UAcRxt3rhZivXNkiqRNleHzPiOJa8Otv+DM5ljp7Fwz/Tcy+NTosbIOyic4UjxRzNvUHO4Y36yda2WNYsV7Mas8tpNgpvDaPFek5aIIBVAPl9vTLPGUO5Amp9l54/C4M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2d1094b549cso108230951fa.3 for ; Thu, 22 Feb 2024 00:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708592213; x=1709197013; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=74FMuPwyud+dg1jBP2Yb+V+8AIqZCE3lGp3j82TtxZ0=; b=WXMzltE7PYc9IHkWd/qbW7huC8poGt1jylHaap8O0Rdtm+xyCLQ7h56Su0wPaJKNgi sz7E0nEscpPrRajApDUC20z6YNZk2iZ4cadtEx4XM0Ud5vjMsF8/T5A3hYeGxur2zx4a HCFiFaqj9bAkfVxxqrXsFCAlPogc/UNeZuEOT3j5wZVZiiBdqFxMf0o3xZsujfxfaEiP VJATA0KpH2KK9z/SqK6jLHii0YddpEPUj0gUTcoGnlyAiQAJYhE178jdWfyEn4P32llo YIBCH3SQtKa1slvorjkFaJMPpL1afPAcZNx3i8lsy8GOLH7w9EvXc7gwlT6rVpgqUPc+ 7iuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708592213; x=1709197013; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=74FMuPwyud+dg1jBP2Yb+V+8AIqZCE3lGp3j82TtxZ0=; b=Dd7mzcEK60lZ8sWQKnZd6RWBq7yFIAjTVx05obDslDtUzIy9tJo0P8bWViP2vu+EiH z6W5FbCBHuHl/Hg7KzbsGIJQQFIZ+rxl6QFTmwb35l4e0QuaqkaNqTl6TuVvTty2QMti oJsKoM89w+FA7USQWEY0Voy3iAL5rWkvzIoshSxYNPY96ozMWkZ0A/KVDjy4keYXgNJe 99avYkmuzO9pRgMOAonLoZ2AyVA9sB2FMOXnmZFoXgMmMYZTOpssmLO6h3xSIvV35brk QdWJsmQnI1cCJMErVpvDyuPWLh3va8bMjNPbPG8n2fI2Kdfz4CSPiWug+ZYWBNdUA265 l4qg== X-Forwarded-Encrypted: i=1; AJvYcCVqhj8ykv2DmDvvVfqGbxk1DjyLa3+pSgFi0pQlDGntQAwyrJ5i2Kt3is4xVgPJzkirHTgOy73yyb+uYuChy7xMXPKZUC3tYA== X-Gm-Message-State: AOJu0YwfA+NXIRg0lY4Zs6R4Av4tGGnp0um0keT8B6GGJmiep1AhLxVc 55qr8o5gScEvjRAVB0qUTOLKmWAqeqxjUIGTRq4nqhMBahrHpxMgeCLDL/ncS5gN2oLeYKYMjmC z3voXtr8ayhgTn6sKS6dOy7E+aE8= X-Google-Smtp-Source: AGHT+IGorFroRkVytiliyP2Q6NG0V+NxycSv6ECYEPZRgU6xM5zVXWZOI3xaMf9jPjFAX4LGIHVF0vLyAgYWCACCo8U= X-Received: by 2002:a2e:9848:0:b0:2d2:414c:751e with SMTP id e8-20020a2e9848000000b002d2414c751emr6179865ljj.47.1708592213131; Thu, 22 Feb 2024 00:56:53 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Thu, 22 Feb 2024 09:56:41 +0100 Message-ID: Subject: Re: [PATCH] libcpp: Improve location for macro names [PR66290] To: Lewis Hyatt Cc: Alexandre Oliva , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 20, 2024 at 3:33=E2=80=AFPM Lewis Hyatt wrot= e: > > On Mon, Feb 19, 2024 at 11:36=E2=80=AFPM Alexandre Oliva wrote: > > > > This backport for gcc-13 is the first of two required for the > > g++.dg/pch/line-map-3.C test to stop hitting a variant of the known > > problem mentioned in that testcase: on riscv64-elf and riscv32-elf, > > after restoring the PCH, the location of the macros is mentioned as if > > they were on line 3 rather than 2, so even the existing xfails fail. I > > think this might be too much to backport, and I'm ready to use an xfail > > instead, but since this would bring more predictability, I thought I'd > > ask whether you'd find this backport acceptable. > > > > Regstrapped on x86_64-linux-gnu, along with other backports, and tested > > manually on riscv64-elf. Ok to install? > > Sorry that test is causing a problem, I hadn't realized at first that > the wrong output was target-dependent. I feel like simply deleting > this test g++.dg/pch/line-map-3.C from GCC 13 branch should be fine > too, as a safer alternative, if release managers prefer? Yes please. Richard. It doesn't > really need to be on the branch, it's only purpose is to remind me to > fix the underlying issue for GCC 15... > > -Lewis