public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Stefan Schulze Frielinghaus <stefansf@linux.ibm.com>
Cc: krebbel@linux.ibm.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] s390: testsuite: Fix loop-interchange-16.c
Date: Thu, 11 Apr 2024 09:17:23 +0200	[thread overview]
Message-ID: <CAFiYyc0G1wyqAgtHNiTNPwYxU2-JG9vwnQqiTdepX2hWhKYAwg@mail.gmail.com> (raw)
In-Reply-To: <20240411070053.1979642-2-stefansf@linux.ibm.com>

On Thu, Apr 11, 2024 at 9:02 AM Stefan Schulze Frielinghaus
<stefansf@linux.ibm.com> wrote:
>
> Revert parameter max-completely-peel-times to 16, otherwise, the
> innermost loop is removed and we are left with no loop interchange which
> this test is all about.
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.dg/tree-ssa/loop-interchange-16.c: Revert parameter
>         max-completely-peel-times for s390.
> ---
>  Ok for mainline?

Can you check whether placing

#pragma GCC unroll 0

before the innermost loop works as well?  That'd be more to the point.

OK if that works.

thanks,
Richard.

>  gcc/testsuite/gcc.dg/tree-ssa/loop-interchange-16.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/loop-interchange-16.c b/gcc/testsuite/gcc.dg/tree-ssa/loop-interchange-16.c
> index 781555e085d..2530ec84bc0 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/loop-interchange-16.c
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/loop-interchange-16.c
> @@ -1,6 +1,7 @@
>  /* PR/101280 */
>  /* { dg-do compile } */
>  /* { dg-options "-O3 -fdump-tree-linterchange-details" } */
> +/* { dg-additional-options "--param max-completely-peel-times=16" { target s390*-*-* } } */
>
>  void dummy (double *, double *);
>  #define LEN_2D 32
> --
> 2.43.0
>

  reply	other threads:[~2024-04-11  7:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11  7:00 Stefan Schulze Frielinghaus
2024-04-11  7:17 ` Richard Biener [this message]
2024-04-11  7:46   ` [PATCH] " Stefan Schulze Frielinghaus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc0G1wyqAgtHNiTNPwYxU2-JG9vwnQqiTdepX2hWhKYAwg@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=krebbel@linux.ibm.com \
    --cc=stefansf@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).