From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id A82C038560B9 for ; Fri, 9 Jun 2023 09:04:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A82C038560B9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b1b1635661so16538591fa.0 for ; Fri, 09 Jun 2023 02:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686301477; x=1688893477; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k5aThEiiTnxcMtPBY8ST4ZeGljohnDo/9GB0h+Lnz/s=; b=NDkD7QO3MjBVgcM2GAlibAXMq4D2E6eziLjvVktEkhuBFJU5QqWLSuH2A10l9qGNqd OAgr7W8nuP5ddkrJvV0ge1wzkAcXxThnGL1Le9NB9PrcVqiYXprR04ypV3OuSqUkWdgA DJrgxgSjfqEukScFEKlr7b8cxKsmPXiXssVLhOtzcC28f35/ltp5tCHEBjzqzWtcSYyK 2V8XXmCOa2uv2EqE3D/IlQ5H0RQOxhDGLGiaDhmSiOc/nFDDKe6x3bKotMlnBot1AfP8 Z2OkT0F2w+bYKS5mOO8z0LoT5wdxLhf+JG2qUe5ljQX4OkF8637HQxvSzXrWmQmcSTjD XuvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301477; x=1688893477; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k5aThEiiTnxcMtPBY8ST4ZeGljohnDo/9GB0h+Lnz/s=; b=MkET2UB5xUIwVaYNl9TSTZj50D0PoOOxKQXYwZTZjsRgyBSAez8QDdJDk8pCllNa0v ewoUsJ7Qieno63vPmnq3voK6giKoyOt4EX7245+8EMDhTWk/oKaCBpAclEHXZ4I9/ZhZ cENx2JcvQAvnIf3YRz4OQfNX3Xr0NgKK58UfGByArvJMQvmZcQL3X+Hr2Rg76dJ1wkPd oPuIoEwinDz7UOmraO6RoliJ2vJ1+45pn/Bx/NKhwwpH2JqX243ChQMJKJV8ck6Rt4Of 6fHg7ZLET5uBeS3IFLNFfvsArNMNafFTabop0AQzqLOKqKISuDqaFt6cbh/iPGIk/NDu oCVw== X-Gm-Message-State: AC+VfDz/hPG1mYyZ3+JE2AOnlBq8Rz6QWq8kTojnHnLhlWiWa8CHmutC VQ4mim4WBXpTMM4xYZJJd9GRtUoIIgKpFhbYb3vuB85L X-Google-Smtp-Source: ACHHUZ6EdmqHv8iJyY+VT3E2ZvmO4pY5i2Cp4gkwWAwwYCmP/9bdwulqkAuLG8bATqrbEne2ytUhX3k2cAYoSKAY+QQ= X-Received: by 2002:a2e:8649:0:b0:2b1:ad15:fe38 with SMTP id i9-20020a2e8649000000b002b1ad15fe38mr681242ljj.3.1686301477048; Fri, 09 Jun 2023 02:04:37 -0700 (PDT) MIME-Version: 1.0 References: <20230608175709.462490-1-polacek@redhat.com> In-Reply-To: <20230608175709.462490-1-polacek@redhat.com> From: Richard Biener Date: Fri, 9 Jun 2023 11:04:24 +0200 Message-ID: Subject: Re: [PATCH] doc: Clarification for -Wmissing-field-initializers To: Marek Polacek Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jun 8, 2023 at 7:57=E2=80=AFPM Marek Polacek via Gcc-patches wrote: > > The manual is incorrect in saying that the option does not warn > about designated initializers, which it does in C++. Whether the > divergence in behavior is desirable is another thing, but let's > at least make the manual match the reality. OK. > PR c/39589 > PR c++/96868 > > gcc/ChangeLog: > > * doc/invoke.texi: Clarify that -Wmissing-field-initializers does= n't > warn about designated initializers in C only. > --- > gcc/doc/invoke.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index 6d08229ce40..0870f7aff93 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -9591,8 +9591,9 @@ struct s @{ int f, g, h; @}; > struct s x =3D @{ 3, 4 @}; > @end smallexample > > -This option does not warn about designated initializers, so the followin= g > -modification does not trigger a warning: > +@c It's unclear if this behavior is desirable. See PR39589 and PR96868. > +In C this option does not warn about designated initializers, so the > +following modification does not trigger a warning: > > @smallexample > struct s @{ int f, g, h; @}; > > base-commit: 1379ae33e05c28d705f3c69a3f6c774bf6e83136 > -- > 2.40.1 >