From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=hJr4=34=gmail.com=richard.guenther@sourceware.org>
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130])
	by sourceware.org (Postfix) with ESMTPS id 98F69385840E
	for <gcc-patches@gcc.gnu.org>; Mon, 28 Nov 2022 08:26:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 98F69385840E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-lf1-x130.google.com with SMTP id p8so16156435lfu.11
        for <gcc-patches@gcc.gnu.org>; Mon, 28 Nov 2022 00:26:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=fH3kXHwpq30FEUJ5sjy+1zrqDIouYqg0X2gk8b+G2es=;
        b=O/LZY+CUc06zF1a1VXLbRkOXJNJjuX1UgDuASLVPAbFdvHXlakZhzh4Eo8zX8318xx
         4w3yiMXN3mBFzkoVvuAvyGbP94t0JYu5iztVCYNyu3QUlV/Iox1DvU5FH5+sBL+sMYpd
         WqAOWlYaR1emX75fUYieVk0s684uYpfHgfz+j0yMOPfTcHNYOmxbZhqhvplr1RXt57e/
         C7efPq96k0cPHyJQMtphBvJ7BQ/vL/yp1P+4Ng1NjW1pVsBDA3fkoJMNz+ctyyHdHXq3
         cFiIOGWLOjN1BDl6IZJmCL235RlFa+Yz0rQoZVOMUaEieGlnz0xwoAimU+r1FJIQ0fy1
         Pd4w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=fH3kXHwpq30FEUJ5sjy+1zrqDIouYqg0X2gk8b+G2es=;
        b=b7mTeh8LqDTz0NzQy1Mhi02xkKgkI5t6oPtBngXqbQ3t2LfdLtG2V1Lk9KU0z2Em+N
         NxBVe9anTnZLixX0tk5wMD0thPJ+B0CFWPTcSDfbJsymFNWyYir1oY9CLetaDLsvLQkw
         3Qbw8glzaXoQTcoTm6BXuae0zLpEtT3I4MazXhbVBcM0zvabjEdEpnNa8cUgGCrJZk8u
         dpNcxkqmXx6z2rbBP4RWJNW4uu2FkBcek8XfUQ7hm/GWS8ylSrjplHsR4Py0AmaZuw4F
         RwPxxHoI1mZ+pVLQ/fUd6AP6MvcVMQ/7m1lYZhsrI4PP7zSgApw0jxv2zPnuCweLH7KI
         QTuQ==
X-Gm-Message-State: ANoB5plpsdDdR9OJ8MfMX73YIBqKEp/sdaOwsvFOYAm6hLtoTtO0+SWb
	kPIXUljABJumjogrsYpdx28TUqSopzgfXk5V4NU=
X-Google-Smtp-Source: AA0mqf758OBlaRiDBgOynQUP7/Ok5tfdMw7w1CGJmO/oefGENpPaPlNB37AKJw/CcQ7g039IIZLY8dozlZxBHAZ5hrc=
X-Received: by 2002:a19:ca0b:0:b0:4b1:7972:627a with SMTP id
 a11-20020a19ca0b000000b004b17972627amr9814957lfg.101.1669623966687; Mon, 28
 Nov 2022 00:26:06 -0800 (PST)
MIME-Version: 1.0
References: <CAEYL+X9Mc0phSoX5uC1_eqO81akqR1jz+=FNs-_mdq64hS-2xA@mail.gmail.com>
 <CAFiYyc3E0J5GYoxLYcjp9EOMSW=QwW12kddLhYQBe=sP+gMhkQ@mail.gmail.com> <CAEYL+X9vPYwZ25V_irLi1rH_3rusU8cmyrc6pwZP-n2JrTLLww@mail.gmail.com>
In-Reply-To: <CAEYL+X9vPYwZ25V_irLi1rH_3rusU8cmyrc6pwZP-n2JrTLLww@mail.gmail.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Mon, 28 Nov 2022 09:25:54 +0100
Message-ID: <CAFiYyc0HgO-+Su1eB8pN_dT6T2Zg=TY458YOmhELbmK1MRSFLQ@mail.gmail.com>
Subject: Re: [PATCH 14/56] middle-end: Set TREE_ADDRESSABLE in folding debug stmts.
To: Zopolis0 <creatorsmithmdt@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Sat, Nov 26, 2022 at 1:19 AM Zopolis0 <creatorsmithmdt@gmail.com> wrote:
>
> I was reverting a076632e274abe344ca7648b7c7f299273d4cbe0 as it removed code for Java, but I may have misunderstood the change and made the incorrect edits.

The change is fixing a bug (setting TREE_ADDRESSABLE from a CTOR in
debug stmts) and fixes up the C++ frontend to
properly mark things addressable when needed.  I suspect the Java
frontend will need something similar - when
there's breakage without this reversion track down where what is
complained on is produced in the Java frontend
and properly mark things as TREE_ADDRESSABLE there.

Richard.

> On Sat, 26 Nov 2022 at 07:16, Richard Biener <richard.guenther@gmail.com> wrote:
>>
>> On Fri, Nov 25, 2022 at 9:43 AM Zopolis0 via Gcc-patches
>> <gcc-patches@gcc.gnu.org> wrote:
>> >
>>
>> That's wrong and the comment you remove explains why.